From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 14:17:25 -0800 [thread overview]
Message-ID: <1453328245.2958.28.camel@intel.com> (raw)
In-Reply-To: <2806620.EpZqDlZTO3@wuerfel>
On Wed, 2016-01-20 at 11:42 +0100, Arnd Bergmann wrote:
> The addition of the geneve tunnel offload code left a couple
> of functions unconditionally defined but empty whenever CONFIG_VXLAN
> and CONFIG_GENEVE are disabled. gcc warns about this:
>
> i40e_main.c:7049:13: warning: 'i40e_sync_udp_filters_subtask' defined
> but not used [-Wunused-function]
> i40e_main.c:8516:13: warning: 'i40e_add_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8561:13: warning: 'i40e_del_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8596:13: warning: 'i40e_add_geneve_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8643:13: warning: 'i40e_del_geneve_port' defined but not
> used [-Wunused-function]
>
> This moves the #ifdef statements to the outside of the affected
> functions, which avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6a899024058d ("i40e: geneve tunnel offload support")
> ---
> This is a harmless regression against v4.4, found on ARM randconfig
> builds
Thanks Arnd, I already have a patch from Eric Dumazet and Alex Duyck to
resolve this issue.
Dave- I plan on pushing the fix later today to net.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160120/2a220f92/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: jeffrey.t.kirsher@intel.com (Jeff Kirsher)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 14:17:25 -0800 [thread overview]
Message-ID: <1453328245.2958.28.camel@intel.com> (raw)
In-Reply-To: <2806620.EpZqDlZTO3@wuerfel>
On Wed, 2016-01-20 at 11:42 +0100, Arnd Bergmann wrote:
> The addition of the geneve tunnel offload code left a couple
> of functions unconditionally defined but empty whenever CONFIG_VXLAN
> and CONFIG_GENEVE are disabled. gcc warns about this:
>
> i40e_main.c:7049:13: warning: 'i40e_sync_udp_filters_subtask' defined
> but not used [-Wunused-function]
> i40e_main.c:8516:13: warning: 'i40e_add_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8561:13: warning: 'i40e_del_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8596:13: warning: 'i40e_add_geneve_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8643:13: warning: 'i40e_del_geneve_port' defined but not
> used [-Wunused-function]
>
> This moves the #ifdef statements to the outside of the affected
> functions, which avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6a899024058d ("i40e: geneve tunnel offload support")
> ---
> This is a harmless regression against v4.4, found on ARM randconfig
> builds
Thanks Arnd, I already have a patch from Eric Dumazet and Alex Duyck to
resolve this issue.
Dave- I plan on pushing the fix later today to net.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160120/2a220f92/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org
Cc: davem@davemloft.net,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Shannon Nelson <shannon.nelson@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 14:17:25 -0800 [thread overview]
Message-ID: <1453328245.2958.28.camel@intel.com> (raw)
In-Reply-To: <2806620.EpZqDlZTO3@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
On Wed, 2016-01-20 at 11:42 +0100, Arnd Bergmann wrote:
> The addition of the geneve tunnel offload code left a couple
> of functions unconditionally defined but empty whenever CONFIG_VXLAN
> and CONFIG_GENEVE are disabled. gcc warns about this:
>
> i40e_main.c:7049:13: warning: 'i40e_sync_udp_filters_subtask' defined
> but not used [-Wunused-function]
> i40e_main.c:8516:13: warning: 'i40e_add_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8561:13: warning: 'i40e_del_vxlan_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8596:13: warning: 'i40e_add_geneve_port' defined but not
> used [-Wunused-function]
> i40e_main.c:8643:13: warning: 'i40e_del_geneve_port' defined but not
> used [-Wunused-function]
>
> This moves the #ifdef statements to the outside of the affected
> functions, which avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6a899024058d ("i40e: geneve tunnel offload support")
> ---
> This is a harmless regression against v4.4, found on ARM randconfig
> builds
Thanks Arnd, I already have a patch from Eric Dumazet and Alex Duyck to
resolve this issue.
Dave- I plan on pushing the fix later today to net.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-20 22:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:42 [Intel-wired-lan] [PATCH] net: i40e: avoid unused function warnings Arnd Bergmann
2016-01-20 10:42 ` Arnd Bergmann
2016-01-20 10:42 ` Arnd Bergmann
2016-01-20 22:17 ` Jeff Kirsher [this message]
2016-01-20 22:17 ` Jeff Kirsher
2016-01-20 22:17 ` Jeff Kirsher
2016-01-20 22:28 ` [Intel-wired-lan] " Arnd Bergmann
2016-01-20 22:28 ` Arnd Bergmann
2016-01-20 22:28 ` Arnd Bergmann
2016-01-20 22:44 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-20 22:44 ` Jeff Kirsher
2016-01-20 22:44 ` Jeff Kirsher
2016-01-20 22:54 ` [Intel-wired-lan] " Arnd Bergmann
2016-01-20 22:54 ` Arnd Bergmann
2016-01-20 22:54 ` Arnd Bergmann
2016-01-20 23:36 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-20 23:36 ` Jeff Kirsher
2016-01-20 23:36 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453328245.2958.28.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.