From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 15:36:03 -0800 [thread overview]
Message-ID: <1453332963.2958.39.camel@intel.com> (raw)
In-Reply-To: <6894276.2dlRmisKUo@wuerfel>
On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote:
> On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote:
> > Yeah, I have a fix for that as well.
> >?
> > You can confirm by pulling my next-queue tree (dev-queue branch).
> > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-
> queue.git d
> > ev-queue
> >?
>
> I checked out that branch, but still see both warnings in that one,
> plus
> a new build error in igb, which I don't see in linux-next:
>
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit
> declaration of function 'set_pages_uc' [-Werror=implicit-function-
> declaration]
> ? set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
> ? ^
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function
> 'igb_unmapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit
> declaration of function 'set_pages_wb' [-Werror=implicit-function-
> declaration]
> ? set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
Oops, I just realized I had not pushed my latest tree to kernel.org.
The igb issue still remains, I am working with the developer who
introduced the issue. ?Looks like the i40e issue about possible
uninitialized variables still exists. ?I thought we had resolved that
issue, but apparently not.
You should see Eric Dumazet's patch on the tree to resolve the other
i40e build warnings.
I can add your second patch to resolve the uninitialized variables to
my tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160120/448ae8f2/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: jeffrey.t.kirsher@intel.com (Jeff Kirsher)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 15:36:03 -0800 [thread overview]
Message-ID: <1453332963.2958.39.camel@intel.com> (raw)
In-Reply-To: <6894276.2dlRmisKUo@wuerfel>
On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote:
> On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote:
> > Yeah, I have a fix for that as well.
> >?
> > You can confirm by pulling my next-queue tree (dev-queue branch).
> > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-
> queue.git d
> > ev-queue
> >?
>
> I checked out that branch, but still see both warnings in that one,
> plus
> a new build error in igb, which I don't see in linux-next:
>
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit
> declaration of function 'set_pages_uc' [-Werror=implicit-function-
> declaration]
> ? set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
> ? ^
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function
> 'igb_unmapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit
> declaration of function 'set_pages_wb' [-Werror=implicit-function-
> declaration]
> ? set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
Oops, I just realized I had not pushed my latest tree to kernel.org.
The igb issue still remains, I am working with the developer who
introduced the issue. ?Looks like the i40e issue about possible
uninitialized variables still exists. ?I thought we had resolved that
issue, but apparently not.
You should see Eric Dumazet's patch on the tree to resolve the other
i40e build warnings.
I can add your second patch to resolve the uninitialized variables to
my tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160120/448ae8f2/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Shannon Nelson <shannon.nelson@intel.com>,
netdev@vger.kernel.org,
Mitch Williams <mitch.a.williams@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org,
John Ronciak <john.ronciak@intel.com>,
intel-wired-lan@lists.osuosl.org,
Don Skidmore <donald.c.skidmore@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
davem@davemloft.net
Subject: Re: [PATCH] net: i40e: avoid unused function warnings
Date: Wed, 20 Jan 2016 15:36:03 -0800 [thread overview]
Message-ID: <1453332963.2958.39.camel@intel.com> (raw)
In-Reply-To: <6894276.2dlRmisKUo@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote:
> On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote:
> > Yeah, I have a fix for that as well.
> >
> > You can confirm by pulling my next-queue tree (dev-queue branch).
> > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-
> queue.git d
> > ev-queue
> >
>
> I checked out that branch, but still see both warnings in that one,
> plus
> a new build error in igb, which I don't see in linux-next:
>
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function 'igb_mapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:150:2: error: implicit
> declaration of function 'set_pages_uc' [-Werror=implicit-function-
> declaration]
> set_pages_uc(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
> ^
> drivers/net/ethernet/intel/igb/igb_cdev.c: In function
> 'igb_unmapring':
> drivers/net/ethernet/intel/igb/igb_cdev.c:275:2: error: implicit
> declaration of function 'set_pages_wb' [-Werror=implicit-function-
> declaration]
> set_pages_wb(virt_to_page(ring->desc), ring->size >> PAGE_SHIFT);
Oops, I just realized I had not pushed my latest tree to kernel.org.
The igb issue still remains, I am working with the developer who
introduced the issue. Looks like the i40e issue about possible
uninitialized variables still exists. I thought we had resolved that
issue, but apparently not.
You should see Eric Dumazet's patch on the tree to resolve the other
i40e build warnings.
I can add your second patch to resolve the uninitialized variables to
my tree.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-20 23:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:42 [Intel-wired-lan] [PATCH] net: i40e: avoid unused function warnings Arnd Bergmann
2016-01-20 10:42 ` Arnd Bergmann
2016-01-20 10:42 ` Arnd Bergmann
2016-01-20 22:17 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-20 22:17 ` Jeff Kirsher
2016-01-20 22:17 ` Jeff Kirsher
2016-01-20 22:28 ` [Intel-wired-lan] " Arnd Bergmann
2016-01-20 22:28 ` Arnd Bergmann
2016-01-20 22:28 ` Arnd Bergmann
2016-01-20 22:44 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-20 22:44 ` Jeff Kirsher
2016-01-20 22:44 ` Jeff Kirsher
2016-01-20 22:54 ` [Intel-wired-lan] " Arnd Bergmann
2016-01-20 22:54 ` Arnd Bergmann
2016-01-20 22:54 ` Arnd Bergmann
2016-01-20 23:36 ` Jeff Kirsher [this message]
2016-01-20 23:36 ` Jeff Kirsher
2016-01-20 23:36 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453332963.2958.39.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.