From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
Date: Wed, 20 Jan 2016 19:32:19 -0800 [thread overview]
Message-ID: <1453347139.3312.2.camel@intel.com> (raw)
In-Reply-To: <1453277324-6180-1-git-send-email-ptikhomirov@virtuozzo.com>
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> ?drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
Why are you re-sending this patch? ?I already have it queued up for
testing in my tree. ?This just causes problems and extra work for me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160120/8c3c2202/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Andrew Vagin <avagin@parallels.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
devel@openvz.org
Subject: Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
Date: Wed, 20 Jan 2016 19:32:19 -0800 [thread overview]
Message-ID: <1453347139.3312.2.camel@intel.com> (raw)
In-Reply-To: <1453277324-6180-1-git-send-email-ptikhomirov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why are you re-sending this patch? I already have it queued up for
testing in my tree. This just causes problems and extra work for me.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-21 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 8:08 [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields Pavel Tikhomirov
2016-01-20 8:08 ` Pavel Tikhomirov
2016-01-21 3:32 ` Jeff Kirsher [this message]
2016-01-21 3:32 ` Jeff Kirsher
2016-01-21 4:17 ` [Intel-wired-lan] " Pavel Tikhomirov
2016-03-02 21:21 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453347139.3312.2.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.