* [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
@ 2016-01-20 8:08 ` Pavel Tikhomirov
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Tikhomirov @ 2016-01-20 8:08 UTC (permalink / raw)
To: intel-wired-lan
It seem to be non intentionaly changed to tx in
commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
multiple issues")
Lock is taken from ixgbe_low_latency_recv, and there under this
lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
tx counter.
Yield stats can be shown through ethtool:
ethtool -S enp129s0 | grep yield
v2: follow commit citing style
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 1d21745..7656d46 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
IXGBE_QV_STATE_POLL);
#ifdef BP_EXTENDED_STATS
if (rc != IXGBE_QV_STATE_IDLE)
- q_vector->tx.ring->stats.yields++;
+ q_vector->rx.ring->stats.yields++;
#endif
return rc == IXGBE_QV_STATE_IDLE;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
@ 2016-01-20 8:08 ` Pavel Tikhomirov
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Tikhomirov @ 2016-01-20 8:08 UTC (permalink / raw)
To: intel-wired-lan, netdev, Jeff Kirsher
Cc: Andrew Vagin, Konstantin Khorenko, devel
It seem to be non intentionaly changed to tx in
commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
multiple issues")
Lock is taken from ixgbe_low_latency_recv, and there under this
lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
tx counter.
Yield stats can be shown through ethtool:
ethtool -S enp129s0 | grep yield
v2: follow commit citing style
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 1d21745..7656d46 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
IXGBE_QV_STATE_POLL);
#ifdef BP_EXTENDED_STATS
if (rc != IXGBE_QV_STATE_IDLE)
- q_vector->tx.ring->stats.yields++;
+ q_vector->rx.ring->stats.yields++;
#endif
return rc == IXGBE_QV_STATE_IDLE;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
2016-01-20 8:08 ` Pavel Tikhomirov
@ 2016-01-21 3:32 ` Jeff Kirsher
-1 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2016-01-21 3:32 UTC (permalink / raw)
To: intel-wired-lan
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> ?drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
Why are you re-sending this patch? ?I already have it queued up for
testing in my tree. ?This just causes problems and extra work for me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160120/8c3c2202/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
@ 2016-01-21 3:32 ` Jeff Kirsher
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2016-01-21 3:32 UTC (permalink / raw)
To: Pavel Tikhomirov, intel-wired-lan, netdev
Cc: Andrew Vagin, Konstantin Khorenko, devel
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why are you re-sending this patch? I already have it queued up for
testing in my tree. This just causes problems and extra work for me.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
2016-01-21 3:32 ` Jeff Kirsher
(?)
@ 2016-01-21 4:17 ` Pavel Tikhomirov
-1 siblings, 0 replies; 6+ messages in thread
From: Pavel Tikhomirov @ 2016-01-21 4:17 UTC (permalink / raw)
To: intel-wired-lan
----???????????? Jeff Kirsher ??????? ----
> Why are you re-sending this patch? ?I already have it queued up for
> testing in my tree. ?This just causes problems and extra work for me.
Jeff, I'm very sorry for the inconveniences caused, I'm quite new to sending patches upstream, and was worrying about lack of review/response to my patch. Actually I thought the patch was lost.
I hugely appreciate your work, I re-sent patch for no other reason, so please ignore the "RESENT" copy.
Sorry again, Pavel.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160121/64107c02/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
2016-01-20 8:08 ` Pavel Tikhomirov
(?)
(?)
@ 2016-03-02 21:21 ` Bowers, AndrewX
-1 siblings, 0 replies; 6+ messages in thread
From: Bowers, AndrewX @ 2016-03-02 21:21 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Pavel Tikhomirov
> Sent: Wednesday, January 20, 2016 12:09 AM
> To: intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; Kirsher,
> Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: devel at openvz.org; Andrew Vagin <avagin@parallels.com>; Konstantin
> Khorenko <khorenko@virtuozzo.com>
> Subject: [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment
> rx.ring->stats.yields
>
> It seem to be non intentionaly changed to tx in commit adc810900a70
> ("ixgbe: Refactor busy poll socket code to address multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this lock we use
> ixgbe_clean_rx_irq so it looks wrong for me to increment tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Code change present, yield counters increment as expected with busy polling enabled.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-02 21:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 8:08 [Intel-wired-lan] [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields Pavel Tikhomirov
2016-01-20 8:08 ` Pavel Tikhomirov
2016-01-21 3:32 ` [Intel-wired-lan] " Jeff Kirsher
2016-01-21 3:32 ` Jeff Kirsher
2016-01-21 4:17 ` [Intel-wired-lan] " Pavel Tikhomirov
2016-03-02 21:21 ` Bowers, AndrewX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.