All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: konrad.wilk@oracle.com, rusty@rustcorp.com.au,
	luto@amacapital.net, boris.ostrovsky@oracle.com, mcb30@ipxe.org,
	jgross@suse.com, JBeulich@suse.com, joro@8bytes.org,
	ryabinin.a.a@gmail.com, long.wanglong@huawei.com,
	qiuxishi@huawei.com, aryabinin@virtuozzo.com,
	mchehab@osg.samsung.com, x86@kernel.org,
	xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2 1/3] paravirt: use bool for paravirt_enabled() and paravirt_has_feature()
Date: Fri,  5 Feb 2016 20:30:12 -0800	[thread overview]
Message-ID: <1454733014-15237-2-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1454733014-15237-1-git-send-email-mcgrof@kernel.org>

This avoids any possible misuse.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 arch/x86/include/asm/paravirt.h       | 6 +++---
 arch/x86/include/asm/paravirt_types.h | 2 +-
 arch/x86/include/asm/processor.h      | 4 ++--
 arch/x86/kernel/kvm.c                 | 2 +-
 arch/x86/kernel/paravirt.c            | 2 +-
 arch/x86/lguest/boot.c                | 2 +-
 arch/x86/xen/enlighten.c              | 2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index f6192502149e..60a71dfe0c4e 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -14,15 +14,15 @@
 #include <linux/types.h>
 #include <linux/cpumask.h>
 
-static inline int paravirt_enabled(void)
+static inline bool paravirt_enabled(void)
 {
 	return pv_info.paravirt_enabled;
 }
 
-static inline int paravirt_has_feature(unsigned int feature)
+static inline bool paravirt_has_feature(unsigned int feature)
 {
 	WARN_ON_ONCE(!pv_info.paravirt_enabled);
-	return (pv_info.features & feature);
+	return !!(pv_info.features & feature);
 }
 
 static inline void load_sp0(struct tss_struct *tss,
diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
index 77db5616a473..de2382b023f2 100644
--- a/arch/x86/include/asm/paravirt_types.h
+++ b/arch/x86/include/asm/paravirt_types.h
@@ -69,7 +69,7 @@ struct pv_info {
 	u16 extra_user_64bit_cs;  /* __USER_CS if none */
 #endif
 
-	int paravirt_enabled;
+	bool paravirt_enabled;
 	unsigned int features;	  /* valid only if paravirt_enabled is set */
 	const char *name;
 };
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 491a3d9dbb15..5a8e7a61d5be 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -470,8 +470,8 @@ static inline unsigned long current_top_of_stack(void)
 #include <asm/paravirt.h>
 #else
 #define __cpuid			native_cpuid
-#define paravirt_enabled()	0
-#define paravirt_has(x) 	0
+#define paravirt_enabled()	false
+#define paravirt_has(x) 	false
 
 static inline void load_sp0(struct tss_struct *tss,
 			    struct thread_struct *thread)
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 47190bd399e7..5c717b247e1b 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -290,7 +290,7 @@ static void __init paravirt_ops_setup(void)
 	 * features, and paravirt_enabled is about features that are
 	 * missing.
 	 */
-	pv_info.paravirt_enabled = 0;
+	pv_info.paravirt_enabled = false;
 
 	if (kvm_para_has_feature(KVM_FEATURE_NOP_IO_DELAY))
 		pv_cpu_ops.io_delay = kvm_io_delay;
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index f08ac28b8136..6b1f205a6ac7 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -294,7 +294,7 @@ enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
 
 struct pv_info pv_info = {
 	.name = "bare hardware",
-	.paravirt_enabled = 0,
+	.paravirt_enabled = false,
 	.kernel_rpl = 0,
 	.shared_kernel_pmd = 1,	/* Only used when CONFIG_X86_PAE is set */
 
diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
index a9033ae13369..c6f302f6dedb 100644
--- a/arch/x86/lguest/boot.c
+++ b/arch/x86/lguest/boot.c
@@ -1409,7 +1409,7 @@ __init void lguest_init(void)
 	/* We're under lguest. */
 	pv_info.name = "lguest";
 	/* Paravirt is enabled. */
-	pv_info.paravirt_enabled = 1;
+	pv_info.paravirt_enabled = true;
 	/* We're running at privilege level 1, not 0 as normal. */
 	pv_info.kernel_rpl = 1;
 	/* Everyone except Xen runs with this set. */
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 2c261082eadf..e303e0043881 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1186,7 +1186,7 @@ static unsigned xen_patch(u8 type, u16 clobbers, void *insnbuf,
 }
 
 static const struct pv_info xen_info __initconst = {
-	.paravirt_enabled = 1,
+	.paravirt_enabled = true,
 	.shared_kernel_pmd = 0,
 
 #ifdef CONFIG_X86_64
-- 
2.7.0

  reply	other threads:[~2016-02-06  4:30 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06  4:30 [PATCH v2 0/3] paravirt: rebrand paravirt_enabled as paravirt_legacy Luis R. Rodriguez
2016-02-06  4:30 ` Luis R. Rodriguez
2016-02-06  4:30 ` Luis R. Rodriguez [this message]
2016-02-06  4:30 ` [PATCH v2 2/3] paravirt: replace direct access to pv_info.paravirt_enabled Luis R. Rodriguez
2016-02-06  4:30   ` Luis R. Rodriguez
2016-02-06  4:30 ` [Cocci] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy Luis R. Rodriguez
2016-02-06  4:30   ` Luis R. Rodriguez
2016-02-06  4:30   ` Luis R. Rodriguez
2016-02-06  7:11   ` [Cocci] " Andy Lutomirski
2016-02-06  7:11     ` Andy Lutomirski
2016-02-06  7:11     ` Andy Lutomirski
2016-02-06  8:59     ` [Cocci] " Luis R. Rodriguez
2016-02-06  8:59       ` Luis R. Rodriguez
2016-02-06  8:59       ` Luis R. Rodriguez
2016-02-06 20:05       ` [Cocci] " Andy Lutomirski
2016-02-06 20:05         ` Andy Lutomirski
2016-02-06 20:05         ` Andy Lutomirski
2016-02-06 22:04         ` [Cocci] " Borislav Petkov
2016-02-06 22:04           ` Borislav Petkov
2016-02-06 22:04           ` Borislav Petkov
2016-02-08 15:39           ` [Cocci] " Boris Ostrovsky
2016-02-08 15:39             ` Boris Ostrovsky
2016-02-08 15:39             ` Boris Ostrovsky
2016-02-08 15:55             ` [Cocci] " Borislav Petkov
2016-02-08 15:55               ` Borislav Petkov
2016-02-08 15:55               ` Borislav Petkov
2016-02-08 16:05               ` [Cocci] [Xen-devel] " Andrew Cooper
2016-02-08 16:05                 ` Andrew Cooper
2016-02-08 16:05                 ` Andrew Cooper
2016-02-08 16:12                 ` [Cocci] " Boris Ostrovsky
2016-02-08 16:12                   ` Boris Ostrovsky
2016-02-08 16:12                   ` Boris Ostrovsky
2016-02-08 16:26                   ` [Cocci] " Andrew Cooper
2016-02-08 16:26                     ` Andrew Cooper
2016-02-08 16:26                     ` Andrew Cooper
2016-02-08 16:31                     ` [Cocci] " Boris Ostrovsky
2016-02-08 16:31                       ` Boris Ostrovsky
2016-02-08 16:31                       ` Boris Ostrovsky
2016-02-08 16:32                       ` [Cocci] " Andrew Cooper
2016-02-08 16:32                         ` Andrew Cooper
2016-02-08 16:32                         ` Andrew Cooper
2016-02-08 16:35                       ` [Cocci] " Borislav Petkov
2016-02-08 16:35                         ` Borislav Petkov
2016-02-08 16:35                         ` Borislav Petkov
2016-02-08 16:38                         ` [Cocci] " Andrew Cooper
2016-02-08 16:38                           ` Andrew Cooper
2016-02-08 16:38                           ` Andrew Cooper
2016-02-08 16:45                           ` [Cocci] " Borislav Petkov
2016-02-08 16:45                             ` Borislav Petkov
2016-02-08 16:45                             ` Borislav Petkov
2016-02-08 16:52                             ` Boris Ostrovsky
2016-02-08 16:52                               ` Boris Ostrovsky
2016-02-08 20:45                               ` Boris Ostrovsky
2016-02-08 20:45                                 ` Boris Ostrovsky
2016-02-08 21:06                                 ` Borislav Petkov
2016-02-08 21:06                                   ` Borislav Petkov
2016-02-08 16:53                             ` [Cocci] " Andrew Cooper
2016-02-08 16:53                               ` Andrew Cooper
2016-02-08 16:53                               ` Andrew Cooper
2016-02-08 17:13                               ` Borislav Petkov
2016-02-08 17:13                                 ` Borislav Petkov
2016-02-09  6:22                               ` Luis R. Rodriguez
2016-02-09  6:22                                 ` Luis R. Rodriguez
2016-02-08 16:41                         ` [Cocci] " Boris Ostrovsky
2016-02-08 16:41                           ` Boris Ostrovsky
2016-02-08 16:41                           ` Boris Ostrovsky
2016-02-08 16:52                           ` [Cocci] " Borislav Petkov
2016-02-08 16:52                             ` Borislav Petkov
2016-02-08 16:52                             ` Borislav Petkov
2016-02-08 15:31         ` [Cocci] " Boris Ostrovsky
2016-02-08 15:31           ` Boris Ostrovsky
2016-02-08 15:31           ` Boris Ostrovsky
2016-02-08 15:46           ` [Cocci] " Borislav Petkov
2016-02-08 15:46             ` Borislav Petkov
2016-02-08 15:46             ` Borislav Petkov
2016-02-09  6:59             ` Luis R. Rodriguez
2016-02-09  6:59               ` Luis R. Rodriguez
2016-02-08 21:04           ` Andy Lutomirski
2016-02-08 21:04             ` Andy Lutomirski
2016-02-09  7:06           ` Luis R. Rodriguez
2016-02-09  7:06             ` Luis R. Rodriguez
2016-02-17 20:07             ` Luis R. Rodriguez
2016-02-17 20:49               ` Borislav Petkov
2016-02-17 20:49                 ` Borislav Petkov
2016-02-17 21:12                 ` Luis R. Rodriguez
2016-02-17 21:12                   ` Luis R. Rodriguez
2016-02-17 21:21                 ` Boris Ostrovsky
2016-02-17 21:21                   ` Boris Ostrovsky
2016-02-17 22:03                   ` Borislav Petkov
2016-02-17 22:03                     ` Borislav Petkov
2016-02-17 22:18                     ` Andy Lutomirski
2016-02-17 22:18                       ` Andy Lutomirski
2016-02-17 22:39                       ` Boris Ostrovsky
2016-02-17 22:39                         ` Boris Ostrovsky
2016-02-17 23:39                         ` Borislav Petkov
2016-02-17 23:39                           ` Borislav Petkov
2016-02-17 22:19                     ` Boris Ostrovsky
2016-02-17 22:19                       ` Boris Ostrovsky
2016-02-17 22:35                     ` Luis R. Rodriguez
2016-02-17 22:35                       ` Luis R. Rodriguez
2016-02-09  6:41         ` Luis R. Rodriguez
2016-02-09  6:41           ` Luis R. Rodriguez
2016-02-08 21:49       ` Boris Ostrovsky
2016-02-08 21:49         ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454733014-15237-2-git-send-email-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=JBeulich@suse.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=long.wanglong@huawei.com \
    --cc=luto@amacapital.net \
    --cc=mcb30@ipxe.org \
    --cc=mchehab@osg.samsung.com \
    --cc=mingo@redhat.com \
    --cc=qiuxishi@huawei.com \
    --cc=rusty@rustcorp.com.au \
    --cc=ryabinin.a.a@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.