From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Borislav Petkov <bp@alien8.de>, "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Andy Lutomirski <luto@amacapital.net>,
Juergen Gross <jgross@suse.com>, Michael Brown <mcb30@ipxe.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Joerg Roedel <joro@8bytes.org>,
Robert Moore <robert.moore@intel.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Xen Devel <xen-devel@lists.xensource.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jan Beulich <JBeulich@suse.com>, Lv Zheng <lv.zheng@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
long.wanglong@huawei.com, Fengguang Wu <fengguang.wu@intel.com>,
qiuxishi@huawei.com, Andrey Ryabinin <ryabinin.a.a@gmail.com>,
david.e.box@intel.com, X86 ML <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy
Date: Wed, 17 Feb 2016 16:21:56 -0500 [thread overview]
Message-ID: <56C4E474.2070206@oracle.com> (raw)
In-Reply-To: <20160217204954.GO2023@pd.tnic>
On 02/17/2016 03:49 PM, Borislav Petkov wrote:
> On Wed, Feb 17, 2016 at 12:07:13PM -0800, Luis R. Rodriguez wrote:
>> OK so here's a wiki to keep track of progress of the difference uses:
>>
>> http://kernelnewbies.org/KernelProjects/remove-paravirt-enabled
>>
>> It seems we have a resolution one way or another for all except for
>> the use on arch/x86/mm/dump_pagetables.c, is that right?
>
> Why not?
>
> I think we should simply check the range as ffff800000000000 -
> ffff87ffffffffff is practically an ABI and nothing should be mapped
^^^^^^^^^
That's exactly the point: if something is mapped it's an error for a
non-PV kernel.
By removing paravirt_enabled() we may miss those errors. Worse, I think
we may even crash while doing pagetable walk (although it's probably
better to crash here than to use an unexpected translation in real code
somewhere)
-boris
> there anyway. No need for paravirt_enabled() there either.
>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Borislav Petkov <bp@alien8.de>, "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Andy Lutomirski <luto@amacapital.net>,
Juergen Gross <jgross@suse.com>, Michael Brown <mcb30@ipxe.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Joerg Roedel <joro@8bytes.org>,
Robert Moore <robert.moore@intel.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Xen Devel <xen-devel@lists.xensource.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jan Beulich <JBeulich@suse.com>, Lv Zheng <lv.zheng@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
long.wanglong@huawei.com, Fengguang Wu <fengguang.wu@intel.com>,
qiuxishi@huawei.com, Andrey Ryabinin <ryabinin.a.a@gmail.com>,
david.e.box@intel.co
Subject: Re: [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy
Date: Wed, 17 Feb 2016 16:21:56 -0500 [thread overview]
Message-ID: <56C4E474.2070206@oracle.com> (raw)
In-Reply-To: <20160217204954.GO2023@pd.tnic>
On 02/17/2016 03:49 PM, Borislav Petkov wrote:
> On Wed, Feb 17, 2016 at 12:07:13PM -0800, Luis R. Rodriguez wrote:
>> OK so here's a wiki to keep track of progress of the difference uses:
>>
>> http://kernelnewbies.org/KernelProjects/remove-paravirt-enabled
>>
>> It seems we have a resolution one way or another for all except for
>> the use on arch/x86/mm/dump_pagetables.c, is that right?
>
> Why not?
>
> I think we should simply check the range as ffff800000000000 -
> ffff87ffffffffff is practically an ABI and nothing should be mapped
^^^^^^^^^
That's exactly the point: if something is mapped it's an error for a
non-PV kernel.
By removing paravirt_enabled() we may miss those errors. Worse, I think
we may even crash while doing pagetable walk (although it's probably
better to crash here than to use an unexpected translation in real code
somewhere)
-boris
> there anyway. No need for paravirt_enabled() there either.
>
next prev parent reply other threads:[~2016-02-17 21:23 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 4:30 [PATCH v2 0/3] paravirt: rebrand paravirt_enabled as paravirt_legacy Luis R. Rodriguez
2016-02-06 4:30 ` Luis R. Rodriguez
2016-02-06 4:30 ` [PATCH v2 1/3] paravirt: use bool for paravirt_enabled() and paravirt_has_feature() Luis R. Rodriguez
2016-02-06 4:30 ` [PATCH v2 2/3] paravirt: replace direct access to pv_info.paravirt_enabled Luis R. Rodriguez
2016-02-06 4:30 ` Luis R. Rodriguez
2016-02-06 4:30 ` [Cocci] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy Luis R. Rodriguez
2016-02-06 4:30 ` Luis R. Rodriguez
2016-02-06 4:30 ` Luis R. Rodriguez
2016-02-06 7:11 ` [Cocci] " Andy Lutomirski
2016-02-06 7:11 ` Andy Lutomirski
2016-02-06 7:11 ` Andy Lutomirski
2016-02-06 8:59 ` [Cocci] " Luis R. Rodriguez
2016-02-06 8:59 ` Luis R. Rodriguez
2016-02-06 8:59 ` Luis R. Rodriguez
2016-02-06 20:05 ` [Cocci] " Andy Lutomirski
2016-02-06 20:05 ` Andy Lutomirski
2016-02-06 20:05 ` Andy Lutomirski
2016-02-06 22:04 ` [Cocci] " Borislav Petkov
2016-02-06 22:04 ` Borislav Petkov
2016-02-06 22:04 ` Borislav Petkov
2016-02-08 15:39 ` [Cocci] " Boris Ostrovsky
2016-02-08 15:39 ` Boris Ostrovsky
2016-02-08 15:39 ` Boris Ostrovsky
2016-02-08 15:55 ` [Cocci] " Borislav Petkov
2016-02-08 15:55 ` Borislav Petkov
2016-02-08 15:55 ` Borislav Petkov
2016-02-08 16:05 ` [Cocci] [Xen-devel] " Andrew Cooper
2016-02-08 16:05 ` Andrew Cooper
2016-02-08 16:05 ` Andrew Cooper
2016-02-08 16:12 ` [Cocci] " Boris Ostrovsky
2016-02-08 16:12 ` Boris Ostrovsky
2016-02-08 16:12 ` Boris Ostrovsky
2016-02-08 16:26 ` [Cocci] " Andrew Cooper
2016-02-08 16:26 ` Andrew Cooper
2016-02-08 16:26 ` Andrew Cooper
2016-02-08 16:31 ` [Cocci] " Boris Ostrovsky
2016-02-08 16:31 ` Boris Ostrovsky
2016-02-08 16:31 ` Boris Ostrovsky
2016-02-08 16:32 ` [Cocci] " Andrew Cooper
2016-02-08 16:32 ` Andrew Cooper
2016-02-08 16:32 ` Andrew Cooper
2016-02-08 16:35 ` [Cocci] " Borislav Petkov
2016-02-08 16:35 ` Borislav Petkov
2016-02-08 16:35 ` Borislav Petkov
2016-02-08 16:38 ` [Cocci] " Andrew Cooper
2016-02-08 16:38 ` Andrew Cooper
2016-02-08 16:38 ` Andrew Cooper
2016-02-08 16:45 ` [Cocci] " Borislav Petkov
2016-02-08 16:45 ` Borislav Petkov
2016-02-08 16:45 ` Borislav Petkov
2016-02-08 16:52 ` Boris Ostrovsky
2016-02-08 16:52 ` Boris Ostrovsky
2016-02-08 20:45 ` Boris Ostrovsky
2016-02-08 20:45 ` Boris Ostrovsky
2016-02-08 21:06 ` Borislav Petkov
2016-02-08 21:06 ` Borislav Petkov
2016-02-08 16:53 ` [Cocci] " Andrew Cooper
2016-02-08 16:53 ` Andrew Cooper
2016-02-08 16:53 ` Andrew Cooper
2016-02-08 17:13 ` Borislav Petkov
2016-02-08 17:13 ` Borislav Petkov
2016-02-09 6:22 ` Luis R. Rodriguez
2016-02-09 6:22 ` Luis R. Rodriguez
2016-02-08 16:41 ` [Cocci] " Boris Ostrovsky
2016-02-08 16:41 ` Boris Ostrovsky
2016-02-08 16:41 ` Boris Ostrovsky
2016-02-08 16:52 ` [Cocci] " Borislav Petkov
2016-02-08 16:52 ` Borislav Petkov
2016-02-08 16:52 ` Borislav Petkov
2016-02-08 15:31 ` [Cocci] " Boris Ostrovsky
2016-02-08 15:31 ` Boris Ostrovsky
2016-02-08 15:31 ` Boris Ostrovsky
2016-02-08 15:46 ` [Cocci] " Borislav Petkov
2016-02-08 15:46 ` Borislav Petkov
2016-02-08 15:46 ` Borislav Petkov
2016-02-09 6:59 ` Luis R. Rodriguez
2016-02-09 6:59 ` Luis R. Rodriguez
2016-02-08 21:04 ` Andy Lutomirski
2016-02-08 21:04 ` Andy Lutomirski
2016-02-09 7:06 ` Luis R. Rodriguez
2016-02-09 7:06 ` Luis R. Rodriguez
2016-02-17 20:07 ` Luis R. Rodriguez
2016-02-17 20:49 ` Borislav Petkov
2016-02-17 20:49 ` Borislav Petkov
2016-02-17 21:12 ` Luis R. Rodriguez
2016-02-17 21:12 ` Luis R. Rodriguez
2016-02-17 21:21 ` Boris Ostrovsky [this message]
2016-02-17 21:21 ` Boris Ostrovsky
2016-02-17 22:03 ` Borislav Petkov
2016-02-17 22:03 ` Borislav Petkov
2016-02-17 22:18 ` Andy Lutomirski
2016-02-17 22:18 ` Andy Lutomirski
2016-02-17 22:39 ` Boris Ostrovsky
2016-02-17 22:39 ` Boris Ostrovsky
2016-02-17 23:39 ` Borislav Petkov
2016-02-17 23:39 ` Borislav Petkov
2016-02-17 22:19 ` Boris Ostrovsky
2016-02-17 22:19 ` Boris Ostrovsky
2016-02-17 22:35 ` Luis R. Rodriguez
2016-02-17 22:35 ` Luis R. Rodriguez
2016-02-09 6:41 ` Luis R. Rodriguez
2016-02-09 6:41 ` Luis R. Rodriguez
2016-02-08 21:49 ` Boris Ostrovsky
2016-02-08 21:49 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4E474.2070206@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=david.e.box@intel.com \
--cc=david.vrabel@citrix.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=mcb30@ipxe.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.