All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
	vishal.l.verma@intel.com, micah.parrish@hpe.com,
	brian.boylston@hpe.com, x86@kernel.org,
	linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy
Date: Tue, 09 Feb 2016 09:36:26 -0700	[thread overview]
Message-ID: <1455035786.2925.81.camel@hpe.com> (raw)
In-Reply-To: <20160209120816.GC500@gmail.com>

On Tue, 2016-02-09 at 13:08 +0100, Ingo Molnar wrote:
> * Borislav Petkov <bp@suse.de> wrote:
> 
> > On Tue, Feb 09, 2016 at 12:27:32PM +0100, Ingo Molnar wrote:
> > > Btw., IIRC GAS is being silly about .L, i.e. there's a difference
> > > between these 
> > > two variants:
> > > 
> > >  .Lerror_entry_from_usermode_swapgs:
> > >  .L_error_entry_from_usermode_swapgs:
> > > 
> > > the latter would be easier to read, but does not result in a local
> > > label last I 
> > > checked.
> > > 
> > > Right?
> > 
> > Seems to build ok here with "GNU assembler (GNU Binutils)
> > 2.26.51.20151207".
> > Perhaps some bug with older gas...?
> 
> Hm, indeed - I just tried it too.
> 
> This means that the (slightly) more readable .L_ prefix is preferred.

Thanks for the suggestions!  I will update the patch accordingly. 
-Toshi

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
	vishal.l.verma@intel.com, micah.parrish@hpe.com,
	brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy
Date: Tue, 09 Feb 2016 09:36:26 -0700	[thread overview]
Message-ID: <1455035786.2925.81.camel@hpe.com> (raw)
In-Reply-To: <20160209120816.GC500@gmail.com>

On Tue, 2016-02-09 at 13:08 +0100, Ingo Molnar wrote:
> * Borislav Petkov <bp@suse.de> wrote:
> 
> > On Tue, Feb 09, 2016 at 12:27:32PM +0100, Ingo Molnar wrote:
> > > Btw., IIRC GAS is being silly about .L, i.e. there's a difference
> > > between these 
> > > two variants:
> > > 
> > >  .Lerror_entry_from_usermode_swapgs:
> > >  .L_error_entry_from_usermode_swapgs:
> > > 
> > > the latter would be easier to read, but does not result in a local
> > > label last I 
> > > checked.
> > > 
> > > Right?
> > 
> > Seems to build ok here with "GNU assembler (GNU Binutils)
> > 2.26.51.20151207".
> > Perhaps some bug with older gas...?
> 
> Hm, indeed - I just tried it too.
> 
> This means that the (slightly) more readable .L_ prefix is preferred.

Thanks for the suggestions!  I will update the patch accordingly. 
-Toshi

  reply	other threads:[~2016-02-09 16:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 18:35 [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy Toshi Kani
2016-02-03 18:35 ` Toshi Kani
2016-02-09 10:27 ` Ingo Molnar
2016-02-09 10:27   ` Ingo Molnar
2016-02-09 11:14   ` Borislav Petkov
2016-02-09 11:14     ` Borislav Petkov
2016-02-09 11:27     ` Ingo Molnar
2016-02-09 11:27       ` Ingo Molnar
2016-02-09 11:53       ` Borislav Petkov
2016-02-09 11:53         ` Borislav Petkov
2016-02-09 12:08         ` Ingo Molnar
2016-02-09 12:08           ` Ingo Molnar
2016-02-09 16:36           ` Toshi Kani [this message]
2016-02-09 16:36             ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455035786.2925.81.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=bp@suse.de \
    --cc=brian.boylston@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=micah.parrish@hpe.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=vishal.l.verma@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.