All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Toshi Kani <toshi.kani@hpe.com>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
	vishal.l.verma@intel.com, micah.parrish@hpe.com,
	brian.boylston@hpe.com, x86@kernel.org,
	linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy
Date: Tue, 9 Feb 2016 12:27:32 +0100	[thread overview]
Message-ID: <20160209112732.GB500@gmail.com> (raw)
In-Reply-To: <20160209111404.GA4434@pd.tnic>


* Borislav Petkov <bp@suse.de> wrote:

> On Tue, Feb 09, 2016 at 11:27:41AM +0100, Ingo Molnar wrote:
> > So another pet peeve of mine is to not use numeric labels, please use 
> > descriptively named labels instead.
>
> ... and prepend them with ".L" so that they become local labels.

Yes. A good example to follow would be arch/x86/entry/entry_64.S.

Btw., IIRC GAS is being silly about .L, i.e. there's a difference between these 
two variants:

 .Lerror_entry_from_usermode_swapgs:
 .L_error_entry_from_usermode_swapgs:

the latter would be easier to read, but does not result in a local label last I 
checked.

Right?

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Toshi Kani <toshi.kani@hpe.com>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
	vishal.l.verma@intel.com, micah.parrish@hpe.com,
	brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy
Date: Tue, 9 Feb 2016 12:27:32 +0100	[thread overview]
Message-ID: <20160209112732.GB500@gmail.com> (raw)
In-Reply-To: <20160209111404.GA4434@pd.tnic>


* Borislav Petkov <bp@suse.de> wrote:

> On Tue, Feb 09, 2016 at 11:27:41AM +0100, Ingo Molnar wrote:
> > So another pet peeve of mine is to not use numeric labels, please use 
> > descriptively named labels instead.
>
> ... and prepend them with ".L" so that they become local labels.

Yes. A good example to follow would be arch/x86/entry/entry_64.S.

Btw., IIRC GAS is being silly about .L, i.e. there's a difference between these 
two variants:

 .Lerror_entry_from_usermode_swapgs:
 .L_error_entry_from_usermode_swapgs:

the latter would be easier to read, but does not result in a local label last I 
checked.

Right?

Thanks,

	Ingo

  reply	other threads:[~2016-02-09 11:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 18:35 [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy Toshi Kani
2016-02-03 18:35 ` Toshi Kani
2016-02-09 10:27 ` Ingo Molnar
2016-02-09 10:27   ` Ingo Molnar
2016-02-09 11:14   ` Borislav Petkov
2016-02-09 11:14     ` Borislav Petkov
2016-02-09 11:27     ` Ingo Molnar [this message]
2016-02-09 11:27       ` Ingo Molnar
2016-02-09 11:53       ` Borislav Petkov
2016-02-09 11:53         ` Borislav Petkov
2016-02-09 12:08         ` Ingo Molnar
2016-02-09 12:08           ` Ingo Molnar
2016-02-09 16:36           ` Toshi Kani
2016-02-09 16:36             ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209112732.GB500@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@suse.de \
    --cc=brian.boylston@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=micah.parrish@hpe.com \
    --cc=mingo@redhat.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hpe.com \
    --cc=vishal.l.verma@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.