Re: [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu

[Joshua G Lock <joshua.g.lock@linux.intel.com>]

Hi Mirela,

On Thu, 2016-02-04 at 15:22 +0000, Mirela Rabulea wrote:
> Hi Joshua,
> Please see my comments below, prefixed with [M.R.].
> Thanks a lot for the review, v2 of the patch is attached (squashed
> version, sorry, but my git send-email is still not working).
> 
> Only the latest changes, for easier review:

These changes look good, thanks.

I've tested this patch a couple of ways. If I launch Hob and press
"Images" to load an existing image from somewhere in my filesystem
things seem to work as expected.

However if I build an image (core-image-minimal) for a non-qemu machine
(genericx86-64), once the build is done I can see 'Run custom image'
button (between 'Build new image' and 'Deploy image').

The 'Run script' box indicates that the script is pointing to 'runqemu'
but when I click 'Run custom image' I get a dialogue asking to 'Select
the image file you want to run:' with 'Cancel' and 'Run image' buttons
but nothing listing selectable images (I even tried resizing the
dialogue, to no avail). If I proceed to click 'Run image' button the
'Usb image maker' dialogue is presented.

Regards,

Joshua