All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua G Lock <joshua.g.lock@linux.intel.com>
To: Mirela Rabulea <mirela.rabulea@nxp.com>,
	 "bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Cc: Nicolae Manescu <nicu.manescu@nxp.com>,
	Alexandru Purice <alexandru.purice@nxp.com>,
	"Roman, Alexandru CostinX" <alexandru.costinx.roman@intel.com>,
	"Voiculescu, BogdanX A" <bogdanx.a.voiculescu@intel.com>
Subject: Re: [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu
Date: Tue, 16 Feb 2016 16:07:15 +0000	[thread overview]
Message-ID: <1455638835.3731.8.camel@linux.intel.com> (raw)
In-Reply-To: <VI1PR0401MB1789BE8BA7AD90A09B2C23E18FAB0@VI1PR0401MB1789.eurprd04.prod.outlook.com>

Hi Mirela,

On Sun, 2016-02-14 at 22:09 +0000, Mirela Rabulea wrote:
> Hi Joshua,
> I found one more issue with a corner case when commuting from "Run
> custom image" to "Deploy image". From the comments I found in the
> code, the case when there are both "runnable" and "deployable"
> present in the same build is not expected.
> However, with the introduction of the "Run custom", I think this
> requires a fix, so here is the v4 of the patch (squashed version
> attached).
> If you did not get to check the v3 patch, you may skip it and check
> the v4.

This version seems to work much better, thanks.

I've had another look over the patch and it looks OK to me. The only
thing which seems a little strange is that in several parts of the
patch you're accessing and setting a self.is_runnable property but at
Ln 217, Ln 220 & Ln 237 in ImageDetailsPage you're using a local
variable called is_runnable — is that correct/intended?

Thanks for your work on this,

Joshua


  parent reply	other threads:[~2016-02-16 16:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 15:52 [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu Mirela Rabulea
2016-01-27 14:03 ` Joshua G Lock
2016-02-04 15:22   ` Mirela Rabulea
2016-02-10 21:10     ` Joshua G Lock
2016-02-11 11:19       ` Mirela Rabulea
2016-02-12 22:43         ` Mirela Rabulea
2016-02-14 22:09           ` Mirela Rabulea
2016-02-15 16:54             ` Joshua G Lock
2016-02-15 16:59               ` Joshua G Lock
2016-02-16 16:07             ` Joshua G Lock [this message]
2016-02-16 22:09               ` Mirela Rabulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455638835.3731.8.camel@linux.intel.com \
    --to=joshua.g.lock@linux.intel.com \
    --cc=alexandru.costinx.roman@intel.com \
    --cc=alexandru.purice@nxp.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=bogdanx.a.voiculescu@intel.com \
    --cc=mirela.rabulea@nxp.com \
    --cc=nicu.manescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.