Re: [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu

[Joshua G Lock <joshua.g.lock@linux.intel.com>]

On Sun, 2016-02-14 at 22:09 +0000, Mirela Rabulea wrote:
> Hi Joshua,
> I found one more issue with a corner case when commuting from "Run
> custom image" to "Deploy image". From the comments I found in the
> code, the case when there are both "runnable" and "deployable"
> present in the same build is not expected.
> However, with the introduction of the "Run custom", I think this
> requires a fix, so here is the v4 of the patch (squashed version
> attached).
> If you did not get to check the v3 patch, you may skip it and check
> the v4.

With this patch applied I'm still seeing the same behaviour — after
building core-image-minimal for genericx86-64 runqemu is displayed as
the run script but clicking on "Run custom image" launches the "Usb
image maker".

Regards,

Joshua

> Only the v4 fix:
> From 4e6c941d74a7b1e11fbd26085a6908b746f61536 Mon Sep 17 00:00:00
> 2001
> From: Mirela Rabulea <mirela.rabulea@nxp.com>
> Date: Sun, 14 Feb 2016 23:42:32 +0200
> Subject: [PATCH] Allow Hob to run images on a custom simulator, other
> than
>  qemu Fixed bug when commuting from deploy image to run custom image.
> 
> Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> ---
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
> b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
> index b22cf80..32d4854 100755
> --- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
> +++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
> @@ -516,8 +516,9 @@ class ImageDetailsPage (HobPage):
>          for fileitem in action_images:
>              sel_btn = gtk.RadioButton(sel_parent_btn,
> fileitem['type'])
>              sel_parent_btn = sel_btn if not sel_parent_btn else
> sel_parent_btn
> -            if fileitem['name'] == self.toggled_image:
> +            if curr_row == 0:
>                  sel_btn.set_active(True)
> +                self.toggled_image = fileitem['name']
>              sel_btn.connect('toggled', self.table_selected_cb,
> fileitem)
>              if curr_row < 10:
>                  table.attach(sel_btn, 0, 4, curr_row, curr_row + 1,
> xpadding=24)