[RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[Christopher Larson]

From: Christopher Larson <chris_larson@mentor.com>

An example prefix: `perl-5.22.1-r0 do_compile:`

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 lib/bb/ui/knotty.py | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py
index a8b968c..87e2a64 100644
--- a/lib/bb/ui/knotty.py
+++ b/lib/bb/ui/knotty.py
@@ -359,11 +359,19 @@ def main(server, eventHandler, params, tf = TerminalFilter):
                     return_value = 1
                 elif event.levelno == format.WARNING:
                     warnings = warnings + 1
-                # For "normal" logging conditions, don't show note logs from tasks
-                # but do show them if the user has changed the default log level to
-                # include verbose/debug messages
-                if event.taskpid != 0 and event.levelno <= format.NOTE and (event.levelno < llevel or (event.levelno == format.NOTE and llevel != format.VERBOSE)):
-                    continue
+
+                if event.taskpid != 0:
+                    # For "normal" logging conditions, don't show note logs from tasks
+                    # but do show them if the user has changed the default log level to
+                    # include verbose/debug messages
+                    if event.levelno <= format.NOTE and (event.levelno < llevel or (event.levelno == format.NOTE and llevel != format.VERBOSE)):
+                        continue
+
+                    # Prefix task messages with recipe/task
+                    if event.taskpid in helper.running_tasks:
+                        taskinfo = helper.running_tasks[event.taskpid]
+                        event.msg = taskinfo['title'] + ': ' + event.msg
+
                 logger.handle(event)
                 continue
 
-- 
2.2.1

Re: [RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

On Thu, Feb 11, 2016 at 5:13 PM Christopher Larson <kergoth@gmail.com>
wrote:

> From: Christopher Larson <chris_larson@mentor.com>
>
> An example prefix: `perl-5.22.1-r0 do_compile:`
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>

I realize this may well be something to do for 2.2 rather than 2.1, but I
wanted to throw it out and get thoughts on it, as I'm sick of manually
prefixing our log messages in tasks :)

[-- Attachment #2: Type: text/html, Size: 847 bytes --]

Re: [RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[Richard Purdie]

On Fri, 2016-02-12 at 00:15 +0000, Christopher Larson wrote:
> On Thu, Feb 11, 2016 at 5:13 PM Christopher Larson <kergoth@gmail.com
> > wrote:
> > From: Christopher Larson <chris_larson@mentor.com>
> > 
> > An example prefix: `perl-5.22.1-r0 do_compile:`
> > 
> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> I realize this may well be something to do for 2.2 rather than 2.1,
> but I wanted to throw it out and get thoughts on it, as I'm sick of
> manually prefixing our log messages in tasks :)

I like the idea and actually wondered why this was an RFC, shouldn't we
just do it?

Having watched oe-selftest having a problems with this, I can see why
we may need to be more cautious :/.

Still trying to assess how bad the issues there are.

Cheers,

Richard

Re: [RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[Richard Purdie]

On Sun, 2016-02-14 at 15:18 +0000, Richard Purdie wrote:
> On Fri, 2016-02-12 at 00:15 +0000, Christopher Larson wrote:
> > On Thu, Feb 11, 2016 at 5:13 PM Christopher Larson <
> > kergoth@gmail.com
> > > wrote:
> > > From: Christopher Larson <chris_larson@mentor.com>
> > > 
> > > An example prefix: `perl-5.22.1-r0 do_compile:`
> > > 
> > > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > I realize this may well be something to do for 2.2 rather than 2.1,
> > but I wanted to throw it out and get thoughts on it, as I'm sick of
> > manually prefixing our log messages in tasks :)
> 
> I like the idea and actually wondered why this was an RFC, shouldn't
> we
> just do it?
> 
> Having watched oe-selftest having a problems with this, I can see why
> we may need to be more cautious :/.
> 
> Still trying to assess how bad the issues there are.

Fixed the issues in selftest so decided to merge this as it is an issue
we've needed to address for a while.

Thanks!

Richard

Re: [RFC PATCH 1/1] bb.ui.knotty: prefix task messages with recipe/task

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On Tue, Feb 16, 2016 at 4:15 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sun, 2016-02-14 at 15:18 +0000, Richard Purdie wrote:
> > On Fri, 2016-02-12 at 00:15 +0000, Christopher Larson wrote:
> > > On Thu, Feb 11, 2016 at 5:13 PM Christopher Larson <
> > > kergoth@gmail.com
> > > > wrote:
> > > > From: Christopher Larson <chris_larson@mentor.com>
> > > >
> > > > An example prefix: `perl-5.22.1-r0 do_compile:`
> > > >
> > > > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > > I realize this may well be something to do for 2.2 rather than 2.1,
> > > but I wanted to throw it out and get thoughts on it, as I'm sick of
> > > manually prefixing our log messages in tasks :)
> >
> > I like the idea and actually wondered why this was an RFC, shouldn't
> > we
> > just do it?
> >
> > Having watched oe-selftest having a problems with this, I can see why
> > we may need to be more cautious :/.
> >
> > Still trying to assess how bad the issues there are.
>
> Fixed the issues in selftest so decided to merge this as it is an issue
> we've needed to address for a while.
>
> Thanks!
>

NP, Thanks for taking the time to look into and test this.

[-- Attachment #2: Type: text/html, Size: 1868 bytes --]