All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simo <simo-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Andreas Gruenbacher
	<agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Alexander Viro
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Trond Myklebust
	<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
	Andreas Dilger
	<adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Anna Schumaker
	<anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4)
Date: Sat, 12 Mar 2016 16:12:27 -0500	[thread overview]
Message-ID: <1457817147.3540.28.camel@samba.org> (raw)
In-Reply-To: <20160311140757.GB13178-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>

On Fri, 2016-03-11 at 09:07 -0500, J. Bruce Fields wrote:
> On Fri, Mar 11, 2016 at 06:01:34AM -0800, Christoph Hellwig wrote:
> > 
> > On Mon, Feb 29, 2016 at 09:17:05AM +0100, Andreas Gruenbacher
> > wrote:
> > > 
> > > Al,
> > > 
> > > could you please make sure you are happy with the current version
> > > of the
> > > richacl patch queue for the next merge window?
> > I'm still not happy.
> > 
> > For one I still see no reason to merge this broken ACL model at
> > all.
> > It provides our actualy Linux users no benefit at all, while
> > breaking
> > a lot of assumptions, especially by adding allow and deny ACE at
> > the
> > same sime.
> Could you explain what you mean by "adding allow and deny ACE at the
> same time"?
> 
> > 
> > It also doesn't help with the issue that the main thing it's trying
> > to be compatible with (Windows) actually uses a fundamentally
> > different
> > identifier to apply the ACLs to - as long as you're still limited
> > to users and groups and not guids we'll still have that mapping
> > problem
> > anyway.
> Agreed, but, one step at a time?  My impression is that the Samba
> people
> still consider this a step forward for Linux compatibility.

It is a step forward, but being able to store SIDs in the ACL, would be
a much better one.

Simo.

> --b.
> 
> > 
> > 
> > But besides that fundamental question on the purpose of it I also
> > don't think the code is suitable, more in the individual patches.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" 
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Simo <simo@samba.org>
To: "J. Bruce Fields" <bfields@fieldses.org>,
	Christoph Hellwig <hch@infradead.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-nfs@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	linux-cifs@vger.kernel.org, linux-api@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-fsdevel@vger.kernel.org,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-ext4@vger.kernel.org,
	Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4)
Date: Sat, 12 Mar 2016 16:12:27 -0500	[thread overview]
Message-ID: <1457817147.3540.28.camel@samba.org> (raw)
In-Reply-To: <20160311140757.GB13178@fieldses.org>

On Fri, 2016-03-11 at 09:07 -0500, J. Bruce Fields wrote:
> On Fri, Mar 11, 2016 at 06:01:34AM -0800, Christoph Hellwig wrote:
> > 
> > On Mon, Feb 29, 2016 at 09:17:05AM +0100, Andreas Gruenbacher
> > wrote:
> > > 
> > > Al,
> > > 
> > > could you please make sure you are happy with the current version
> > > of the
> > > richacl patch queue for the next merge window?
> > I'm still not happy.
> > 
> > For one I still see no reason to merge this broken ACL model at
> > all.
> > It provides our actualy Linux users no benefit at all, while
> > breaking
> > a lot of assumptions, especially by adding allow and deny ACE at
> > the
> > same sime.
> Could you explain what you mean by "adding allow and deny ACE at the
> same time"?
> 
> > 
> > It also doesn't help with the issue that the main thing it's trying
> > to be compatible with (Windows) actually uses a fundamentally
> > different
> > identifier to apply the ACLs to - as long as you're still limited
> > to users and groups and not guids we'll still have that mapping
> > problem
> > anyway.
> Agreed, but, one step at a time?  My impression is that the Samba
> people
> still consider this a step forward for Linux compatibility.

It is a step forward, but being able to store SIDs in the ACL, would be
a much better one.

Simo.

> --b.
> 
> > 
> > 
> > But besides that fundamental question on the purpose of it I also
> > don't think the code is suitable, more in the individual patches.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" 
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


WARNING: multiple messages have this Message-ID (diff)
From: Simo <simo@samba.org>
To: "J. Bruce Fields" <bfields@fieldses.org>,
	Christoph Hellwig <hch@infradead.org>
Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	linux-api@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-ext4@vger.kernel.org,
	Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4)
Date: Sat, 12 Mar 2016 16:12:27 -0500	[thread overview]
Message-ID: <1457817147.3540.28.camel@samba.org> (raw)
In-Reply-To: <20160311140757.GB13178@fieldses.org>

On Fri, 2016-03-11 at 09:07 -0500, J. Bruce Fields wrote:
> On Fri, Mar 11, 2016 at 06:01:34AM -0800, Christoph Hellwig wrote:
> > 
> > On Mon, Feb 29, 2016 at 09:17:05AM +0100, Andreas Gruenbacher
> > wrote:
> > > 
> > > Al,
> > > 
> > > could you please make sure you are happy with the current version
> > > of the
> > > richacl patch queue for the next merge window?
> > I'm still not happy.
> > 
> > For one I still see no reason to merge this broken ACL model at
> > all.
> > It provides our actualy Linux users no benefit at all, while
> > breaking
> > a lot of assumptions, especially by adding allow and deny ACE at
> > the
> > same sime.
> Could you explain what you mean by "adding allow and deny ACE at the
> same time"?
> 
> > 
> > It also doesn't help with the issue that the main thing it's trying
> > to be compatible with (Windows) actually uses a fundamentally
> > different
> > identifier to apply the ACLs to - as long as you're still limited
> > to users and groups and not guids we'll still have that mapping
> > problem
> > anyway.
> Agreed, but, one step at a time?  My impression is that the Samba
> people
> still consider this a step forward for Linux compatibility.

It is a step forward, but being able to store SIDs in the ACL, would be
a much better one.

Simo.

> --b.
> 
> > 
> > 
> > But besides that fundamental question on the purpose of it I also
> > don't think the code is suitable, more in the individual patches.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" 
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2016-03-12 21:12 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  8:17 [PATCH v18 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2016-02-29  8:17 ` Andreas Gruenbacher
2016-02-29  8:17 ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found] ` <1456733847-17982-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-29  8:17   ` [PATCH v18 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 11/22] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
     [not found]     ` <1456733847-17982-12-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:07       ` Christoph Hellwig
2016-03-11 14:07         ` Christoph Hellwig
2016-03-11 14:07         ` Christoph Hellwig
2016-03-11 16:24         ` Andreas Gruenbacher
2016-03-11 16:24           ` Andreas Gruenbacher
2016-03-15  7:12           ` Christoph Hellwig
2016-03-15  7:12             ` Christoph Hellwig
2016-03-16 22:31             ` Andreas Gruenbacher
2016-03-16 22:31               ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 13/22] vfs: Cache richacl in struct inode Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 19/22] richacl: Add richacl xattr handler Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
     [not found]     ` <1456733847-17982-20-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:17       ` Christoph Hellwig
2016-03-11 14:17         ` Christoph Hellwig
2016-03-11 14:17         ` Christoph Hellwig
     [not found]         ` <20160311141735.GF14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-11 14:19           ` J. Bruce Fields
2016-03-11 14:19             ` J. Bruce Fields
2016-03-11 14:19             ` J. Bruce Fields
2016-03-15  7:10             ` Christoph Hellwig
2016-03-15  7:10               ` Christoph Hellwig
2016-03-15 21:05               ` J. Bruce Fields
2016-03-15 21:05                 ` J. Bruce Fields
     [not found]                 ` <20160315210526.GC3658-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2016-03-21 16:09                   ` Christoph Hellwig
2016-03-21 16:09                     ` Christoph Hellwig
2016-03-21 16:09                     ` Christoph Hellwig
2016-03-11 14:01   ` [PATCH v18 00/22] Richacls (Core and Ext4) Christoph Hellwig
2016-03-11 14:01     ` Christoph Hellwig
2016-03-11 14:01     ` Christoph Hellwig
2016-03-11 14:07     ` J. Bruce Fields
2016-03-11 14:07       ` J. Bruce Fields
     [not found]       ` <20160311140757.GB13178-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2016-03-12 21:12         ` Simo [this message]
2016-03-12 21:12           ` Simo
2016-03-12 21:12           ` Simo
2016-03-15  7:09       ` Christoph Hellwig
2016-03-15  7:09         ` Christoph Hellwig
2016-03-11 16:11     ` Andreas Gruenbacher
2016-03-11 16:11       ` Andreas Gruenbacher
2016-03-11 20:05       ` Steve French
2016-03-11 20:05         ` Steve French
2016-03-11 23:02         ` Jeremy Allison
2016-03-11 23:02           ` Jeremy Allison
2016-03-13 23:02           ` Andreas Gruenbacher
2016-03-13 23:02             ` Andreas Gruenbacher
2016-03-13 23:02             ` Andreas Gruenbacher
     [not found]             ` <CAHc6FU5Bq9afVdNogc9DQYyyXwLfUopXW5ZnSuct3N+NvKW4Rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-14  3:54               ` Jeremy Allison
2016-03-14  3:54                 ` Jeremy Allison
2016-03-14  3:54                 ` Jeremy Allison
2016-03-15  7:14         ` Christoph Hellwig
2016-03-15  7:14           ` Christoph Hellwig
     [not found]           ` <20160315071439.GE19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-16  3:40             ` Steve French
2016-03-16  3:40               ` Steve French
2016-03-16  3:40               ` Steve French
2016-03-15  7:11       ` Christoph Hellwig
2016-03-15  7:11         ` Christoph Hellwig
     [not found]         ` <20160315071103.GC19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-15 15:45           ` Jeremy Allison
2016-03-15 15:45             ` Jeremy Allison
2016-03-15 15:45             ` Jeremy Allison
2016-03-15 20:17             ` Volker Lendecke
2016-03-15 20:17               ` Volker Lendecke
2016-03-15 20:17               ` Volker Lendecke
2016-03-16  3:28               ` Steve French
2016-03-16  3:28                 ` Steve French
     [not found]               ` <20160315201700.GA22945-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>
2016-03-21 18:20                 ` Michael Adam
2016-03-21 18:20                   ` Michael Adam
2016-03-21 18:20                   ` Michael Adam
2016-02-29  8:17 ` [PATCH v18 04/22] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 05/22] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 06/22] richacl: In-memory representation and helper functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 07/22] richacl: Permission mapping functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 08/22] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 09/22] richacl: Permission check algorithm Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-03-11 14:09   ` Christoph Hellwig
2016-03-11 14:09     ` Christoph Hellwig
2016-02-29  8:17 ` [PATCH v18 10/22] posix_acl: Unexport acl_by_type and make it static Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-03-11 14:03   ` Christoph Hellwig
2016-03-11 14:03     ` Christoph Hellwig
2016-02-29  8:17 ` [PATCH v18 12/22] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 14/22] richacl: Update the file masks in chmod() Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 15/22] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 16/22] richacl: Create-time inheritance Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 17/22] richacl: Automatic Inheritance Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 18/22] richacl: xattr mapping functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found]   ` <1456733847-17982-19-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:17     ` Christoph Hellwig
2016-03-11 14:17       ` Christoph Hellwig
2016-03-11 14:17       ` Christoph Hellwig
     [not found]       ` <20160311141701.GE14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-11 17:03         ` Andreas Gruenbacher
2016-03-11 17:03           ` Andreas Gruenbacher
2016-03-11 17:03           ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 20/22] vfs: Add richacl permission checking Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 21/22] ext4: Add richacl support Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found]   ` <1456733847-17982-22-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:27     ` Christoph Hellwig
2016-03-11 14:27       ` Christoph Hellwig
2016-03-11 14:27       ` Christoph Hellwig
2016-03-13 23:49       ` Andreas Gruenbacher
2016-03-13 23:49         ` Andreas Gruenbacher
     [not found]       ` <20160311142719.GG14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-13 23:08         ` Andreas Gruenbacher
2016-03-13 23:08           ` Andreas Gruenbacher
2016-03-13 23:08           ` Andreas Gruenbacher
2016-03-15  7:17           ` Christoph Hellwig
2016-03-15  7:17             ` Christoph Hellwig
     [not found]             ` <20160315071707.GF19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-16 22:38               ` Andreas Gruenbacher
2016-03-16 22:38                 ` Andreas Gruenbacher
2016-03-16 22:38                 ` Andreas Gruenbacher
2016-03-14 13:02         ` Andreas Gruenbacher
2016-03-14 13:02           ` Andreas Gruenbacher
2016-03-14 13:02           ` Andreas Gruenbacher
2016-03-15  7:18           ` Christoph Hellwig
2016-03-15  7:18             ` Christoph Hellwig
2016-02-29  8:17 ` [PATCH v18 22/22] ext4: Add richacl feature flag Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457817147.3540.28.camel@samba.org \
    --to=simo-eunubhrolfbytjvyw6ydsg@public.gmane.org \
    --cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
    --cc=agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    --cc=tytso-3s7WtUTddSA@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    --cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.