[PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

[PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

[Juliana Rodrigues]

This patch fixes the following issue while maintains 80 characters per line:

CHECK: spaces preferred around that '|' (ctx:VxV)
+       writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 51db98b..6e1e475 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
-	       &ch->ch_cls_uart->isr_fcr);
+	writeb((UART_FCR_ENABLE_FIFO |
+		UART_FCR_CLEAR_RCVR  |
+		UART_FCR_CLEAR_XMIT),
+		&ch->ch_cls_uart->isr_fcr);
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
-- 
2.7.2

Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

[Julia Lawall]

On Sat, 12 Mar 2016, Juliana Rodrigues wrote:

> This patch fixes the following issue while maintains 80 characters per line:
> 
> CHECK: spaces preferred around that '|' (ctx:VxV)
> +       writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 51db98b..6e1e475 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch)
>  	/* Clear out UART and FIFO */
>  	readb(&ch->ch_cls_uart->txrx);
>  
> -	writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
> -	       &ch->ch_cls_uart->isr_fcr);
> +	writeb((UART_FCR_ENABLE_FIFO |
> +		UART_FCR_CLEAR_RCVR  |
> +		UART_FCR_CLEAR_XMIT),

It doesn't fit on one line any more?  Note that the () around the first 
argument are not necessary either, if that would help to get it to fit 
into one line.

julia

> +		&ch->ch_cls_uart->isr_fcr);
>  	udelay(10);
>  
>  	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
> -- 
> 2.7.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

[Juliana Rodrigues]

Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu:
> 
> On Sat, 12 Mar 2016, Juliana Rodrigues wrote:
> 
> > This patch fixes the following issue while maintains 80 characters
> per line:
> > 
> > CHECK: spaces preferred around that '|' (ctx:VxV)
> > +      
> writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT)
> ,
> > 
> > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> > ---
> >  drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/dgnc/dgnc_cls.c
> b/drivers/staging/dgnc/dgnc_cls.c
> > index 51db98b..6e1e475 100644
> > --- a/drivers/staging/dgnc/dgnc_cls.c
> > +++ b/drivers/staging/dgnc/dgnc_cls.c
> > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t
> *ch)
> >       /* Clear out UART and FIFO */
> >       readb(&ch->ch_cls_uart->txrx);
> >  
> >
> -     writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR
> _XMIT),
> > -            &ch->ch_cls_uart->isr_fcr);
> > +     writeb((UART_FCR_ENABLE_FIFO |
> > +             UART_FCR_CLEAR_RCVR  |
> > +             UART_FCR_CLEAR_XMIT),
> 
> It doesn't fit on one line any more?  Note that the () around the
> first 
> argument are not necessary either, if that would help to get it to
> fit 
> into one line.
> 
> julia
> 
> > +             &ch->ch_cls_uart->isr_fcr);
> >       udelay(10);
> >  
> >       ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY |
> CH_TX_FIFO_LWM);
> > -- 
> > 2.7.2
> > 
> > -- 
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.
> com.
> > To view this discussion on the web visit https://groups.google.com/
> d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
> > For more options, visit https://groups.google.com/d/optout.
> > 

Thanks, Julia. I'll take a look. :)

Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2617 bytes --]



On Sun, 13 Mar 2016, Juliana Rodrigues wrote:

> Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu:
> > 
> > On Sat, 12 Mar 2016, Juliana Rodrigues wrote:
> > 
> > > This patch fixes the following issue while maintains 80 characters
> > per line:
> > > 
> > > CHECK: spaces preferred around that '|' (ctx:VxV)
> > > +      
> > writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT)
> > ,
> > > 
> > > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> > > ---
> > >  drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/dgnc/dgnc_cls.c
> > b/drivers/staging/dgnc/dgnc_cls.c
> > > index 51db98b..6e1e475 100644
> > > --- a/drivers/staging/dgnc/dgnc_cls.c
> > > +++ b/drivers/staging/dgnc/dgnc_cls.c
> > > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t
> > *ch)
> > >       /* Clear out UART and FIFO */
> > >       readb(&ch->ch_cls_uart->txrx);
> > >  
> > >
> > -     writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR
> > _XMIT),
> > > -            &ch->ch_cls_uart->isr_fcr);
> > > +     writeb((UART_FCR_ENABLE_FIFO |
> > > +             UART_FCR_CLEAR_RCVR  |
> > > +             UART_FCR_CLEAR_XMIT),
> > 
> > It doesn't fit on one line any more?  Note that the () around the
> > first 
> > argument are not necessary either, if that would help to get it to
> > fit 
> > into one line.
> > 
> > julia
> > 
> > > +             &ch->ch_cls_uart->isr_fcr);
> > >       udelay(10);
> > >  
> > >       ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY |
> > CH_TX_FIFO_LWM);
> > > -- 
> > > 2.7.2
> > > 
> > > -- 
> > > You received this message because you are subscribed to the Google
> > Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.
> > com.
> > > To view this discussion on the web visit https://groups.google.com/
> > d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
> > > For more options, visit https://groups.google.com/d/optout.
> > > 
> 
> Thanks, Julia. I'll take a look. :)

While you don't want to top post, it would be helpful to respond directly 
under the relevant text, so one doesn't have to hunt for the actual 
message.

Sorry to be so picky, but there are a lot of small details to make the 
precess efficient.

julia