* [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c @ 2016-03-13 1:32 Juliana Rodrigues 2016-03-13 3:40 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Juliana Rodrigues @ 2016-03-13 1:32 UTC (permalink / raw) To: outreachy-kernel This patch fixes the following issue while maintains 80 characters per line: CHECK: spaces preferred around that '|' (ctx:VxV) + writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT), Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> --- drivers/staging/dgnc/dgnc_cls.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 51db98b..6e1e475 100644 --- a/drivers/staging/dgnc/dgnc_cls.c +++ b/drivers/staging/dgnc/dgnc_cls.c @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch) /* Clear out UART and FIFO */ readb(&ch->ch_cls_uart->txrx); - writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT), - &ch->ch_cls_uart->isr_fcr); + writeb((UART_FCR_ENABLE_FIFO | + UART_FCR_CLEAR_RCVR | + UART_FCR_CLEAR_XMIT), + &ch->ch_cls_uart->isr_fcr); udelay(10); ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); -- 2.7.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c 2016-03-13 1:32 [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c Juliana Rodrigues @ 2016-03-13 3:40 ` Julia Lawall 2016-03-13 4:11 ` Juliana Rodrigues 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2016-03-13 3:40 UTC (permalink / raw) To: Juliana Rodrigues; +Cc: outreachy-kernel On Sat, 12 Mar 2016, Juliana Rodrigues wrote: > This patch fixes the following issue while maintains 80 characters per line: > > CHECK: spaces preferred around that '|' (ctx:VxV) > + writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT), > > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> > --- > drivers/staging/dgnc/dgnc_cls.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index 51db98b..6e1e475 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch) > /* Clear out UART and FIFO */ > readb(&ch->ch_cls_uart->txrx); > > - writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT), > - &ch->ch_cls_uart->isr_fcr); > + writeb((UART_FCR_ENABLE_FIFO | > + UART_FCR_CLEAR_RCVR | > + UART_FCR_CLEAR_XMIT), It doesn't fit on one line any more? Note that the () around the first argument are not necessary either, if that would help to get it to fit into one line. julia > + &ch->ch_cls_uart->isr_fcr); > udelay(10); > > ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); > -- > 2.7.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313013258.GA17143%40spock. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c 2016-03-13 3:40 ` [Outreachy kernel] " Julia Lawall @ 2016-03-13 4:11 ` Juliana Rodrigues 2016-03-13 4:13 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Juliana Rodrigues @ 2016-03-13 4:11 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu: > > On Sat, 12 Mar 2016, Juliana Rodrigues wrote: > > > This patch fixes the following issue while maintains 80 characters > per line: > > > > CHECK: spaces preferred around that '|' (ctx:VxV) > > + > writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT) > , > > > > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> > > --- > > drivers/staging/dgnc/dgnc_cls.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/dgnc/dgnc_cls.c > b/drivers/staging/dgnc/dgnc_cls.c > > index 51db98b..6e1e475 100644 > > --- a/drivers/staging/dgnc/dgnc_cls.c > > +++ b/drivers/staging/dgnc/dgnc_cls.c > > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t > *ch) > > /* Clear out UART and FIFO */ > > readb(&ch->ch_cls_uart->txrx); > > > > > - writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR > _XMIT), > > - &ch->ch_cls_uart->isr_fcr); > > + writeb((UART_FCR_ENABLE_FIFO | > > + UART_FCR_CLEAR_RCVR | > > + UART_FCR_CLEAR_XMIT), > > It doesn't fit on one line any more? Note that the () around the > first > argument are not necessary either, if that would help to get it to > fit > into one line. > > julia > > > + &ch->ch_cls_uart->isr_fcr); > > udelay(10); > > > > ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | > CH_TX_FIFO_LWM); > > -- > > 2.7.2 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups. > com. > > To view this discussion on the web visit https://groups.google.com/ > d/msgid/outreachy-kernel/20160313013258.GA17143%40spock. > > For more options, visit https://groups.google.com/d/optout. > > Thanks, Julia. I'll take a look. :) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c 2016-03-13 4:11 ` Juliana Rodrigues @ 2016-03-13 4:13 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2016-03-13 4:13 UTC (permalink / raw) To: Juliana Rodrigues; +Cc: outreachy-kernel [-- Attachment #1: Type: TEXT/PLAIN, Size: 2617 bytes --] On Sun, 13 Mar 2016, Juliana Rodrigues wrote: > Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu: > > > > On Sat, 12 Mar 2016, Juliana Rodrigues wrote: > > > > > This patch fixes the following issue while maintains 80 characters > > per line: > > > > > > CHECK: spaces preferred around that '|' (ctx:VxV) > > > + > > writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT) > > , > > > > > > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com> > > > --- > > > drivers/staging/dgnc/dgnc_cls.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/dgnc/dgnc_cls.c > > b/drivers/staging/dgnc/dgnc_cls.c > > > index 51db98b..6e1e475 100644 > > > --- a/drivers/staging/dgnc/dgnc_cls.c > > > +++ b/drivers/staging/dgnc/dgnc_cls.c > > > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t > > *ch) > > > /* Clear out UART and FIFO */ > > > readb(&ch->ch_cls_uart->txrx); > > > > > > > > - writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR > > _XMIT), > > > - &ch->ch_cls_uart->isr_fcr); > > > + writeb((UART_FCR_ENABLE_FIFO | > > > + UART_FCR_CLEAR_RCVR | > > > + UART_FCR_CLEAR_XMIT), > > > > It doesn't fit on one line any more? Note that the () around the > > first > > argument are not necessary either, if that would help to get it to > > fit > > into one line. > > > > julia > > > > > + &ch->ch_cls_uart->isr_fcr); > > > udelay(10); > > > > > > ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | > > CH_TX_FIFO_LWM); > > > -- > > > 2.7.2 > > > > > > -- > > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups. > > com. > > > To view this discussion on the web visit https://groups.google.com/ > > d/msgid/outreachy-kernel/20160313013258.GA17143%40spock. > > > For more options, visit https://groups.google.com/d/optout. > > > > > Thanks, Julia. I'll take a look. :) While you don't want to top post, it would be helpful to respond directly under the relevant text, so one doesn't have to hunt for the actual message. Sorry to be so picky, but there are a lot of small details to make the precess efficient. julia ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-13 4:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-13 1:32 [PATCH] staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c Juliana Rodrigues 2016-03-13 3:40 ` [Outreachy kernel] " Julia Lawall 2016-03-13 4:11 ` Juliana Rodrigues 2016-03-13 4:13 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.