From: Joe Perches <joe@perches.com>
To: Gustavo Padovan <gustavo@padovan.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, "Rob Clark" <robdclark@gmail.com>,
"Daniel Stone" <daniels@collabora.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Riley Andrews" <riandrews@android.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Arve Hjønnevåg" <arve@android.com>,
"Greg Hackmann" <ghackmann@google.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
akpm@linux-foundation.org,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Thu, 17 Mar 2016 10:41:26 -0700 [thread overview]
Message-ID: <1458236486.9556.11.camel@perches.com> (raw)
In-Reply-To: <1458235817-28375-2-git-send-email-gustavo@padovan.org>
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.
This is only used by gpu/drm.
I think this is a poor name for a generic function
that would be in kernel.h.
Isn't there an include file in linux/drm that's
appropriate for this. Maybe drmP.h
Maybe prefix this function name with drm_ too.
Also, there's this that might conflict:
arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p) ptr_to_compat(p)
arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p) ((unsigned long)(p))
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Gustavo Padovan <gustavo@padovan.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
dri-devel@lists.freedesktop.org,
"Daniel Stone" <daniels@collabora.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Greg Hackmann" <ghackmann@google.com>,
"John Harrison" <John.C.Harrison@Intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
akpm@linux-foundation.org, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@Intel.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Thu, 17 Mar 2016 10:41:26 -0700 [thread overview]
Message-ID: <1458236486.9556.11.camel@perches.com> (raw)
In-Reply-To: <1458235817-28375-2-git-send-email-gustavo@padovan.org>
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.
This is only used by gpu/drm.
I think this is a poor name for a generic function
that would be in kernel.h.
Isn't there an include file in linux/drm that's
appropriate for this. Maybe drmP.h
Maybe prefix this function name with drm_ too.
Also, there's this that might conflict:
arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p) ptr_to_compat(p)
arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p) ((unsigned long)(p))
next prev parent reply other threads:[~2016-03-17 17:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:30 [PATCH v9 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-03-17 17:30 ` Gustavo Padovan
2016-03-17 17:30 ` [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan
2016-03-17 17:41 ` Joe Perches [this message]
2016-03-17 17:41 ` Joe Perches
2016-03-17 18:05 ` Gustavo Padovan
2016-03-17 18:05 ` Gustavo Padovan
2016-03-17 18:43 ` Gustavo Padovan
2016-03-17 18:43 ` Gustavo Padovan
2016-03-17 20:22 ` Joe Perches
2016-03-17 20:22 ` Joe Perches
2016-03-17 20:33 ` Rob Clark
2016-03-17 20:33 ` Rob Clark
2016-03-17 20:40 ` Joe Perches
2016-03-17 20:40 ` Joe Perches
2016-03-17 20:50 ` Rob Clark
2016-03-17 20:50 ` Rob Clark
2016-03-17 21:10 ` Joe Perches
2016-03-17 21:10 ` Joe Perches
2016-03-17 21:19 ` Gustavo Padovan
2016-03-17 21:19 ` Gustavo Padovan
2016-03-17 21:19 ` Gustavo Padovan
2016-03-17 21:25 ` Rob Clark
2016-03-17 21:25 ` Rob Clark
2016-03-17 21:33 ` Joe Perches
2016-03-17 21:33 ` Joe Perches
2016-03-17 22:16 ` Gustavo Padovan
2016-03-17 22:16 ` Gustavo Padovan
2016-03-17 22:16 ` Gustavo Padovan
2016-03-18 8:23 ` Daniel Vetter
2016-03-18 8:23 ` Daniel Vetter
2016-03-17 17:30 ` [PATCH v9 3/3] staging/android: refactor SYNC IOCTLs Gustavo Padovan
2016-03-17 17:30 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458236486.9556.11.camel@perches.com \
--to=joe@perches.com \
--cc=John.C.Harrison@Intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.