All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: devel@driverdev.osuosl.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Joe Perches" <joe@perches.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	akpm@linux-foundation.org,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Thu, 17 Mar 2016 15:43:18 -0300	[thread overview]
Message-ID: <20160317184318.GA2611@joana> (raw)
In-Reply-To: <20160317180523.GA2619@joana>

2016-03-17 Gustavo Padovan <gustavo.padovan@collabora.co.uk>:

> 2016-03-17 Joe Perches <joe@perches.com>:
> 
> > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > This function had copies in 3 different files. Unify them in
> > > kernel.h.
> > 
> > This is only used by gpu/drm.
> > 
> > I think this is a poor name for a generic function
> > that would be in kernel.h.
> > 
> > Isn't there an include file in linux/drm that's
> > appropriate for this.  Maybe drmP.h
> > 
> > Maybe prefix this function name with drm_ too.
> 
> No, the next patch adds a user to drivers/staging (which will be moved
> to drivers/dma-buf) soon. Maybe move to a different header in
> include/linux/? not sure which one.
> 
> > Also, there's this that might conflict:
> > 
> > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ptr_to_compat(p)
> > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ((unsigned long)(p))
> 
> Right, I'll figure out how to replace these two too.

The powerpc to_user_ptr has a different meaning from the one I'm adding
in this patch. I propose we just rename powerpc's to_user_ptr to
__to_user_ptr and leave the rest as is.

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Gustavo Padovan <gustavo@padovan.org>
To: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: "Joe Perches" <joe@perches.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Rob Clark" <robdclark@gmail.com>,
	"Greg Hackmann" <ghackmann@google.com>,
	"John Harrison" <John.C.Harrison@Intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	akpm@linux-foundation.org, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel.vetter@Intel.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Thu, 17 Mar 2016 15:43:18 -0300	[thread overview]
Message-ID: <20160317184318.GA2611@joana> (raw)
In-Reply-To: <20160317180523.GA2619@joana>

2016-03-17 Gustavo Padovan <gustavo.padovan@collabora.co.uk>:

> 2016-03-17 Joe Perches <joe@perches.com>:
> 
> > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > This function had copies in 3 different files. Unify them in
> > > kernel.h.
> > 
> > This is only used by gpu/drm.
> > 
> > I think this is a poor name for a generic function
> > that would be in kernel.h.
> > 
> > Isn't there an include file in linux/drm that's
> > appropriate for this.  Maybe drmP.h
> > 
> > Maybe prefix this function name with drm_ too.
> 
> No, the next patch adds a user to drivers/staging (which will be moved
> to drivers/dma-buf) soon. Maybe move to a different header in
> include/linux/? not sure which one.
> 
> > Also, there's this that might conflict:
> > 
> > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ptr_to_compat(p)
> > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ((unsigned long)(p))
> 
> Right, I'll figure out how to replace these two too.

The powerpc to_user_ptr has a different meaning from the one I'm adding
in this patch. I propose we just rename powerpc's to_user_ptr to
__to_user_ptr and leave the rest as is.

	Gustavo

  reply	other threads:[~2016-03-17 18:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 17:30 [PATCH v9 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-03-17 17:30 ` Gustavo Padovan
2016-03-17 17:30 ` [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan
2016-03-17 17:41   ` Joe Perches
2016-03-17 17:41     ` Joe Perches
2016-03-17 18:05     ` Gustavo Padovan
2016-03-17 18:05       ` Gustavo Padovan
2016-03-17 18:43       ` Gustavo Padovan [this message]
2016-03-17 18:43         ` Gustavo Padovan
2016-03-17 20:22         ` Joe Perches
2016-03-17 20:22           ` Joe Perches
2016-03-17 20:33           ` Rob Clark
2016-03-17 20:33             ` Rob Clark
2016-03-17 20:40             ` Joe Perches
2016-03-17 20:40               ` Joe Perches
2016-03-17 20:50               ` Rob Clark
2016-03-17 20:50                 ` Rob Clark
2016-03-17 21:10                 ` Joe Perches
2016-03-17 21:10                   ` Joe Perches
2016-03-17 21:19                   ` Gustavo Padovan
2016-03-17 21:19                     ` Gustavo Padovan
2016-03-17 21:19                     ` Gustavo Padovan
2016-03-17 21:25                     ` Rob Clark
2016-03-17 21:25                       ` Rob Clark
2016-03-17 21:33                     ` Joe Perches
2016-03-17 21:33                       ` Joe Perches
2016-03-17 22:16                       ` Gustavo Padovan
2016-03-17 22:16                         ` Gustavo Padovan
2016-03-17 22:16                         ` Gustavo Padovan
2016-03-18  8:23                       ` Daniel Vetter
2016-03-18  8:23                         ` Daniel Vetter
2016-03-17 17:30 ` [PATCH v9 3/3] staging/android: refactor SYNC IOCTLs Gustavo Padovan
2016-03-17 17:30   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317184318.GA2611@joana \
    --to=gustavo@padovan.org \
    --cc=John.C.Harrison@Intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.