All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"axboe@fb.com" <axboe@fb.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
Date: Fri, 25 Mar 2016 21:01:15 +0000	[thread overview]
Message-ID: <1458939672.5501.6.camel@intel.com> (raw)
In-Reply-To: <20160325104418.GA10525@infradead.org>

On Fri, 2016-03-25 at 03:44 -0700, Christoph Hellwig wrote:
> On Thu, Mar 24, 2016 at 05:17:29PM -0600, Vishal Verma wrote:
> > 
> > @@ -72,16 +72,7 @@ xfs_zero_extent(
> >  	struct xfs_mount *mp = ip->i_mount;
> >  	xfs_daddr_t	sector = xfs_fsb_to_db(ip, start_fsb);
> >  	sector_t	block = XFS_BB_TO_FSBT(mp, sector);
> > -	ssize_t		size = XFS_FSB_TO_B(mp, count_fsb);
> >  
> > -	if (IS_DAX(VFS_I(ip)))
> > -		return
> > dax_clear_sectors(xfs_find_bdev_for_inode(VFS_I(ip)),
> > -				sector, size);
> > -
> > -	/*
> > -	 * let the block layer decide on the fastest method of
> > -	 * implementing the zeroing.
> > -	 */
> >  	return sb_issue_zeroout(mp->m_super, block, count_fsb,
> > GFP_NOFS);
> While not new: using sb_issue_zeroout in XFS is wrong as it doesn't
> account for the RT device.  We need the xfs_find_bdev_for_inode and
> call blkdev_issue_zeroout directly with the bdev it returned.

Ok, I'll fix and send a v2. Thanks!
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "axboe@fb.com" <axboe@fb.com>, "jack@suse.cz" <jack@suse.cz>,
	"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
Date: Fri, 25 Mar 2016 21:01:15 +0000	[thread overview]
Message-ID: <1458939672.5501.6.camel@intel.com> (raw)
In-Reply-To: <20160325104418.GA10525@infradead.org>

On Fri, 2016-03-25 at 03:44 -0700, Christoph Hellwig wrote:
> On Thu, Mar 24, 2016 at 05:17:29PM -0600, Vishal Verma wrote:
> > 
> > @@ -72,16 +72,7 @@ xfs_zero_extent(
> >  	struct xfs_mount *mp = ip->i_mount;
> >  	xfs_daddr_t	sector = xfs_fsb_to_db(ip, start_fsb);
> >  	sector_t	block = XFS_BB_TO_FSBT(mp, sector);
> > -	ssize_t		size = XFS_FSB_TO_B(mp, count_fsb);
> >  
> > -	if (IS_DAX(VFS_I(ip)))
> > -		return
> > dax_clear_sectors(xfs_find_bdev_for_inode(VFS_I(ip)),
> > -				sector, size);
> > -
> > -	/*
> > -	 * let the block layer decide on the fastest method of
> > -	 * implementing the zeroing.
> > -	 */
> >  	return sb_issue_zeroout(mp->m_super, block, count_fsb,
> > GFP_NOFS);
> While not new: using sb_issue_zeroout in XFS is wrong as it doesn't
> account for the RT device.  We need the xfs_find_bdev_for_inode and
> call blkdev_issue_zeroout directly with the bdev it returned.

Ok, I'll fix and send a v2. Thanks!
> 
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-03-25 21:01 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 23:17 [PATCH 0/5] dax: handling of media errors Vishal Verma
2016-03-24 23:17 ` Vishal Verma
2016-03-24 23:17 ` Vishal Verma
2016-03-24 23:17 ` Vishal Verma
2016-03-24 23:17 ` [PATCH 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17 ` [PATCH 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17 ` [PATCH 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:23   ` Verma, Vishal L
2016-03-24 23:23     ` Verma, Vishal L
2016-03-24 23:23     ` Verma, Vishal L
2016-03-24 23:17 ` [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-25 10:44   ` Christoph Hellwig
2016-03-25 10:44     ` Christoph Hellwig
2016-03-25 21:01     ` Verma, Vishal L [this message]
2016-03-25 21:01       ` Verma, Vishal L
2016-03-25 18:47   ` Dan Williams
2016-03-25 18:47     ` Dan Williams
2016-03-25 18:47     ` Dan Williams
2016-03-25 21:03     ` Verma, Vishal L
2016-03-25 21:03       ` Verma, Vishal L
2016-03-25 21:03       ` Verma, Vishal L
2016-03-25 21:20       ` Dan Williams
2016-03-25 21:20         ` Dan Williams
2016-03-25 21:20         ` Dan Williams
2016-03-28 20:01         ` Verma, Vishal L
2016-03-28 20:01           ` Verma, Vishal L
2016-03-28 20:01           ` Verma, Vishal L
2016-03-28 23:34           ` Dan Williams
2016-03-28 23:34             ` Dan Williams
2016-03-28 23:34             ` Dan Williams
2016-03-28 23:34             ` Dan Williams
2016-03-29 18:57             ` Verma, Vishal L
2016-03-29 18:57               ` Verma, Vishal L
2016-03-29 18:57               ` Verma, Vishal L
2016-03-29 18:57               ` Verma, Vishal L
2016-03-29 19:37               ` Dan Williams
2016-03-29 19:37                 ` Dan Williams
2016-03-29 19:37                 ` Dan Williams
2016-03-29 19:37                 ` Dan Williams
2016-03-30  7:49               ` Jan Kara
2016-03-30  7:49                 ` Jan Kara
2016-03-30  7:49                 ` Jan Kara
2016-03-30  7:49                 ` Jan Kara
2016-03-30  7:49                 ` Jan Kara
2016-04-01 19:17                 ` Verma, Vishal L
2016-04-01 19:17                   ` Verma, Vishal L
2016-04-01 19:17                   ` Verma, Vishal L
2016-04-04 12:09                   ` Jan Kara
2016-04-04 12:09                     ` Jan Kara
2016-04-04 12:09                     ` Jan Kara
2016-04-04 12:09                     ` Jan Kara
2016-04-04 12:09                     ` Jan Kara
2016-03-24 23:17 ` [PATCH 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-24 23:17   ` Vishal Verma
2016-03-25 10:45   ` Christoph Hellwig
2016-03-25 10:45     ` Christoph Hellwig
2016-03-25 10:45     ` Christoph Hellwig
2016-03-25 20:59     ` Verma, Vishal L
2016-03-25 20:59       ` Verma, Vishal L
2016-03-25 21:42       ` Dan Williams
2016-03-25 21:42         ` Dan Williams
2016-03-25 22:36         ` Verma, Vishal L
2016-03-25 22:36           ` Verma, Vishal L
2016-03-25 22:36           ` Verma, Vishal L
2016-03-26 16:53         ` hch
2016-03-26 16:53           ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458939672.5501.6.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.