From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras via Linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Paul Mackerras <paulus@samba.org>,
Michael Neuling <mikey@neuling.org>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: powerpc: Clear user CPU feature bits if TM is disabled at runtime
Date: Tue, 05 Apr 2016 19:56:23 +1000 [thread overview]
Message-ID: <1459850183.20087.67.camel@kernel.crashing.org> (raw)
In-Reply-To: <3qfNxw4KcCz9sD5@ozlabs.org>
On Tue, 2016-04-05 at 19:35 +1000, Michael Ellerman wrote:
> Shouldn't we be clearing the user feature there too?
>
> The ibm_pa_features array and the logic in scan_features() knows to
> flip the
> cpu_user_features bits, it was just never updated to handle
> cpu_user_features2.
>
> So it seems to me that's where the bug is.
I was about to make the same comment but then realized we are trying to
clear *2* bits. And since that logic will also, I think, set the bits
when the corresponding pa-feature is present, it means we will also set
those 2 bits if we put both in the mask...
Not sure that's quite what we want, but then I'm not sure what the 2
bits are about, which is why I postponed commenting :-)
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras via Linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Paul Mackerras <paulus@samba.org>,
Michael Neuling <mikey@neuling.org>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] powerpc: Clear user CPU feature bits if TM is disabled at runtime
Date: Tue, 05 Apr 2016 19:56:23 +1000 [thread overview]
Message-ID: <1459850183.20087.67.camel@kernel.crashing.org> (raw)
In-Reply-To: <3qfNxw4KcCz9sD5@ozlabs.org>
On Tue, 2016-04-05 at 19:35 +1000, Michael Ellerman wrote:
> Shouldn't we be clearing the user feature there too?
>
> The ibm_pa_features array and the logic in scan_features() knows to
> flip the
> cpu_user_features bits, it was just never updated to handle
> cpu_user_features2.
>
> So it seems to me that's where the bug is.
I was about to make the same comment but then realized we are trying to
clear *2* bits. And since that logic will also, I think, set the bits
when the corresponding pa-feature is present, it means we will also set
those 2 bits if we put both in the mask...
Not sure that's quite what we want, but then I'm not sure what the 2
bits are about, which is why I postponed commenting :-)
Cheers,
Ben.
next prev parent reply other threads:[~2016-04-05 9:56 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 6:44 PR KVM and TM issues Anton Blanchard
2016-04-04 7:00 ` Alexey Kardashevskiy
2016-04-04 10:43 ` Anton Blanchard
2016-04-04 10:43 ` [Qemu-devel] " Anton Blanchard
2016-04-04 11:09 ` [PATCH] spapr: Don't set the TM ibm,pa-features bit in PR KVM mode Anton Blanchard
2016-04-04 11:09 ` [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features " Anton Blanchard
2016-04-04 11:13 ` Alexander Graf
2016-04-04 11:13 ` [Qemu-devel] " Alexander Graf
2016-04-30 0:48 ` [PATCH v2] spapr: Don't set the TM ibm,pa-features " Anton Blanchard
2016-04-30 0:48 ` [Qemu-devel] [PATCH v2] spapr: Don't set the TM ibm, pa-features " Anton Blanchard
2016-05-02 9:36 ` haris iqbal
2016-05-27 4:52 ` David Gibson
2016-05-27 4:52 ` [Qemu-devel] " David Gibson
2016-06-07 12:28 ` [PATCH 1/2] Add PowerPC AT_HWCAP2 definitions Anton Blanchard
2016-06-07 12:28 ` [Qemu-devel] " Anton Blanchard
2016-06-07 12:32 ` [PATCH 2/2] spapr: Better handling of ibm,pa-features TM bit Anton Blanchard
2016-06-07 12:32 ` [Qemu-devel] [PATCH 2/2] spapr: Better handling of ibm, pa-features " Anton Blanchard
2016-06-08 2:26 ` [PATCH 2/2] spapr: Better handling of ibm,pa-features " David Gibson
2016-06-08 2:26 ` [Qemu-devel] [PATCH 2/2] spapr: Better handling of ibm, pa-features " David Gibson
2016-07-05 5:19 ` [PATCH 0/3] Rework " Sam Bobroff
2016-07-05 5:19 ` [Qemu-devel] " Sam Bobroff
2016-07-05 5:19 ` [PATCH 1/3] spapr: Disable ibm, pa-features HTM bit Sam Bobroff
2016-07-05 5:19 ` [Qemu-devel] " Sam Bobroff
2016-07-05 5:51 ` David Gibson
2016-07-05 5:51 ` [Qemu-devel] " David Gibson
2016-07-05 5:19 ` [PATCH 2/3] Add KVM_CAP_PPC_HTM to linux/kvm.h Sam Bobroff
2016-07-05 5:19 ` [Qemu-devel] " Sam Bobroff
2016-07-05 6:05 ` David Gibson
2016-07-05 6:05 ` [Qemu-devel] " David Gibson
2016-07-06 4:41 ` Sam Bobroff
2016-07-06 4:41 ` [Qemu-devel] " Sam Bobroff
2016-07-06 5:09 ` David Gibson
2016-07-06 5:09 ` [Qemu-devel] " David Gibson
2016-07-05 5:19 ` [PATCH 3/3] spapr: Set ibm, pa-features HTM from KVM_CAP_PPC_HTM Sam Bobroff
2016-07-05 5:19 ` [Qemu-devel] " Sam Bobroff
2016-07-05 6:52 ` David Gibson
2016-07-05 6:52 ` [Qemu-devel] " David Gibson
2016-07-06 5:35 ` [PATCH v2 0/3] Rework spapr: Better handling of ibm, pa-features TM bit Sam Bobroff
2016-07-06 5:35 ` [Qemu-devel] " Sam Bobroff
2016-07-06 5:35 ` [PATCH v2 1/3] spapr: Disable ibm, pa-features HTM bit Sam Bobroff
2016-07-06 5:35 ` [Qemu-devel] " Sam Bobroff
2016-07-07 4:38 ` David Gibson
2016-07-07 4:38 ` [Qemu-devel] " David Gibson
2016-07-06 5:35 ` [PATCH v2 2/3] Add KVM_CAP_PPC_HTM to linux/kvm.h Sam Bobroff
2016-07-06 5:35 ` [Qemu-devel] " Sam Bobroff
2016-07-07 4:38 ` David Gibson
2016-07-07 4:38 ` [Qemu-devel] " David Gibson
2016-07-06 5:35 ` [PATCH v2 3/3] spapr: Set ibm, pa-features HTM from KVM_CAP_PPC_HTM Sam Bobroff
2016-07-06 5:35 ` [Qemu-devel] " Sam Bobroff
2016-07-07 4:39 ` David Gibson
2016-07-07 4:39 ` [Qemu-devel] " David Gibson
2016-06-08 2:19 ` [PATCH 1/2] Add PowerPC AT_HWCAP2 definitions David Gibson
2016-06-08 2:19 ` [Qemu-devel] " David Gibson
2016-04-05 2:12 ` [PATCH] spapr: Don't set the TM ibm,pa-features bit in PR KVM mode Paul Mackerras
2016-04-05 2:12 ` [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features " Paul Mackerras
2016-04-05 4:09 ` [PATCH] spapr: Don't set the TM ibm,pa-features " David Gibson
2016-04-05 4:09 ` [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features " David Gibson
2016-04-05 7:33 ` [PATCH] spapr: Don't set the TM ibm,pa-features " Alexey Kardashevskiy
2016-04-05 7:33 ` [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features " Alexey Kardashevskiy
2016-04-04 11:11 ` [PATCH] powerpc: Clear user CPU feature bits if TM is disabled at runtime Anton Blanchard
2016-04-04 11:11 ` [Qemu-devel] " Anton Blanchard
2016-04-05 0:52 ` David Gibson
2016-04-05 0:52 ` [Qemu-devel] " David Gibson
2016-04-05 9:35 ` Michael Ellerman
2016-04-05 9:35 ` [Qemu-devel] " Michael Ellerman
2016-04-05 9:56 ` Benjamin Herrenschmidt [this message]
2016-04-05 9:56 ` Benjamin Herrenschmidt
2016-04-05 22:40 ` Michael Ellerman
2016-04-05 22:40 ` [Qemu-devel] " Michael Ellerman
2016-04-15 2:06 ` [PATCH 1/3] powerpc: scan_features() updates incorrect bits Anton Blanchard
2016-04-15 2:06 ` [Qemu-devel] " Anton Blanchard
2016-04-15 14:27 ` [1/3] " Michael Ellerman
2016-04-15 14:27 ` [Qemu-devel] " Michael Ellerman
2016-04-18 4:40 ` Michael Ellerman
2016-04-18 4:40 ` [Qemu-devel] " Michael Ellerman
2016-04-18 4:16 ` Michael Ellerman
2016-04-18 4:16 ` [Qemu-devel] " Michael Ellerman
2016-04-18 10:36 ` [PATCH v2 1/3] powerpc: scan_features() updates incorrect bits for REAL_LE Michael Ellerman
2016-04-18 10:36 ` [Qemu-devel] " Michael Ellerman
2016-04-19 10:09 ` [v2, " Michael Ellerman
2016-04-19 10:09 ` [Qemu-devel] " Michael Ellerman
2016-04-15 2:07 ` [PATCH 2/3] powerpc: Update cpu_user_features2 in scan_features() Anton Blanchard
2016-04-15 2:07 ` [Qemu-devel] " Anton Blanchard
2016-04-19 10:09 ` [2/3] " Michael Ellerman
2016-04-19 10:09 ` [Qemu-devel] " Michael Ellerman
2016-04-15 2:08 ` [PATCH 3/3] powerpc: Update TM user feature bits " Anton Blanchard
2016-04-15 2:08 ` [Qemu-devel] " Anton Blanchard
2016-04-19 10:09 ` [3/3] " Michael Ellerman
2016-04-19 10:09 ` [Qemu-devel] " Michael Ellerman
2016-04-04 11:09 ` PR KVM and TM issues Michael Neuling
2016-04-05 7:29 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459850183.20087.67.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.