From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>
Cc: Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
LKML <linux-kernel@vger.kernel.org>,
"Harvey, Ryan" <Ryan.Harvey@cirrus.com>
Subject: Re: [PATCH] checkpatch: Improve missing break for switch/case tests
Date: Sun, 10 Apr 2016 22:04:10 -0700 [thread overview]
Message-ID: <1460351050.1800.69.camel@perches.com> (raw)
In-Reply-To: <1460341582.1800.66.camel@perches.com>
On Sun, 2016-04-10 at 19:26 -0700, Joe Perches wrote:
> The current switch/case test doesn't handle ... case labels like:
>
> switch (foo) {
> case bar ... baz:
> etc...
> }
>
> Add a specific regex for that form and the default label.
> Use the regex where a case label is tested.
Please ignore, the patch is defective as
it has too many false positives.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>,
"Harvey, Ryan" <Ryan.Harvey@cirrus.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Improve missing break for switch/case tests
Date: Sun, 10 Apr 2016 22:04:10 -0700 [thread overview]
Message-ID: <1460351050.1800.69.camel@perches.com> (raw)
In-Reply-To: <1460341582.1800.66.camel@perches.com>
On Sun, 2016-04-10 at 19:26 -0700, Joe Perches wrote:
> The current switch/case test doesn't handle ... case labels like:
>
> switch (foo) {
> case bar ... baz:
> etc...
> }
>
> Add a specific regex for that form and the default label.
> Use the regex where a case label is tested.
Please ignore, the patch is defective as
it has too many false positives.
next prev parent reply other threads:[~2016-04-11 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 22:23 Checkpatch warnings on switch case fallthru Harvey, Ryan
2016-04-09 9:06 ` Takashi Iwai
2016-04-09 16:07 ` Lars-Peter Clausen
2016-04-09 19:45 ` Joe Perches
2016-04-11 2:26 ` [PATCH] checkpatch: Improve missing break for switch/case tests Joe Perches
2016-04-11 2:26 ` Joe Perches
2016-04-11 5:04 ` Joe Perches [this message]
2016-04-11 5:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460351050.1800.69.camel@perches.com \
--to=joe@perches.com \
--cc=Ryan.Harvey@cirrus.com \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=apw@shadowen.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.