All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Roland Stigge <stigge@antcom.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Alexander Shiyan <shc_work@mail.ru>,
	Kevin Hilman <khilman@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	spear-devel@list.st.com, Ray Jui <rjui@broadcom.com>,
	Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Pau
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 06:59:14 -0400	[thread overview]
Message-ID: <1461581954.24648.16.camel@localhost> (raw)
In-Reply-To: <20160425095715.GA2366@piout.net>

Hi Eric,

On Mon, 2016-04-25 at 11:57 +0200, Alexandre Belloni wrote:
> Hi,
> 
> this requires a commit message.
> 
> Also, you should think about separating those changes in multiple patches
> to ease inclusion in the kernel.
> 
> On 25/04/2016 at 10:47:57 +0100, Eric Engestrom wrote :
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  arch/arm/mach-at91/pm.c                 | 2 +-
> >  arch/arm/mach-bcm/bcm_kona_smc.c        | 2 +-
> >  arch/arm/mach-clps711x/board-autcpu12.c | 2 +-
> >  arch/arm/mach-cns3xxx/core.c            | 2 +-
> >  arch/arm/mach-davinci/da8xx-dt.c        | 2 +-
> >  arch/arm/mach-lpc32xx/phy3250.c         | 2 +-
> >  arch/arm/mach-mxs/mach-mxs.c            | 2 +-
> >  arch/arm/mach-omap2/prm_common.c        | 2 +-
> >  arch/arm/mach-omap2/vc.c                | 2 +-
> >  arch/arm/mach-spear/time.c              | 2 +-
> >  10 files changed, 10 insertions(+), 10 deletions(-)
> > 
...

> > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> > index b2f9e22..1ae7230 100644
> > --- a/arch/arm/mach-lpc32xx/phy3250.c
> > +++ b/arch/arm/mach-lpc32xx/phy3250.c
> > @@ -159,7 +159,7 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
> >  	.dma_filter = pl08x_filter_id,
> >  };
> >  
> > -static const struct of_dev_auxdata const lpc32xx_auxdata_lookup[] __initconst = {
> > +static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
> >  	OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
> >  	OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
> >  	OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),

A patch was already submitted for the LPC32xx:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/493312/

...
> > -- 
> > 2.7.4
> > 
> 
Sylvain

WARNING: multiple messages have this Message-ID (diff)
From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 06:59:14 -0400	[thread overview]
Message-ID: <1461581954.24648.16.camel@localhost> (raw)
In-Reply-To: <20160425095715.GA2366@piout.net>

Hi Eric,

On Mon, 2016-04-25 at 11:57 +0200, Alexandre Belloni wrote:
> Hi,
> 
> this requires a commit message.
> 
> Also, you should think about separating those changes in multiple patches
> to ease inclusion in the kernel.
> 
> On 25/04/2016 at 10:47:57 +0100, Eric Engestrom wrote :
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  arch/arm/mach-at91/pm.c                 | 2 +-
> >  arch/arm/mach-bcm/bcm_kona_smc.c        | 2 +-
> >  arch/arm/mach-clps711x/board-autcpu12.c | 2 +-
> >  arch/arm/mach-cns3xxx/core.c            | 2 +-
> >  arch/arm/mach-davinci/da8xx-dt.c        | 2 +-
> >  arch/arm/mach-lpc32xx/phy3250.c         | 2 +-
> >  arch/arm/mach-mxs/mach-mxs.c            | 2 +-
> >  arch/arm/mach-omap2/prm_common.c        | 2 +-
> >  arch/arm/mach-omap2/vc.c                | 2 +-
> >  arch/arm/mach-spear/time.c              | 2 +-
> >  10 files changed, 10 insertions(+), 10 deletions(-)
> > 
...

> > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> > index b2f9e22..1ae7230 100644
> > --- a/arch/arm/mach-lpc32xx/phy3250.c
> > +++ b/arch/arm/mach-lpc32xx/phy3250.c
> > @@ -159,7 +159,7 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
> >  	.dma_filter = pl08x_filter_id,
> >  };
> >  
> > -static const struct of_dev_auxdata const lpc32xx_auxdata_lookup[] __initconst = {
> > +static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
> >  	OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
> >  	OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
> >  	OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),

A patch was already submitted for the LPC32xx:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/493312/

...
> > -- 
> > 2.7.4
> > 
> 
Sylvain

WARNING: multiple messages have this Message-ID (diff)
From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Roland Stigge <stigge@antcom.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Alexander Shiyan <shc_work@mail.ru>,
	Kevin Hilman <khilman@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	spear-devel@list.st.com, Ray Jui <rjui@broadcom.com>,
	Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Paul Walmsley <paul@pwsan.com>,
	Scott Branden <sbranden@broadcom.com>,
	Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	vz@mleia.com
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 06:59:14 -0400	[thread overview]
Message-ID: <1461581954.24648.16.camel@localhost> (raw)
In-Reply-To: <20160425095715.GA2366@piout.net>

Hi Eric,

On Mon, 2016-04-25 at 11:57 +0200, Alexandre Belloni wrote:
> Hi,
> 
> this requires a commit message.
> 
> Also, you should think about separating those changes in multiple patches
> to ease inclusion in the kernel.
> 
> On 25/04/2016 at 10:47:57 +0100, Eric Engestrom wrote :
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  arch/arm/mach-at91/pm.c                 | 2 +-
> >  arch/arm/mach-bcm/bcm_kona_smc.c        | 2 +-
> >  arch/arm/mach-clps711x/board-autcpu12.c | 2 +-
> >  arch/arm/mach-cns3xxx/core.c            | 2 +-
> >  arch/arm/mach-davinci/da8xx-dt.c        | 2 +-
> >  arch/arm/mach-lpc32xx/phy3250.c         | 2 +-
> >  arch/arm/mach-mxs/mach-mxs.c            | 2 +-
> >  arch/arm/mach-omap2/prm_common.c        | 2 +-
> >  arch/arm/mach-omap2/vc.c                | 2 +-
> >  arch/arm/mach-spear/time.c              | 2 +-
> >  10 files changed, 10 insertions(+), 10 deletions(-)
> > 
...

> > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> > index b2f9e22..1ae7230 100644
> > --- a/arch/arm/mach-lpc32xx/phy3250.c
> > +++ b/arch/arm/mach-lpc32xx/phy3250.c
> > @@ -159,7 +159,7 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
> >  	.dma_filter = pl08x_filter_id,
> >  };
> >  
> > -static const struct of_dev_auxdata const lpc32xx_auxdata_lookup[] __initconst = {
> > +static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
> >  	OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
> >  	OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
> >  	OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),

A patch was already submitted for the LPC32xx:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/493312/

...
> > -- 
> > 2.7.4
> > 
> 
Sylvain

  parent reply	other threads:[~2016-04-25 10:59 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  9:47 [PATCH 1/4] perf tools: remove duplicate const qualifier Eric Engestrom
2016-04-25  9:47 ` [PATCH 2/4] drivers: firmware: psci: " Eric Engestrom
2016-04-25  9:47   ` Eric Engestrom
2016-04-25 10:33   ` Jisheng Zhang
2016-04-25 10:33     ` Jisheng Zhang
2016-04-25  9:47 ` [PATCH 3/4] dmaengine: pxa_dma: " Eric Engestrom
2016-04-25  9:47   ` Eric Engestrom
2016-04-25 19:18   ` Robert Jarzmik
2016-04-25 19:18     ` Robert Jarzmik
2016-04-26 16:30   ` Vinod Koul
2016-04-26 16:30     ` Vinod Koul
2016-04-25  9:47 ` [PATCH 4/4] ARM: " Eric Engestrom
2016-04-25  9:47   ` Eric Engestrom
2016-04-25  9:47   ` Eric Engestrom
2016-04-25  9:52   ` Viresh Kumar
2016-04-25  9:52     ` Viresh Kumar
2016-04-25  9:52     ` Viresh Kumar
2016-04-25  9:57   ` Alexandre Belloni
2016-04-25  9:57     ` Alexandre Belloni
2016-04-25  9:57     ` Alexandre Belloni
2016-04-25 10:39     ` Eric Engestrom
2016-04-25 10:39       ` Eric Engestrom
2016-04-25 10:39       ` Eric Engestrom
2016-04-25 11:38       ` Arnd Bergmann
2016-04-25 11:38         ` Arnd Bergmann
2016-04-25 11:38         ` Arnd Bergmann
2016-04-25 12:58         ` Eric Engestrom
2016-04-25 12:58           ` Eric Engestrom
2016-04-25 12:58           ` Eric Engestrom
2016-04-25 14:12           ` Nicolas Pitre
2016-04-25 14:12             ` Nicolas Pitre
2016-04-25 14:12             ` Nicolas Pitre
2016-04-25 14:37             ` Eric Engestrom
2016-04-25 14:37               ` Eric Engestrom
2016-04-25 14:37               ` Eric Engestrom
2016-04-26 10:12               ` Krzysztof Hałasa
2016-04-26 10:12                 ` Krzysztof Hałasa
2016-04-26 10:12                 ` Krzysztof Hałasa
2016-04-27 20:01               ` Nicolas Pitre
2016-04-27 20:01                 ` Nicolas Pitre
2016-04-27 20:01                 ` Nicolas Pitre
2016-04-25 10:59     ` Sylvain Lemieux [this message]
2016-04-25 10:59       ` Sylvain Lemieux
2016-04-25 10:59       ` Sylvain Lemieux
2016-04-25 21:11 ` [PATCH 1/4] perf tools: " Arnaldo Carvalho de Melo
2016-04-27 15:32 ` [tip:perf/core] perf tools: Remove " tip-bot for Eric Engestrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461581954.24648.16.camel@localhost \
    --to=slemieux.tyco@gmail.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric.engestrom@imgtec.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=khalasa@piap.pl \
    --cc=khilman@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.ferre@atmel.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=nsekhar@ti.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=rjui@broadcom.com \
    --cc=rnayak@ti.com \
    --cc=shc_work@mail.ru \
    --cc=spear-devel@list.st.com \
    --cc=stigge@antcom.de \
    --cc=tony@atomide.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.