From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Lee Jones <lee.jones@linaro.org>,
Roland Stigge <stigge@antcom.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Alexander Shiyan <shc_work@mail.ru>,
Kevin Hilman <khilman@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
spear-devel@list.st.com, Ray Jui <rjui@broadcom.com>,
Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Gregory Fong <gregory.0xf0@gmail.com>,
linux-omap@vger.kernel.org, Paul
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 15:37:31 +0100 [thread overview]
Message-ID: <20160425143731.GR32731@imgtec.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1604250953200.5091@knanqh.ubzr>
On Mon, Apr 25, 2016 at 10:12:16AM -0400, Nicolas Pitre wrote:
> Beware.
>
> I added many of those exactly because gcc did not ignore them when
> compiling with LTO where the lack of a const qualifier to qualify the
> actual array content, and not only the reference to that content,
> generated build errors due to section mismatches from the __initconst
> annotation.
I believe the first `const` does that, without the need for a second.
> So this is a NAK from me unless you may confirm that LTO builds are
> unaffected by your changes.
I can't confirm it (haven't tried), and don't care enough to do it :]
I guess I'm just dropping the patch then. Like I said, it can't hurt to
leave them in.
Cheers,
Eric
WARNING: multiple messages have this Message-ID (diff)
From: eric.engestrom@imgtec.com (Eric Engestrom)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 15:37:31 +0100 [thread overview]
Message-ID: <20160425143731.GR32731@imgtec.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1604250953200.5091@knanqh.ubzr>
On Mon, Apr 25, 2016 at 10:12:16AM -0400, Nicolas Pitre wrote:
> Beware.
>
> I added many of those exactly because gcc did not ignore them when
> compiling with LTO where the lack of a const qualifier to qualify the
> actual array content, and not only the reference to that content,
> generated build errors due to section mismatches from the __initconst
> annotation.
I believe the first `const` does that, without the need for a second.
> So this is a NAK from me unless you may confirm that LTO builds are
> unaffected by your changes.
I can't confirm it (haven't tried), and don't care enough to do it :]
I guess I'm just dropping the patch then. Like I said, it can't hurt to
leave them in.
Cheers,
Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
<linux-arm-kernel@lists.infradead.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Lee Jones <lee.jones@linaro.org>,
Roland Stigge <stigge@antcom.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Alexander Shiyan <shc_work@mail.ru>,
Kevin Hilman <khilman@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
<bcm-kernel-feedback-list@broadcom.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<spear-devel@list.st.com>, Ray Jui <rjui@broadcom.com>,
Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Gregory Fong <gregory.0xf0@gmail.com>,
<linux-omap@vger.kernel.org>, Paul Walmsley <paul@pwsan.com>,
Scott Branden <sbranden@broadcom.com>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
<linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 15:37:31 +0100 [thread overview]
Message-ID: <20160425143731.GR32731@imgtec.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1604250953200.5091@knanqh.ubzr>
On Mon, Apr 25, 2016 at 10:12:16AM -0400, Nicolas Pitre wrote:
> Beware.
>
> I added many of those exactly because gcc did not ignore them when
> compiling with LTO where the lack of a const qualifier to qualify the
> actual array content, and not only the reference to that content,
> generated build errors due to section mismatches from the __initconst
> annotation.
I believe the first `const` does that, without the need for a second.
> So this is a NAK from me unless you may confirm that LTO builds are
> unaffected by your changes.
I can't confirm it (haven't tried), and don't care enough to do it :]
I guess I'm just dropping the patch then. Like I said, it can't hurt to
leave them in.
Cheers,
Eric
next prev parent reply other threads:[~2016-04-25 14:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 9:47 [PATCH 1/4] perf tools: remove duplicate const qualifier Eric Engestrom
2016-04-25 9:47 ` [PATCH 2/4] drivers: firmware: psci: " Eric Engestrom
2016-04-25 9:47 ` Eric Engestrom
2016-04-25 10:33 ` Jisheng Zhang
2016-04-25 10:33 ` Jisheng Zhang
2016-04-25 9:47 ` [PATCH 3/4] dmaengine: pxa_dma: " Eric Engestrom
2016-04-25 9:47 ` Eric Engestrom
2016-04-25 19:18 ` Robert Jarzmik
2016-04-25 19:18 ` Robert Jarzmik
2016-04-26 16:30 ` Vinod Koul
2016-04-26 16:30 ` Vinod Koul
2016-04-25 9:47 ` [PATCH 4/4] ARM: " Eric Engestrom
2016-04-25 9:47 ` Eric Engestrom
2016-04-25 9:47 ` Eric Engestrom
2016-04-25 9:52 ` Viresh Kumar
2016-04-25 9:52 ` Viresh Kumar
2016-04-25 9:52 ` Viresh Kumar
2016-04-25 9:57 ` Alexandre Belloni
2016-04-25 9:57 ` Alexandre Belloni
2016-04-25 9:57 ` Alexandre Belloni
2016-04-25 10:39 ` Eric Engestrom
2016-04-25 10:39 ` Eric Engestrom
2016-04-25 10:39 ` Eric Engestrom
2016-04-25 11:38 ` Arnd Bergmann
2016-04-25 11:38 ` Arnd Bergmann
2016-04-25 11:38 ` Arnd Bergmann
2016-04-25 12:58 ` Eric Engestrom
2016-04-25 12:58 ` Eric Engestrom
2016-04-25 12:58 ` Eric Engestrom
2016-04-25 14:12 ` Nicolas Pitre
2016-04-25 14:12 ` Nicolas Pitre
2016-04-25 14:12 ` Nicolas Pitre
2016-04-25 14:37 ` Eric Engestrom [this message]
2016-04-25 14:37 ` Eric Engestrom
2016-04-25 14:37 ` Eric Engestrom
2016-04-26 10:12 ` Krzysztof Hałasa
2016-04-26 10:12 ` Krzysztof Hałasa
2016-04-26 10:12 ` Krzysztof Hałasa
2016-04-27 20:01 ` Nicolas Pitre
2016-04-27 20:01 ` Nicolas Pitre
2016-04-27 20:01 ` Nicolas Pitre
2016-04-25 10:59 ` Sylvain Lemieux
2016-04-25 10:59 ` Sylvain Lemieux
2016-04-25 10:59 ` Sylvain Lemieux
2016-04-25 21:11 ` [PATCH 1/4] perf tools: " Arnaldo Carvalho de Melo
2016-04-27 15:32 ` [tip:perf/core] perf tools: Remove " tip-bot for Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425143731.GR32731@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=khalasa@piap.pl \
--cc=khilman@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.ferre@atmel.com \
--cc=nicolas.pitre@linaro.org \
--cc=nsekhar@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=rjui@broadcom.com \
--cc=rnayak@ti.com \
--cc=shc_work@mail.ru \
--cc=spear-devel@list.st.com \
--cc=stigge@antcom.de \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.