[PATCH] cookerdata: Fix log messages and ensure we exit

[PATCH] cookerdata: Fix log messages and ensure we exit

[Richard Purdie]

The string formatting wasn't correct and we should exit if we hit
errors here similar to the other exception handlers.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
index 50259a9..fba95af 100644
--- a/lib/bb/cookerdata.py
+++ b/lib/bb/cookerdata.py
@@ -192,7 +192,8 @@ def catch_parse_error(func):
                 fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
                 if not fn.startswith(bbdir):
                     break
-            parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb))
+            parselog.critical("Unable to parse %s" % fn, exc_info=(exc_class, exc, tb))
+            sys.exit(1)
         except bb.parse.ParseError as exc:
             parselog.critical(str(exc))
             sys.exit(1)

Re: [PATCH] cookerdata: Fix log messages and ensure we exit

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On Thu, May 12, 2016 at 2:56 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> The string formatting wasn't correct and we should exit if we hit
> errors here similar to the other exception handlers.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> index 50259a9..fba95af 100644
> --- a/lib/bb/cookerdata.py
> +++ b/lib/bb/cookerdata.py
> @@ -192,7 +192,8 @@ def catch_parse_error(func):
>                  fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
>                  if not fn.startswith(bbdir):
>                      break
> -            parselog.critical("Unable to parse %s", fn,
> exc_info=(exc_class, exc, tb))
> +            parselog.critical("Unable to parse %s" % fn,
> exc_info=(exc_class, exc, tb))
> +            sys.exit(1)
>

The python logging module supports passing the % format values as
arguments, you don't have to format the string at call time. What was the
error here?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1825 bytes --]

Re: [PATCH] cookerdata: Fix log messages and ensure we exit

[Richard Purdie]

On Thu, 2016-05-12 at 07:55 -0700, Christopher Larson wrote:
> 
> On Thu, May 12, 2016 at 2:56 AM, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > The string formatting wasn't correct and we should exit if we hit
> > errors here similar to the other exception handlers.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> > index 50259a9..fba95af 100644
> > --- a/lib/bb/cookerdata.py
> > +++ b/lib/bb/cookerdata.py
> > @@ -192,7 +192,8 @@ def catch_parse_error(func):
> >                  fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
> >                  if not fn.startswith(bbdir):
> >                      break
> > -            parselog.critical("Unable to parse %s", fn,
> > exc_info=(exc_class, exc, tb))
> > +            parselog.critical("Unable to parse %s" % fn,
> > exc_info=(exc_class, exc, tb))
> > +            sys.exit(1)
> > 
> The python logging module supports passing the % format values as
> arguments, you don't have to format the string at call time. What was
> the error here?

I had a whole load of debug here and distilled it down to this as it
looked inconsistent with the rest of our code. Its possible the real
problem was with exc_info as mentioned in another patch...

Cheers,

Richard