All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
Date: Fri, 13 May 2016 19:09:47 +0300	[thread overview]
Message-ID: <1463155787.17131.351.camel@linux.intel.com> (raw)
In-Reply-To: <20160513144927.GZ23234@mail.corp.redhat.com>

On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote:
> On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > 
> > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote:
> > > 
> > > There is no reasons to filter out keyboard and consumer control
> > > collections
> > > in hid-multitouch.
> > > With the previous hid-input fix, there is now a full support of
> > > the
> > > Type
> > > Cover and we can remove all specific bits from hid-core and hid-
> > > microsoft.
> > > 
> > > hid-multitouch will automatically set HID_QUIRK_NO_INIT_REPORTS so
> > > we
> > > can
> > > also remove it from the list of ushbid quirks.
> > > 
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > ---
> > > 
> > > Andy, would you mind checking if this series is sufficient to
> > > enable
> > > the
> > > TypeCover of the Surface Book?
> > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Noticed little difference that there is no event for the device
> > anymore,
> > just /dev/usb/hiddev0. Would it work properly under X?
> Not sure what you mean.
> I get 3 input nodes:
> Microsoft Surface Type Cover Keyboard
> Microsoft Surface Type Cover Consumer Control
> Microsoft Surface Type Cover Touchpad
> 
> Each on this input device is properly assigned an event node and X
> works
> with them.
> 
> If there is no /dev/input/eventX created for your cover, then this is
> not normal and needs to be investigated.

There is no /dev/input/eventX for the touchpad. 
It prints that input device is under /usb.../input8, but the actual node
I got events from is /dev/usb/hiddev0.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2016-05-13 16:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 14:12 [PATCH 1/2] HID: input: rework HID_QUIRK_MULTI_INPUT Benjamin Tissoires
2016-05-12 14:12 ` [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Benjamin Tissoires
2016-05-13 14:30   ` Andy Shevchenko
2016-05-13 14:30     ` Andy Shevchenko
2016-05-13 14:49     ` Benjamin Tissoires
2016-05-13 16:09       ` Andy Shevchenko [this message]
2016-05-13 16:21         ` Benjamin Tissoires
2016-05-13 16:21           ` Benjamin Tissoires
2016-05-13 16:28         ` Andy Shevchenko
2016-05-13 16:28           ` Andy Shevchenko
2016-05-20  7:58           ` Benjamin Tissoires
2016-05-31 16:07             ` Benjamin Tissoires
2016-05-31 16:07               ` Benjamin Tissoires
2016-05-31 17:56               ` Andy Shevchenko
2016-05-31 17:56                 ` Andy Shevchenko
2016-06-02 14:11                 ` Benjamin Tissoires
2016-06-02 14:40                   ` Andy Shevchenko
2016-06-02 14:40                     ` Andy Shevchenko
2016-06-03  9:38                     ` Benjamin Tissoires
2016-06-03  9:38                       ` Benjamin Tissoires
2016-06-03 11:59                       ` Andy Shevchenko
2016-06-03 12:23                         ` Benjamin Tissoires
2016-06-03 12:23                           ` Benjamin Tissoires
2016-06-03 13:00                           ` Andy Shevchenko
2016-06-03 13:00                             ` Andy Shevchenko
2016-06-03 13:32                             ` Benjamin Tissoires
2016-06-13 12:32                               ` Andy Shevchenko
2016-06-15 14:28                                 ` Benjamin Tissoires
2016-06-23  7:24                                   ` Andy Shevchenko
2016-06-23  7:24                                     ` Andy Shevchenko
2016-05-17 17:47   ` Bastien Nocera
2016-06-23  1:12   ` Stephen J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463155787.17131.351.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.