All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
Date: Fri, 03 Jun 2016 16:00:44 +0300	[thread overview]
Message-ID: <1464958844.1767.50.camel@linux.intel.com> (raw)
In-Reply-To: <20160603122305.GH6063@mail.corp.redhat.com>

On Fri, 2016-06-03 at 14:23 +0200, Benjamin Tissoires wrote:

> On Jun 03 2016 or thereabouts, Andy Shevchenko wrote:
> > On Fri, 2016-06-03 at 11:38 +0200, Benjamin Tissoires wrote:
> > > On Jun 02 2016 or thereabouts, Andy Shevchenko wrote:
> > > > On Thu, 2016-06-02 at 16:11 +0200, Benjamin Tissoires wrote:


> > > > I take linux-next + your two patches from this thread (+ some
> > > > unrelated
> > > > to HID patches).
> > > 
> > > OK. I think I know what happened:
> > > - Microsoft forgot to put the Win 8 certification blob in this
> > >   particular device (of course, because Microsoft)
> > > - we do not detect it as a Win 8 certified and do not set the
> > >   HID_QUIRK_NO_INIT_REPORTS flag
> > > - your dmesg should show some error on plug, and then hid can't
> > > set
> > > the
> > >   input mode
> > > - I can't add a "if win 8 then show the mouse collection" because
> > > your
> > >   device doesn't report itself as win 8 :)
> > > 
> > > Anyway, could you try applying this small diff after my 2 patches
> > > and
> > > report if you now have a working touchpad?:
> > 
> > Nope. There is still no /dev/input/eventX associated with touchpad.
> 
> Weird. On my system, if I replay your logs, I see 4 new nodes:
> /dev/input/event21:	Microsoft Surface Keyboard Keyboard
> /dev/input/event22:	Microsoft Surface Keyboard Consumer Control
> /dev/input/event23:	Microsoft Surface Keyboard Touchpad
> /dev/input/event24:	Microsoft Surface Keyboard Keyboard

I had a line in dmesg that input8 is allocated to Touchpad, but no
eventX (0..6 IIRC) from /dev/input reflects Touchpad events. I can get
them only via /dev/usb/hiddev0.

> 
> Can you attach the dmesg when plugging in the type cover?
> 

I will do later, but there is no such thing 'plugging in'. It's a part
of the notebook, so, I can do detach-attach cycle, though it shouldn't
matter, it should work immediately after boot I suppose.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
Date: Fri, 03 Jun 2016 16:00:44 +0300	[thread overview]
Message-ID: <1464958844.1767.50.camel@linux.intel.com> (raw)
In-Reply-To: <20160603122305.GH6063@mail.corp.redhat.com>

On Fri, 2016-06-03 at 14:23 +0200, Benjamin Tissoires wrote:

> On Jun 03 2016 or thereabouts, Andy Shevchenko wrote:
> > On Fri, 2016-06-03 at 11:38 +0200, Benjamin Tissoires wrote:
> > > On Jun 02 2016 or thereabouts, Andy Shevchenko wrote:
> > > > On Thu, 2016-06-02 at 16:11 +0200, Benjamin Tissoires wrote:


> > > > I take linux-next + your two patches from this thread (+ some
> > > > unrelated
> > > > to HID patches).
> > > 
> > > OK. I think I know what happened:
> > > - Microsoft forgot to put the Win 8 certification blob in this
> > >   particular device (of course, because Microsoft)
> > > - we do not detect it as a Win 8 certified and do not set the
> > >   HID_QUIRK_NO_INIT_REPORTS flag
> > > - your dmesg should show some error on plug, and then hid can't
> > > set
> > > the
> > >   input mode
> > > - I can't add a "if win 8 then show the mouse collection" because
> > > your
> > >   device doesn't report itself as win 8 :)
> > > 
> > > Anyway, could you try applying this small diff after my 2 patches
> > > and
> > > report if you now have a working touchpad?:
> > 
> > Nope. There is still no /dev/input/eventX associated with touchpad.
> 
> Weird. On my system, if I replay your logs, I see 4 new nodes:
> /dev/input/event21:	Microsoft Surface Keyboard Keyboard
> /dev/input/event22:	Microsoft Surface Keyboard Consumer Control
> /dev/input/event23:	Microsoft Surface Keyboard Touchpad
> /dev/input/event24:	Microsoft Surface Keyboard Keyboard

I had a line in dmesg that input8 is allocated to Touchpad, but no
eventX (0..6 IIRC) from /dev/input reflects Touchpad events. I can get
them only via /dev/usb/hiddev0.

> 
> Can you attach the dmesg when plugging in the type cover?
> 

I will do later, but there is no such thing 'plugging in'. It's a part
of the notebook, so, I can do detach-attach cycle, though it shouldn't
matter, it should work immediately after boot I suppose.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2016-06-03 12:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 14:12 [PATCH 1/2] HID: input: rework HID_QUIRK_MULTI_INPUT Benjamin Tissoires
2016-05-12 14:12 ` [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Benjamin Tissoires
2016-05-13 14:30   ` Andy Shevchenko
2016-05-13 14:30     ` Andy Shevchenko
2016-05-13 14:49     ` Benjamin Tissoires
2016-05-13 16:09       ` Andy Shevchenko
2016-05-13 16:21         ` Benjamin Tissoires
2016-05-13 16:21           ` Benjamin Tissoires
2016-05-13 16:28         ` Andy Shevchenko
2016-05-13 16:28           ` Andy Shevchenko
2016-05-20  7:58           ` Benjamin Tissoires
2016-05-31 16:07             ` Benjamin Tissoires
2016-05-31 16:07               ` Benjamin Tissoires
2016-05-31 17:56               ` Andy Shevchenko
2016-05-31 17:56                 ` Andy Shevchenko
2016-06-02 14:11                 ` Benjamin Tissoires
2016-06-02 14:40                   ` Andy Shevchenko
2016-06-02 14:40                     ` Andy Shevchenko
2016-06-03  9:38                     ` Benjamin Tissoires
2016-06-03  9:38                       ` Benjamin Tissoires
2016-06-03 11:59                       ` Andy Shevchenko
2016-06-03 12:23                         ` Benjamin Tissoires
2016-06-03 12:23                           ` Benjamin Tissoires
2016-06-03 13:00                           ` Andy Shevchenko [this message]
2016-06-03 13:00                             ` Andy Shevchenko
2016-06-03 13:32                             ` Benjamin Tissoires
2016-06-13 12:32                               ` Andy Shevchenko
2016-06-15 14:28                                 ` Benjamin Tissoires
2016-06-23  7:24                                   ` Andy Shevchenko
2016-06-23  7:24                                     ` Andy Shevchenko
2016-05-17 17:47   ` Bastien Nocera
2016-06-23  1:12   ` Stephen J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464958844.1767.50.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.