All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: open list <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:VIRTIO GPU DRIVER"
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support
Date: Mon, 30 May 2016 14:06:50 +0200	[thread overview]
Message-ID: <1464610010.5179.34.camel@redhat.com> (raw)
In-Reply-To: <20160530084233.GA27098@phenom.ffwll.local>

  Hi,

> > But I'll take you up on the implied offer to help out and test ;-)
> 
> git://people.freedesktop.org/~danvet/drm stuff

Tried that branch.

> Would be really awesome if you could test this on virtio. Note that the
> new nonblocking helpers require that your atomic backend gets the drm
> event handling right. So if there's a bug in that logic then you'll see
> lots of dmesg noise about waits timing out (after 10s of waiting). From a
> quick inspection it should work though.

No timeouts.  Yay!

But it seems crtcs can be (temporarely) disabled now, so we might have
to pick up the crtc from old_state in virtio_gpu_plane_atomic_update to
figure which virtual output needs to be turned off.  Ran into this last
week already.  Happened with multihead setups only, but the same patch
fixes this one too ;)

https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html

cheers,
  Gerd

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:VIRTIO GPU DRIVER" 
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support
Date: Mon, 30 May 2016 14:06:50 +0200	[thread overview]
Message-ID: <1464610010.5179.34.camel@redhat.com> (raw)
In-Reply-To: <20160530084233.GA27098@phenom.ffwll.local>

  Hi,

> > But I'll take you up on the implied offer to help out and test ;-)
> 
> git://people.freedesktop.org/~danvet/drm stuff

Tried that branch.

> Would be really awesome if you could test this on virtio. Note that the
> new nonblocking helpers require that your atomic backend gets the drm
> event handling right. So if there's a bug in that logic then you'll see
> lots of dmesg noise about waits timing out (after 10s of waiting). From a
> quick inspection it should work though.

No timeouts.  Yay!

But it seems crtcs can be (temporarely) disabled now, so we might have
to pick up the crtc from old_state in virtio_gpu_plane_atomic_update to
figure which virtual output needs to be turned off.  Ran into this last
week already.  Happened with multihead setups only, but the same patch
fixes this one too ;)

https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html

cheers,
  Gerd

  reply	other threads:[~2016-05-30 12:06 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 11:58 [PATCH v3 0/7] virtio-gpu: bugfixes, virgl/3d rendering support Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 1/7] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_locked Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 2/7] virtio-gpu: add & use virtio_gpu_queue_fenced_ctrl_buffer Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 3/7] virtio-gpu: wait for cursor updates finish Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 4/7] virtio-gpu: add 3d/virgl support Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 5/7] virtio-gpu: add basic prime support Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 6/7] virtio-gpu: mark as a render gpu Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann
2015-10-02 11:58   ` Gerd Hoffmann
2016-05-25 16:37   ` Daniel Vetter
2016-05-25 16:37   ` Daniel Vetter
2016-05-25 16:37     ` Daniel Vetter
2016-05-27  7:46     ` Gerd Hoffmann
2016-05-27  7:46     ` Gerd Hoffmann
2016-05-27  7:50       ` Daniel Vetter
2016-05-27  7:50         ` Daniel Vetter
2016-05-30  8:42         ` Daniel Vetter
2016-05-30 12:06           ` Gerd Hoffmann [this message]
2016-05-30 12:06             ` Gerd Hoffmann
2016-05-30 14:43             ` Daniel Vetter
2016-05-31  6:18               ` Gerd Hoffmann
2016-05-31  6:18               ` Gerd Hoffmann
2016-05-31  6:18                 ` Gerd Hoffmann
2016-05-31  6:37                 ` Daniel Vetter
2016-05-31  6:37                 ` Daniel Vetter
2016-05-31  7:34                   ` Gerd Hoffmann
2016-05-31  7:34                     ` Gerd Hoffmann
2016-05-31  7:39                     ` Daniel Vetter
2016-05-31  7:39                       ` Daniel Vetter
2016-05-31  7:39                     ` Daniel Vetter
2016-05-31  7:34                   ` Gerd Hoffmann
2016-05-30 14:43             ` Daniel Vetter
2016-05-30  8:42         ` Daniel Vetter
2016-05-27  7:50       ` Daniel Vetter
2015-10-02 11:58 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464610010.5179.34.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.