From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: open list <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support
Date: Tue, 31 May 2016 09:34:45 +0200 [thread overview]
Message-ID: <1464680085.5978.40.camel@redhat.com> (raw)
In-Reply-To: <CAKMK7uFkB9SX8pNdANSK87M7wr1WzPYkP2t2CHoJZeeM62eCpA@mail.gmail.com>
Hi,
> > Right now the virtual outputs are linked to drm_crtc. To apply any
> > changes I need to lookup the crtc to figure which virtual output should
> > be updated.
> > So, setting active_only should make sure I have a valid crtc pointer on
> > plane updates, right? It probably also skips the disable + enable crtc
> > steps on commit? What happens when outputs are disabled?
> Nah, I just misunderstood your patch. If it's all about finding the
> corresponding crtc, then you're all good.
Yes, it's all about finding the crtc.
> I thought there was some
> other reason (like the virtual hw getting upset about certain things).
virtio wouldn't be upset.
It's a pointless exercise though to first disable the output, just to
re-enable it the next moment with the new page-flipped framebuffer. So
I guess I should look at the active_only thing nevertheless.
> btw can you pls drop an ack or r-b
> onto my virtio conversion? I already added your tested-by.
Grr, mail is not in my dri-devel folder. Guess that is the <censored>
"avoid-duplicates" mailman option at work.
Feel free to just add the r-b too. Or I'll send it for the next version
of the series.
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support
Date: Tue, 31 May 2016 09:34:45 +0200 [thread overview]
Message-ID: <1464680085.5978.40.camel@redhat.com> (raw)
In-Reply-To: <CAKMK7uFkB9SX8pNdANSK87M7wr1WzPYkP2t2CHoJZeeM62eCpA@mail.gmail.com>
Hi,
> > Right now the virtual outputs are linked to drm_crtc. To apply any
> > changes I need to lookup the crtc to figure which virtual output should
> > be updated.
> > So, setting active_only should make sure I have a valid crtc pointer on
> > plane updates, right? It probably also skips the disable + enable crtc
> > steps on commit? What happens when outputs are disabled?
> Nah, I just misunderstood your patch. If it's all about finding the
> corresponding crtc, then you're all good.
Yes, it's all about finding the crtc.
> I thought there was some
> other reason (like the virtual hw getting upset about certain things).
virtio wouldn't be upset.
It's a pointless exercise though to first disable the output, just to
re-enable it the next moment with the new page-flipped framebuffer. So
I guess I should look at the active_only thing nevertheless.
> btw can you pls drop an ack or r-b
> onto my virtio conversion? I already added your tested-by.
Grr, mail is not in my dri-devel folder. Guess that is the <censored>
"avoid-duplicates" mailman option at work.
Feel free to just add the r-b too. Or I'll send it for the next version
of the series.
cheers,
Gerd
next prev parent reply other threads:[~2016-05-31 7:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 11:58 [PATCH v3 0/7] virtio-gpu: bugfixes, virgl/3d rendering support Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 1/7] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_locked Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 2/7] virtio-gpu: add & use virtio_gpu_queue_fenced_ctrl_buffer Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 3/7] virtio-gpu: wait for cursor updates finish Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 4/7] virtio-gpu: add 3d/virgl support Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 5/7] virtio-gpu: add basic prime support Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 6/7] virtio-gpu: mark as a render gpu Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2015-10-02 11:58 ` Gerd Hoffmann
2016-05-25 16:37 ` Daniel Vetter
2016-05-25 16:37 ` Daniel Vetter
2016-05-27 7:46 ` Gerd Hoffmann
2016-05-27 7:50 ` Daniel Vetter
2016-05-27 7:50 ` Daniel Vetter
2016-05-27 7:50 ` Daniel Vetter
2016-05-30 8:42 ` Daniel Vetter
2016-05-30 8:42 ` Daniel Vetter
2016-05-30 12:06 ` Gerd Hoffmann
2016-05-30 12:06 ` Gerd Hoffmann
2016-05-30 14:43 ` Daniel Vetter
2016-05-31 6:18 ` Gerd Hoffmann
2016-05-31 6:18 ` Gerd Hoffmann
2016-05-31 6:37 ` Daniel Vetter
2016-05-31 6:37 ` Daniel Vetter
2016-05-31 7:34 ` Gerd Hoffmann
2016-05-31 7:34 ` Gerd Hoffmann [this message]
2016-05-31 7:34 ` Gerd Hoffmann
2016-05-31 7:39 ` Daniel Vetter
2016-05-31 7:39 ` Daniel Vetter
2016-05-31 7:39 ` Daniel Vetter
2016-05-31 6:18 ` Gerd Hoffmann
2016-05-30 14:43 ` Daniel Vetter
2016-05-27 7:46 ` Gerd Hoffmann
2016-05-25 16:37 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464680085.5978.40.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.