From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: "Pavel Machek" <pavel-+ZI9xUNit7I@public.gmane.org>,
"João Paulo Rechi Vita"
<jprvita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Darren Hart" <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Network Development"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org,
"João Paulo Rechi Vita"
<jprvita-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
Subject: Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger
Date: Tue, 21 Jun 2016 11:35:38 +0200 [thread overview]
Message-ID: <1466501738.3170.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20160613212116.GA10478@amd>
On Mon, 2016-06-13 at 23:21 +0200, Pavel Machek wrote:
>
> (Actually, "::wifi" is super confusing, I'd expect that to be a led
> that blinks when wifi is active.)
Agree with that, yeah, that'd be confusing.
> Well... "airplane" is quite confusing. I'd we use "rfkill" for
> disabling radios, and I believe we should stick with that.
>
> But small problem might be polarity. You may need both "::rfkill" and
> "::not-rfkill".
I'd argue that "airplane" matches better what you're likely to find on
the chassis of the system.
In either case I think the suffixes should be documented, for both
future kernel and application developers.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: "Pavel Machek" <pavel@ucw.cz>,
"João Paulo Rechi Vita" <jprvita@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Darren Hart" <dvhart@infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger
Date: Tue, 21 Jun 2016 11:35:38 +0200 [thread overview]
Message-ID: <1466501738.3170.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20160613212116.GA10478@amd>
On Mon, 2016-06-13 at 23:21 +0200, Pavel Machek wrote:
>
> (Actually, "::wifi" is super confusing, I'd expect that to be a led
> that blinks when wifi is active.)
Agree with that, yeah, that'd be confusing.
> Well... "airplane" is quite confusing. I'd we use "rfkill" for
> disabling radios, and I believe we should stick with that.
>
> But small problem might be polarity. You may need both "::rfkill" and
> "::not-rfkill".
I'd argue that "airplane" matches better what you're likely to find on
the chassis of the system.
In either case I think the suffixes should be documented, for both
future kernel and application developers.
johannes
next prev parent reply other threads:[~2016-06-21 9:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:39 [RESEND PATCH 0/3] RFKill airplane-mode indicator João Paulo Rechi Vita
2016-05-02 14:39 ` [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger João Paulo Rechi Vita
2016-05-04 7:29 ` Pavel Machek
2016-05-12 9:32 ` Johannes Berg
2016-05-12 9:32 ` Johannes Berg
2016-05-19 7:16 ` Pavel Machek
2016-06-09 12:43 ` Johannes Berg
2016-06-09 12:43 ` Johannes Berg
2016-06-13 15:24 ` João Paulo Rechi Vita
2016-06-13 19:00 ` Pavel Machek
2016-06-13 19:59 ` João Paulo Rechi Vita
2016-06-13 19:59 ` João Paulo Rechi Vita
2016-06-13 21:01 ` Pavel Machek
2016-06-13 21:10 ` João Paulo Rechi Vita
2016-06-13 21:10 ` João Paulo Rechi Vita
2016-06-13 21:21 ` Pavel Machek
2016-06-21 9:35 ` Johannes Berg [this message]
2016-06-21 9:35 ` Johannes Berg
2016-05-02 14:39 ` [RESEND PATCH 2/3] rfkill: Userspace control for airplane mode João Paulo Rechi Vita
2016-05-02 14:39 ` [RESEND PATCH 3/3] rfkill: Notify userspace of airplane-mode state changes João Paulo Rechi Vita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466501738.3170.10.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jprvita-6IF/jdPJHihWk0Htik3J/w@public.gmane.org \
--cc=jprvita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.