From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, tglx@linutronix.de, torvalds@linux-foundation.org,
tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org
Subject: [PATCH v3 19/24] fs: nfs: Make nfs boot time y2038 safe
Date: Sat, 25 Jun 2016 14:37:43 -0700 [thread overview]
Message-ID: <1466890668-23400-20-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1466890668-23400-1-git-send-email-deepa.kernel@gmail.com>
boot_time is represented as a struct timespec.
struct timespec and CURRENT_TIME are not y2038 safe.
Overall, the plan is to use timespec64 and ktime_t for
all internal kernel representation of timestamps.
CURRENT_TIME will also be removed.
boot_time is used to construct the nfs client boot verifier.
Use ktime_t to represent boot_time and ktime_get_real() for
the boot_time value.
Following Trond's request https://lkml.org/lkml/2016/6/9/22 ,
use ktime_t instead of converting to struct timespec64.
Use higher and lower 32 bit parts of ktime_t for the boot
verifier.
Use the lower 32 bit part of ktime_t for the authsys_parms
stamp field.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
---
fs/nfs/client.c | 2 +-
fs/nfs/netns.h | 2 +-
fs/nfs/nfs4proc.c | 10 ++++++----
fs/nfs/nfs4xdr.c | 2 +-
4 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index 4849d0f..92798bb 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -1078,7 +1078,7 @@ void nfs_clients_init(struct net *net)
idr_init(&nn->cb_ident_idr);
#endif
spin_lock_init(&nn->nfs_client_lock);
- nn->boot_time = CURRENT_TIME;
+ nn->boot_time = ktime_get_real();
}
#ifdef CONFIG_PROC_FS
diff --git a/fs/nfs/netns.h b/fs/nfs/netns.h
index f0e06e4..fbce0d8 100644
--- a/fs/nfs/netns.h
+++ b/fs/nfs/netns.h
@@ -29,7 +29,7 @@ struct nfs_net {
int cb_users[NFS4_MAX_MINOR_VERSION + 1];
#endif
spinlock_t nfs_client_lock;
- struct timespec boot_time;
+ ktime_t boot_time;
#ifdef CONFIG_PROC_FS
struct proc_dir_entry *proc_nfsfs;
#endif
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 406dd3e..8d9b5a9 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5062,12 +5062,14 @@ static void nfs4_init_boot_verifier(const struct nfs_client *clp,
if (test_bit(NFS4CLNT_PURGE_STATE, &clp->cl_state)) {
/* An impossible timestamp guarantees this value
* will never match a generated boot time. */
- verf[0] = 0;
- verf[1] = cpu_to_be32(NSEC_PER_SEC + 1);
+ verf[0] = cpu_to_be32(U32_MAX);
+ verf[1] = cpu_to_be32(U32_MAX);
} else {
struct nfs_net *nn = net_generic(clp->cl_net, nfs_net_id);
- verf[0] = cpu_to_be32(nn->boot_time.tv_sec);
- verf[1] = cpu_to_be32(nn->boot_time.tv_nsec);
+ u64 ns = ktime_to_ns(nn->boot_time);
+
+ verf[0] = cpu_to_be32(ns >> 32);
+ verf[1] = cpu_to_be32(ns);
}
memcpy(bootverf->data, verf, sizeof(bootverf->data));
}
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index 661e753..5944be0 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -1850,7 +1850,7 @@ static void encode_create_session(struct xdr_stream *xdr,
*p++ = cpu_to_be32(RPC_AUTH_UNIX); /* auth_sys */
/* authsys_parms rfc1831 */
- *p++ = cpu_to_be32(nn->boot_time.tv_nsec); /* stamp */
+ *p++ = cpu_to_be32(ktime_to_ns(nn->boot_time)); /* stamp */
p = xdr_encode_array(p, clnt->cl_nodename, clnt->cl_nodelen);
*p++ = cpu_to_be32(0); /* UID */
*p++ = cpu_to_be32(0); /* GID */
--
1.9.1
next prev parent reply other threads:[~2016-06-25 21:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 21:37 [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] " Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] " Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 01/24] vfs: Add current_time() api Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 02/24] fs: proc: Delete inode time initializations in proc_alloc_inode() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 03/24] fs: Replace CURRENT_TIME with current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 04/24] fs: Replace CURRENT_TIME_SEC " Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 05/24] fs: Replace current_fs_time() with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 06/24] fs: jfs: Replace CURRENT_TIME_SEC by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 07/24] fs: ext4: Use current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 08/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 09/24] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 10/24] fs: udf: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 11/24] fs: cifs: Replace CURRENT_TIME by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 12/24] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 13/24] fs: cifs: Replace CURRENT_TIME by get_seconds Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 14/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] [PATCH v3 15/24] drivers: staging: lustre: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:45 ` [lustre-devel] " Greg Kroah-Hartman
2016-06-25 21:45 ` Greg Kroah-Hartman
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 16/24] fs: ocfs2: Use time64_t to represent orphan scan times Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 17/24] fs: ocfs2: Replace CURRENT_TIME with ktime_get_real_seconds() Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 18/24] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani [this message]
2016-06-25 21:37 ` [PATCH v3 20/24] block: Replace CURRENT_TIME with ktime_get_real_ts Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 21/24] libceph: " Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 22/24] fs: ceph: Replace current_fs_time for request stamp Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 23/24] time: Delete current_fs_time() function Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 24/24] time: Delete CURRENT_TIME_SEC Deepa Dinamani
[not found] ` <1466890668-23400-1-git-send-email-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-29 19:48 ` [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Arnd Bergmann
2016-06-29 19:48 ` [Ocfs2-devel] " Arnd Bergmann
2016-06-29 19:48 ` [lustre-devel] " Arnd Bergmann
2016-06-29 19:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466890668-23400-20-git-send-email-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.