All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Changman Lee <cm224.lee@samsung.com>,
	tytso@mit.edu, arnd@arndb.de, y2038@lists.linaro.org,
	linux-f2fs-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	tglx@linutronix.de, torvalds@linux-foundation.org
Subject: [PATCH v3 14/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times
Date: Sat, 25 Jun 2016 14:37:38 -0700	[thread overview]
Message-ID: <1466890668-23400-15-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1466890668-23400-1-git-send-email-deepa.kernel@gmail.com>

CURRENT_TIME_SEC is not y2038 safe.

Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Changman Lee <cm224.lee@samsung.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
---
 fs/f2fs/segment.c | 2 +-
 fs/f2fs/segment.h | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index e3f758d..4af7d5a 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2158,7 +2158,7 @@ static int build_sit_info(struct f2fs_sb_info *sbi)
 	sit_i->dirty_sentries = 0;
 	sit_i->sents_per_block = SIT_ENTRY_PER_BLOCK;
 	sit_i->elapsed_time = le64_to_cpu(sbi->ckpt->elapsed_time);
-	sit_i->mounted_time = CURRENT_TIME_SEC.tv_sec;
+	sit_i->mounted_time = ktime_get_real_seconds();
 	mutex_init(&sit_i->sentry_lock);
 	return 0;
 }
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 57d450f..94ab338 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -661,8 +661,9 @@ static inline void set_to_next_sit(struct sit_info *sit_i, unsigned int start)
 static inline unsigned long long get_mtime(struct f2fs_sb_info *sbi)
 {
 	struct sit_info *sit_i = SIT_I(sbi);
-	return sit_i->elapsed_time + CURRENT_TIME_SEC.tv_sec -
-						sit_i->mounted_time;
+	time64_t now = ktime_get_real_seconds();
+
+	return sit_i->elapsed_time + now - sit_i->mounted_time;
 }
 
 static inline void set_summary(struct f2fs_summary *sum, nid_t nid,
-- 
1.9.1

_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

WARNING: multiple messages have this Message-ID (diff)
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, tglx@linutronix.de, torvalds@linux-foundation.org,
	tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Changman Lee <cm224.lee@samsung.com>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH v3 14/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times
Date: Sat, 25 Jun 2016 14:37:38 -0700	[thread overview]
Message-ID: <1466890668-23400-15-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1466890668-23400-1-git-send-email-deepa.kernel@gmail.com>

CURRENT_TIME_SEC is not y2038 safe.

Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Changman Lee <cm224.lee@samsung.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
---
 fs/f2fs/segment.c | 2 +-
 fs/f2fs/segment.h | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index e3f758d..4af7d5a 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2158,7 +2158,7 @@ static int build_sit_info(struct f2fs_sb_info *sbi)
 	sit_i->dirty_sentries = 0;
 	sit_i->sents_per_block = SIT_ENTRY_PER_BLOCK;
 	sit_i->elapsed_time = le64_to_cpu(sbi->ckpt->elapsed_time);
-	sit_i->mounted_time = CURRENT_TIME_SEC.tv_sec;
+	sit_i->mounted_time = ktime_get_real_seconds();
 	mutex_init(&sit_i->sentry_lock);
 	return 0;
 }
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 57d450f..94ab338 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -661,8 +661,9 @@ static inline void set_to_next_sit(struct sit_info *sit_i, unsigned int start)
 static inline unsigned long long get_mtime(struct f2fs_sb_info *sbi)
 {
 	struct sit_info *sit_i = SIT_I(sbi);
-	return sit_i->elapsed_time + CURRENT_TIME_SEC.tv_sec -
-						sit_i->mounted_time;
+	time64_t now = ktime_get_real_seconds();
+
+	return sit_i->elapsed_time + now - sit_i->mounted_time;
 }
 
 static inline void set_summary(struct f2fs_summary *sum, nid_t nid,
-- 
1.9.1

  parent reply	other threads:[~2016-06-25 21:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25 21:37 [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] " Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] " Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 01/24] vfs: Add current_time() api Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 02/24] fs: proc: Delete inode time initializations in proc_alloc_inode() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 03/24] fs: Replace CURRENT_TIME with current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 04/24] fs: Replace CURRENT_TIME_SEC " Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 05/24] fs: Replace current_fs_time() with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 06/24] fs: jfs: Replace CURRENT_TIME_SEC by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 07/24] fs: ext4: Use current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37   ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 08/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 09/24] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 10/24] fs: udf: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 11/24] fs: cifs: Replace CURRENT_TIME by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 12/24] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 13/24] fs: cifs: Replace CURRENT_TIME by get_seconds Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani [this message]
2016-06-25 21:37   ` [PATCH v3 14/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] [PATCH v3 15/24] drivers: staging: lustre: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37   ` Deepa Dinamani
2016-06-25 21:45   ` [lustre-devel] " Greg Kroah-Hartman
2016-06-25 21:45     ` Greg Kroah-Hartman
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 16/24] fs: ocfs2: Use time64_t to represent orphan scan times Deepa Dinamani
2016-06-25 21:37   ` Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 17/24] fs: ocfs2: Replace CURRENT_TIME with ktime_get_real_seconds() Deepa Dinamani
2016-06-25 21:37   ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 18/24] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 19/24] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 20/24] block: Replace CURRENT_TIME with ktime_get_real_ts Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 21/24] libceph: " Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 22/24] fs: ceph: Replace current_fs_time for request stamp Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 23/24] time: Delete current_fs_time() function Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 24/24] time: Delete CURRENT_TIME_SEC Deepa Dinamani
     [not found] ` <1466890668-23400-1-git-send-email-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-29 19:48   ` [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Arnd Bergmann
2016-06-29 19:48     ` [Ocfs2-devel] " Arnd Bergmann
2016-06-29 19:48     ` [lustre-devel] " Arnd Bergmann
2016-06-29 19:48     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466890668-23400-15-git-send-email-deepa.kernel@gmail.com \
    --to=deepa.kernel@gmail.com \
    --cc=arnd@arndb.de \
    --cc=cm224.lee@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.