From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, tglx@linutronix.de, torvalds@linux-foundation.org,
tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
"Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: [PATCH v3 21/24] libceph: Replace CURRENT_TIME with ktime_get_real_ts
Date: Sat, 25 Jun 2016 14:37:45 -0700 [thread overview]
Message-ID: <1466890668-23400-22-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1466890668-23400-1-git-send-email-deepa.kernel@gmail.com>
CURRENT_TIME is not y2038 safe.
The macro will be deleted and all the references to it
will be replaced by ktime_get_* apis.
struct timespec is also not y2038 safe.
Retain timespec for timestamp representation here as ceph
uses it internally everywhere.
These references will be changed to use struct timespec64
in a separate patch.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: "Yan, Zheng" <zyan@redhat.com>
Cc: Sage Weil <sage@redhat.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org
---
net/ceph/messenger.c | 6 ++++--
net/ceph/osd_client.c | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index a550289..1825eed 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -1366,8 +1366,9 @@ static void prepare_write_keepalive(struct ceph_connection *con)
dout("prepare_write_keepalive %p\n", con);
con_out_kvec_reset(con);
if (con->peer_features & CEPH_FEATURE_MSGR_KEEPALIVE2) {
- struct timespec now = CURRENT_TIME;
+ struct timespec now;
+ ktime_get_real_ts(&now);
con_out_kvec_add(con, sizeof(tag_keepalive2), &tag_keepalive2);
ceph_encode_timespec(&con->out_temp_keepalive2, &now);
con_out_kvec_add(con, sizeof(con->out_temp_keepalive2),
@@ -3149,8 +3150,9 @@ bool ceph_con_keepalive_expired(struct ceph_connection *con,
{
if (interval > 0 &&
(con->peer_features & CEPH_FEATURE_MSGR_KEEPALIVE2)) {
- struct timespec now = CURRENT_TIME;
+ struct timespec now;
struct timespec ts;
+ ktime_get_real_ts(&now);
jiffies_to_timespec(interval, &ts);
ts = timespec_add(con->last_keepalive_ack, ts);
return timespec_compare(&now, &ts) >= 0;
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 8946959..44eb2d0 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -3567,7 +3567,7 @@ ceph_osdc_watch(struct ceph_osd_client *osdc,
ceph_oid_copy(&lreq->t.base_oid, oid);
ceph_oloc_copy(&lreq->t.base_oloc, oloc);
lreq->t.flags = CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK;
- lreq->mtime = CURRENT_TIME;
+ ktime_get_real_ts(&lreq->mtime);
lreq->reg_req = alloc_linger_request(lreq);
if (!lreq->reg_req) {
@@ -3625,7 +3625,7 @@ int ceph_osdc_unwatch(struct ceph_osd_client *osdc,
ceph_oid_copy(&req->r_base_oid, &lreq->t.base_oid);
ceph_oloc_copy(&req->r_base_oloc, &lreq->t.base_oloc);
req->r_flags = CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK;
- req->r_mtime = CURRENT_TIME;
+ ktime_get_real_ts(&req->r_mtime);
osd_req_op_watch_init(req, 0, lreq->linger_id,
CEPH_OSD_WATCH_OP_UNWATCH);
--
1.9.1
next prev parent reply other threads:[~2016-06-25 21:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 21:37 [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] " Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] " Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 01/24] vfs: Add current_time() api Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 02/24] fs: proc: Delete inode time initializations in proc_alloc_inode() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 03/24] fs: Replace CURRENT_TIME with current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 04/24] fs: Replace CURRENT_TIME_SEC " Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 05/24] fs: Replace current_fs_time() with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 06/24] fs: jfs: Replace CURRENT_TIME_SEC by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 07/24] fs: ext4: Use current_time() for inode timestamps Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 08/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 09/24] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 10/24] fs: udf: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 11/24] fs: cifs: Replace CURRENT_TIME by current_time() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 12/24] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 13/24] fs: cifs: Replace CURRENT_TIME by get_seconds Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 14/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [lustre-devel] [PATCH v3 15/24] drivers: staging: lustre: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:45 ` [lustre-devel] " Greg Kroah-Hartman
2016-06-25 21:45 ` Greg Kroah-Hartman
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 16/24] fs: ocfs2: Use time64_t to represent orphan scan times Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [Ocfs2-devel] [PATCH v3 17/24] fs: ocfs2: Replace CURRENT_TIME with ktime_get_real_seconds() Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 18/24] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 19/24] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 20/24] block: Replace CURRENT_TIME with ktime_get_real_ts Deepa Dinamani
2016-06-25 21:37 ` Deepa Dinamani [this message]
2016-06-25 21:37 ` [PATCH v3 22/24] fs: ceph: Replace current_fs_time for request stamp Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 23/24] time: Delete current_fs_time() function Deepa Dinamani
2016-06-25 21:37 ` [PATCH v3 24/24] time: Delete CURRENT_TIME_SEC Deepa Dinamani
[not found] ` <1466890668-23400-1-git-send-email-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-29 19:48 ` [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time() Arnd Bergmann
2016-06-29 19:48 ` [Ocfs2-devel] " Arnd Bergmann
2016-06-29 19:48 ` [lustre-devel] " Arnd Bergmann
2016-06-29 19:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466890668-23400-22-git-send-email-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.