From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors
Date: Tue, 12 Jul 2016 08:51:40 -0700 [thread overview]
Message-ID: <1468338700.8745.14.camel@perches.com> (raw)
In-Reply-To: <578501E9.6090008@osg.samsung.com>
On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote:
> On 07/12/2016 08:06 AM, Joe Perches wrote:
> > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
> > > Fix misspelled error message and existing checkpatch errors in the
> > > error message conditional.
> > []
> > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> > []
> > > @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,
> > > ? u32 left, right, top, bottom;
> > > ?
> > > ? if (ctx->state != MFCINST_HEAD_PARSED &&
> > > - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
> > > - && ctx->state != MFCINST_FINISHED) {
> > > - mfc_err("Cannont set crop\n");
> > > - return -EINVAL;
> > > - }
> > > + ????ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
> > > + ????&& ctx->state != MFCINST_FINISHED) {
> > > + mfc_err("Can not get crop information\n");
> > > + return -EINVAL;
> > > + }
> > is it a set or a get?
> vidioc_g_crop is a get routine.
> >
> > It'd be nicer for humans to read if the alignment was consistent
> Are you okay with this alignment change or would you like it
> changed?
Well, if you're resubmitting, I'd prefer it changed.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
kyungmin.park@samsung.com, k.debski@samsung.com,
jtp.park@samsung.com, mchehab@kernel.org, javier@osg.samsung.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors
Date: Tue, 12 Jul 2016 08:51:40 -0700 [thread overview]
Message-ID: <1468338700.8745.14.camel@perches.com> (raw)
In-Reply-To: <578501E9.6090008@osg.samsung.com>
On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote:
> On 07/12/2016 08:06 AM, Joe Perches wrote:
> > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
> > > Fix misspelled error message and existing checkpatch errors in the
> > > error message conditional.
> > []
> > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> > []
> > > @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,
> > > u32 left, right, top, bottom;
> > >
> > > if (ctx->state != MFCINST_HEAD_PARSED &&
> > > - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
> > > - && ctx->state != MFCINST_FINISHED) {
> > > - mfc_err("Cannont set crop\n");
> > > - return -EINVAL;
> > > - }
> > > + ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
> > > + && ctx->state != MFCINST_FINISHED) {
> > > + mfc_err("Can not get crop information\n");
> > > + return -EINVAL;
> > > + }
> > is it a set or a get?
> vidioc_g_crop is a get routine.
> >
> > It'd be nicer for humans to read if the alignment was consistent
> Are you okay with this alignment change or would you like it
> changed?
Well, if you're resubmitting, I'd prefer it changed.
Thanks.
next prev parent reply other threads:[~2016-07-12 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 22:39 [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors Shuah Khan
2016-07-11 22:39 ` Shuah Khan
2016-07-12 14:06 ` Joe Perches
2016-07-12 14:06 ` Joe Perches
2016-07-12 14:42 ` Shuah Khan
2016-07-12 14:42 ` Shuah Khan
2016-07-12 15:51 ` Joe Perches [this message]
2016-07-12 15:51 ` Joe Perches
2016-07-12 16:08 ` Shuah Khan
2016-07-12 16:08 ` Shuah Khan
2016-07-12 16:15 ` Joe Perches
2016-07-12 16:15 ` Joe Perches
2016-07-12 15:03 ` Javier Martinez Canillas
2016-07-12 15:03 ` Javier Martinez Canillas
2016-07-12 15:07 ` Shuah Khan
2016-07-12 15:07 ` Shuah Khan
2016-07-12 15:08 ` Javier Martinez Canillas
2016-07-12 15:08 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468338700.8745.14.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.