All of lore.kernel.org
 help / color / mirror / Atom feed
From: shuahkh@osg.samsung.com (Shuah Khan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors
Date: Tue, 12 Jul 2016 09:07:30 -0600	[thread overview]
Message-ID: <578507B2.9020501@osg.samsung.com> (raw)
In-Reply-To: <8dd68d9b-9455-d593-dc0f-c269c778b961@osg.samsung.com>

On 07/12/2016 09:03 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
> 
> On 07/11/2016 06:39 PM, Shuah Khan wrote:
>> Fix misspelled error message and existing checkpatch errors in the
>> error message conditional.
>>
>> WARNING: suspect code indent for conditional statements (8, 24)
>>  	if (ctx->state != MFCINST_HEAD_PARSED &&
>> [...]
>> +               mfc_err("Can not get crop information\n");
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
> 
> Patch looks good to me. Maybe is better to split the message and checkpatch
> changes in two different patches. But I don't have a strong opinion on this:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Thanks for the review. I considered splitting them, however the patch
that fixes the message will be flagged by checkpatch. It does make
sense to split the changes into two patches. What I could do is, make
the checkpatch fixes the first patch and fix the error message in the
second one.

How does that sound?

-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
	kyungmin.park@samsung.com, k.debski@samsung.com,
	jtp.park@samsung.com, mchehab@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors
Date: Tue, 12 Jul 2016 09:07:30 -0600	[thread overview]
Message-ID: <578507B2.9020501@osg.samsung.com> (raw)
In-Reply-To: <8dd68d9b-9455-d593-dc0f-c269c778b961@osg.samsung.com>

On 07/12/2016 09:03 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
> 
> On 07/11/2016 06:39 PM, Shuah Khan wrote:
>> Fix misspelled error message and existing checkpatch errors in the
>> error message conditional.
>>
>> WARNING: suspect code indent for conditional statements (8, 24)
>>  	if (ctx->state != MFCINST_HEAD_PARSED &&
>> [...]
>> +               mfc_err("Can not get crop information\n");
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
> 
> Patch looks good to me. Maybe is better to split the message and checkpatch
> changes in two different patches. But I don't have a strong opinion on this:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Thanks for the review. I considered splitting them, however the patch
that fixes the message will be flagged by checkpatch. It does make
sense to split the changes into two patches. What I could do is, make
the checkpatch fixes the first patch and fix the error message in the
second one.

How does that sound?

-- Shuah



  reply	other threads:[~2016-07-12 15:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 22:39 [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors Shuah Khan
2016-07-11 22:39 ` Shuah Khan
2016-07-12 14:06 ` Joe Perches
2016-07-12 14:06   ` Joe Perches
2016-07-12 14:42   ` Shuah Khan
2016-07-12 14:42     ` Shuah Khan
2016-07-12 15:51     ` Joe Perches
2016-07-12 15:51       ` Joe Perches
2016-07-12 16:08       ` Shuah Khan
2016-07-12 16:08         ` Shuah Khan
2016-07-12 16:15         ` Joe Perches
2016-07-12 16:15           ` Joe Perches
2016-07-12 15:03 ` Javier Martinez Canillas
2016-07-12 15:03   ` Javier Martinez Canillas
2016-07-12 15:07   ` Shuah Khan [this message]
2016-07-12 15:07     ` Shuah Khan
2016-07-12 15:08     ` Javier Martinez Canillas
2016-07-12 15:08       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578507B2.9020501@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.