From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ide: missing break statement in set_timings_mdma()
Date: Thu, 14 Jul 2016 11:40:02 +0000 [thread overview]
Message-ID: <1468496402.20552.107.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160714104802.GI18175@mwanda>
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ide: missing break statement in set_timings_mdma()
Date: Thu, 14 Jul 2016 06:40:02 -0500 [thread overview]
Message-ID: <1468496402.20552.107.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160714104802.GI18175@mwanda>
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ide: missing break statement in set_timings_mdma()
Date: Thu, 14 Jul 2016 06:40:02 -0500 [thread overview]
Message-ID: <1468496402.20552.107.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160714104802.GI18175@mwanda>
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
next prev parent reply other threads:[~2016-07-14 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 10:48 [patch] ide: missing break statement in set_timings_mdma() Dan Carpenter
2016-07-14 10:48 ` Dan Carpenter
2016-07-14 11:40 ` Benjamin Herrenschmidt [this message]
2016-07-14 11:40 ` Benjamin Herrenschmidt
2016-07-14 11:40 ` Benjamin Herrenschmidt
2016-07-26 22:26 ` David Miller
2016-07-26 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468496402.20552.107.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.