* [patch] ide: missing break statement in set_timings_mdma()
@ 2016-07-14 10:48 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-14 10:48 UTC (permalink / raw)
To: David S. Miller
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linux-ide, linuxppc-dev, kernel-janitors
There was clearly supposed to be a break statement here. Currently we
use the k2 ata timings instead of sh ata ones we intended. Probably no
one has this hardware anymore so it likely doesn't make a difference
beyond the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index 7f0434f..0c5d3a9 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
*timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
*timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
}
+ break;
case controller_un_ata6:
case controller_k2_ata6: {
/* 100Mhz cell */
^ permalink raw reply related [flat|nested] 7+ messages in thread* [patch] ide: missing break statement in set_timings_mdma()
@ 2016-07-14 10:48 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-14 10:48 UTC (permalink / raw)
To: David S. Miller
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linux-ide, linuxppc-dev, kernel-janitors
There was clearly supposed to be a break statement here. Currently we
use the k2 ata timings instead of sh ata ones we intended. Probably no
one has this hardware anymore so it likely doesn't make a difference
beyond the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index 7f0434f..0c5d3a9 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
*timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
*timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
}
+ break;
case controller_un_ata6:
case controller_k2_ata6: {
/* 100Mhz cell */
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] ide: missing break statement in set_timings_mdma()
2016-07-14 10:48 ` Dan Carpenter
(?)
@ 2016-07-14 11:40 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2016-07-14 11:40 UTC (permalink / raw)
To: Dan Carpenter, David S. Miller
Cc: Paul Mackerras, Michael Ellerman, linux-ide, linuxppc-dev,
kernel-janitors
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] ide: missing break statement in set_timings_mdma()
@ 2016-07-14 11:40 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2016-07-14 11:40 UTC (permalink / raw)
To: Dan Carpenter, David S. Miller
Cc: Paul Mackerras, Michael Ellerman, linux-ide, linuxppc-dev,
kernel-janitors
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] ide: missing break statement in set_timings_mdma()
@ 2016-07-14 11:40 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2016-07-14 11:40 UTC (permalink / raw)
To: Dan Carpenter, David S. Miller
Cc: Paul Mackerras, Michael Ellerman, linux-ide, linuxppc-dev,
kernel-janitors
On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should probably also:
CC: stable@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ide: missing break statement in set_timings_mdma()
2016-07-14 10:48 ` Dan Carpenter
@ 2016-07-26 22:26 ` David Miller
-1 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-07-26 22:26 UTC (permalink / raw)
To: dan.carpenter; +Cc: benh, paulus, mpe, linux-ide, linuxppc-dev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 14 Jul 2016 13:48:02 +0300
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ide: missing break statement in set_timings_mdma()
@ 2016-07-26 22:26 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-07-26 22:26 UTC (permalink / raw)
To: dan.carpenter; +Cc: benh, paulus, mpe, linux-ide, linuxppc-dev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 14 Jul 2016 13:48:02 +0300
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-26 22:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-14 10:48 [patch] ide: missing break statement in set_timings_mdma() Dan Carpenter
2016-07-14 10:48 ` Dan Carpenter
2016-07-14 11:40 ` Benjamin Herrenschmidt
2016-07-14 11:40 ` Benjamin Herrenschmidt
2016-07-14 11:40 ` Benjamin Herrenschmidt
2016-07-26 22:26 ` David Miller
2016-07-26 22:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.