From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: pxa: fix GPIO double shifts
Date: Sun, 31 Jul 2016 15:22:21 -0700 [thread overview]
Message-ID: <1470003741.3998.140.camel@perches.com> (raw)
In-Reply-To: <87shupxy50.fsf@belgarion.home>
On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote:
> Joe Perches <joe@perches.com> writes:
[]
> > These might be better without the automatic use of ret
> >
> > return !gpio_get_value(CORGI_GPIO_AC_IN) ||
> > ? ? ? ?!gpio_get_value(CORGI_GPIO_KEY_INT) ||
> > ? ? ? ?!gpio_get_value(CORGI_GPIO_WAKEUP);
> Yeah, I thought about this when I made the patch.
>
> I supposed it was written this way so that a printk was easier to add, that's
> why I didn't change the useless variable.
>
> I have no strong opinion about this, so if you think it's worth it I can make
> the additional change.
Hi Robert. ?Your choice.
It was one of those, 'oh, bother' type of things but?
I think it's worth it for readability and consistency.
cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: pxa: fix GPIO double shifts
Date: Sun, 31 Jul 2016 15:22:21 -0700 [thread overview]
Message-ID: <1470003741.3998.140.camel@perches.com> (raw)
In-Reply-To: <87shupxy50.fsf@belgarion.home>
On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote:
> Joe Perches <joe@perches.com> writes:
[]
> > These might be better without the automatic use of ret
> >
> > return !gpio_get_value(CORGI_GPIO_AC_IN) ||
> > !gpio_get_value(CORGI_GPIO_KEY_INT) ||
> > !gpio_get_value(CORGI_GPIO_WAKEUP);
> Yeah, I thought about this when I made the patch.
>
> I supposed it was written this way so that a printk was easier to add, that's
> why I didn't change the useless variable.
>
> I have no strong opinion about this, so if you think it's worth it I can make
> the additional change.
Hi Robert. Your choice.
It was one of those, 'oh, bother' type of things but
I think it's worth it for readability and consistency.
cheers, Joe
next prev parent reply other threads:[~2016-07-31 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:17 [PATCH v3] ARM: pxa: fix GPIO double shifts Robert Jarzmik
2016-07-31 12:17 ` Robert Jarzmik
2016-07-31 20:44 ` Joe Perches
2016-07-31 20:44 ` Joe Perches
2016-07-31 22:04 ` Robert Jarzmik
2016-07-31 22:04 ` Robert Jarzmik
2016-07-31 22:22 ` Joe Perches [this message]
2016-07-31 22:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470003741.3998.140.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.