From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Add missing newline terminators to kernel messages
Date: Tue, 16 Aug 2016 10:08:33 -0700 [thread overview]
Message-ID: <1471367313.4075.167.camel@perches.com> (raw)
In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be>
On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> Before commit 874f9c7da9a4acbc ("printk: create pr_<level> functions"),
> pr_*() calls without a trailing newline characters would be printed with
> a newline character appended, both on the console and in the output of
> the dmesg command.
Hey Geert.
This doesn't apply to -next as the pr_notice/pr_cont below is
properly changed to a single pr_notice.
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
[]
> @@ -1196,7 +1196,7 @@ void __init sanity_check_meminfo(void)
> ? pr_notice("Truncating RAM at %pa-%pa",
> ? ??&block_start, &block_end);
> ? block_end = vmalloc_limit;
> - pr_cont(" to -%pa", &block_end);
> + pr_cont(" to -%pa\n", &block_end);
> ? memblock_remove(vmalloc_limit, overlap_size);
> ? should_use_highmem = true;
> ? }
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages
Date: Tue, 16 Aug 2016 10:08:33 -0700 [thread overview]
Message-ID: <1471367313.4075.167.camel@perches.com> (raw)
In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be>
On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> Before commit 874f9c7da9a4acbc ("printk: create pr_<level> functions"),
> pr_*() calls without a trailing newline characters would be printed with
> a newline character appended, both on the console and in the output of
> the dmesg command.
Hey Geert.
This doesn't apply to -next as the pr_notice/pr_cont below is
properly changed to a single pr_notice.
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
[]
> @@ -1196,7 +1196,7 @@ void __init sanity_check_meminfo(void)
> pr_notice("Truncating RAM at %pa-%pa",
> &block_start, &block_end);
> block_end = vmalloc_limit;
> - pr_cont(" to -%pa", &block_end);
> + pr_cont(" to -%pa\n", &block_end);
> memblock_remove(vmalloc_limit, overlap_size);
> should_use_highmem = true;
> }
next prev parent reply other threads:[~2016-08-16 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 13:40 [PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven
2016-08-16 13:40 ` Geert Uytterhoeven
2016-08-16 17:08 ` Joe Perches [this message]
2016-08-16 17:08 ` Joe Perches
2016-08-16 17:50 ` Geert Uytterhoeven
2016-08-16 17:50 ` Geert Uytterhoeven
2016-08-16 18:01 ` Joe Perches
2016-08-16 18:01 ` Joe Perches
2016-08-16 18:06 ` Geert Uytterhoeven
2016-08-16 18:06 ` Geert Uytterhoeven
2016-08-16 19:13 ` Russell King - ARM Linux
2016-08-16 19:13 ` Russell King - ARM Linux
2016-08-16 20:22 ` Geert Uytterhoeven
2016-08-16 20:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471367313.4075.167.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.