From: "Verma, Vishal L" <vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Williams,
Dan J" <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linda.knippers-ZPxbGqLxI0U@public.gmane.org"
<linda.knippers-ZPxbGqLxI0U@public.gmane.org>
Cc: "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"guangrong.xiao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<guangrong.xiao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit
Date: Thu, 18 Aug 2016 20:22:29 +0000 [thread overview]
Message-ID: <1471551711.6177.25.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gM8SNLGn+ATELbBoOZWqk80_XYu41z-PDTs-3ONCGLeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 2016-08-18 at 12:54 -0700, Dan Williams wrote:
> On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers <linda.knippers@hpe.c
> om> wrote:
> >
> >
> >
> > On 8/18/2016 3:48 PM, Dan Williams wrote:
> > >
> > > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma <vishal.l.verma@int
> > > el.com> wrote:
> > > >
> > > > The nfit driver had an acpi event notification handler, but it
> > > > never
> > > > would've worked because we weren't setting the
> > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver.
> > >
> > > Let's update the changelog to be helpful for someone implementing
> > > a
> > > backport or taking this back to a -stable branch. Something like:
> > >
> > > Subject: acpi, nfit: fix event notifications
> > >
> > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> > > support for _FIT notifications, but it neglected to set the
> > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to
> > > gate
> > > notification delivery.
> >
> > While we're at it, should we update the notifier function to
> > explicitly check
> > for event 0x80 before re-evaluating the _FIT? I'm thinking about
> > some time
> > in the future when there might be more than one event.
>
> Yes, good idea.
Sounds good, part of the same patch or separately?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linda.knippers@hpe.com" <linda.knippers@hpe.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"guangrong.xiao@linux.intel.com" <guangrong.xiao@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit
Date: Thu, 18 Aug 2016 20:22:29 +0000 [thread overview]
Message-ID: <1471551711.6177.25.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gM8SNLGn+ATELbBoOZWqk80_XYu41z-PDTs-3ONCGLeA@mail.gmail.com>
On Thu, 2016-08-18 at 12:54 -0700, Dan Williams wrote:
> On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers <linda.knippers@hpe.c
> om> wrote:
> >
> >
> >
> > On 8/18/2016 3:48 PM, Dan Williams wrote:
> > >
> > > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma <vishal.l.verma@int
> > > el.com> wrote:
> > > >
> > > > The nfit driver had an acpi event notification handler, but it
> > > > never
> > > > would've worked because we weren't setting the
> > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver.
> > >
> > > Let's update the changelog to be helpful for someone implementing
> > > a
> > > backport or taking this back to a -stable branch. Something like:
> > >
> > > Subject: acpi, nfit: fix event notifications
> > >
> > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> > > support for _FIT notifications, but it neglected to set the
> > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to
> > > gate
> > > notification delivery.
> >
> > While we're at it, should we update the notifier function to
> > explicitly check
> > for event 0x80 before re-evaluating the _FIT? I'm thinking about
> > some time
> > in the future when there might be more than one event.
>
> Yes, good idea.
Sounds good, part of the same patch or separately?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linda.knippers@hpe.com" <linda.knippers@hpe.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"guangrong.xiao@linux.intel.com" <guangrong.xiao@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit
Date: Thu, 18 Aug 2016 20:22:29 +0000 [thread overview]
Message-ID: <1471551711.6177.25.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gM8SNLGn+ATELbBoOZWqk80_XYu41z-PDTs-3ONCGLeA@mail.gmail.com>
On Thu, 2016-08-18 at 12:54 -0700, Dan Williams wrote:
> On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers <linda.knippers@hpe.c
> om> wrote:
> >
> >
> >
> > On 8/18/2016 3:48 PM, Dan Williams wrote:
> > >
> > > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma <vishal.l.verma@int
> > > el.com> wrote:
> > > >
> > > > The nfit driver had an acpi event notification handler, but it
> > > > never
> > > > would've worked because we weren't setting the
> > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver.
> > >
> > > Let's update the changelog to be helpful for someone implementing
> > > a
> > > backport or taking this back to a -stable branch. Something like:
> > >
> > > Subject: acpi, nfit: fix event notifications
> > >
> > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> > > support for _FIT notifications, but it neglected to set the
> > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to
> > > gate
> > > notification delivery.
> >
> > While we're at it, should we update the notifier function to
> > explicitly check
> > for event 0x80 before re-evaluating the _FIT? I'm thinking about
> > some time
> > in the future when there might be more than one event.
>
> Yes, good idea.
Sounds good, part of the same patch or separately?
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linda.knippers@hpe.com" <linda.knippers@hpe.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"guangrong.xiao@linux.intel.com" <guangrong.xiao@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit
Date: Thu, 18 Aug 2016 20:22:29 +0000 [thread overview]
Message-ID: <1471551711.6177.25.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gM8SNLGn+ATELbBoOZWqk80_XYu41z-PDTs-3ONCGLeA@mail.gmail.com>
On Thu, 2016-08-18 at 12:54 -0700, Dan Williams wrote:
> On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers <linda.knippers@hpe.c
> om> wrote:
> >
> >
> >
> > On 8/18/2016 3:48 PM, Dan Williams wrote:
> > >
> > > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma <vishal.l.verma@int
> > > el.com> wrote:
> > > >
> > > > The nfit driver had an acpi event notification handler, but it
> > > > never
> > > > would've worked because we weren't setting the
> > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver.
> > >
> > > Let's update the changelog to be helpful for someone implementing
> > > a
> > > backport or taking this back to a -stable branch. Something like:
> > >
> > > Subject: acpi, nfit: fix event notifications
> > >
> > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> > > support for _FIT notifications, but it neglected to set the
> > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to
> > > gate
> > > notification delivery.
> >
> > While we're at it, should we update the notifier function to
> > explicitly check
> > for event 0x80 before re-evaluating the _FIT? I'm thinking about
> > some time
> > in the future when there might be more than one event.
>
> Yes, good idea.
Sounds good, part of the same patch or separately?
next prev parent reply other threads:[~2016-08-18 20:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 18:48 [PATCH] acpi, nfit: fix acpi event notifications for nfit Vishal Verma
2016-08-18 18:48 ` Vishal Verma
2016-08-18 18:48 ` Vishal Verma
2016-08-18 18:48 ` Vishal Verma
[not found] ` <1471546104-28520-1-git-send-email-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-18 19:48 ` Dan Williams
2016-08-18 19:48 ` Dan Williams
2016-08-18 19:48 ` Dan Williams
2016-08-18 19:48 ` Dan Williams
[not found] ` <CAPcyv4ixygjD8St5YP2SjfEJnVeWMsAHjqDTF8xxWPvvDWw_bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-18 19:52 ` Linda Knippers
2016-08-18 19:52 ` Linda Knippers
2016-08-18 19:52 ` Linda Knippers
2016-08-18 19:52 ` Linda Knippers
[not found] ` <07af328e-d703-fd80-20be-725f00e54812-ZPxbGqLxI0U@public.gmane.org>
2016-08-18 19:54 ` Dan Williams
2016-08-18 19:54 ` Dan Williams
2016-08-18 19:54 ` Dan Williams
2016-08-18 19:54 ` Dan Williams
[not found] ` <CAPcyv4gM8SNLGn+ATELbBoOZWqk80_XYu41z-PDTs-3ONCGLeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-18 20:22 ` Verma, Vishal L [this message]
2016-08-18 20:22 ` Verma, Vishal L
2016-08-18 20:22 ` Verma, Vishal L
2016-08-18 20:22 ` Verma, Vishal L
[not found] ` <1471551711.6177.25.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-18 20:30 ` Dan Williams
2016-08-18 20:30 ` Dan Williams
2016-08-18 20:30 ` Dan Williams
2016-08-18 20:30 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471551711.6177.25.camel@intel.com \
--to=vishal.l.verma-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=guangrong.xiao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linda.knippers-ZPxbGqLxI0U@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.