All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, linux-mm@kvack.org
Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
Date: Tue, 23 Aug 2016 11:04:03 +0300	[thread overview]
Message-ID: <1471939443.3696.2.camel@linux.intel.com> (raw)
In-Reply-To: <20160823072253.26977-1-chris@chris-wilson.co.uk>

On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote:
> PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t
> used for the iomapped region, it itself is just PAGE_KERNEL. On all
> other arches, PAGE_KERNEL_IO is undefined so in a general header we must
> refrain from using it.
> 

There is;

#define __PAGE_KERNEL_IO           (__PAGE_KERNEL)

So no functional change, but will compile on all archs.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, linux-mm@kvack.org
Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
Date: Tue, 23 Aug 2016 11:04:03 +0300	[thread overview]
Message-ID: <1471939443.3696.2.camel@linux.intel.com> (raw)
In-Reply-To: <20160823072253.26977-1-chris@chris-wilson.co.uk>

On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote:
> PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t
> used for the iomapped region, it itself is just PAGE_KERNEL. On all
> other arches, PAGE_KERNEL_IO is undefined so in a general header we must
> refrain from using it.
> 

There is;

#define __PAGE_KERNEL_IOA A A A A A A A A A A (__PAGE_KERNEL)

So no functional change, but will compile on all archs.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-08-23  8:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  7:22 [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/ Chris Wilson
2016-08-23  7:22 ` Chris Wilson
2016-08-23  7:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-23  8:04 ` Joonas Lahtinen [this message]
2016-08-23  8:04   ` [PATCH] " Joonas Lahtinen
2016-08-23 12:05   ` Daniel Vetter
2016-08-23 12:05     ` Daniel Vetter
2016-08-23 12:21     ` Chris Wilson
2016-08-23 12:21       ` Chris Wilson
2016-08-23 13:43       ` Daniel Vetter
2016-08-23 13:43         ` Daniel Vetter
2016-08-23 13:54         ` Chris Wilson
2016-08-23 13:54           ` Chris Wilson
2016-08-23 15:50         ` [PATCH v2] " Chris Wilson
2016-08-23 15:50           ` Chris Wilson
2016-08-23 16:32           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471939443.3696.2.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.