From: Daniel Vetter <daniel@ffwll.ch>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-mm@kvack.org
Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
Date: Tue, 23 Aug 2016 14:05:18 +0200 [thread overview]
Message-ID: <20160823120518.GE10980@phenom.ffwll.local> (raw)
In-Reply-To: <1471939443.3696.2.camel@linux.intel.com>
On Tue, Aug 23, 2016 at 11:04:03AM +0300, Joonas Lahtinen wrote:
> On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote:
> > PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t
> > used for the iomapped region, it itself is just PAGE_KERNEL. On all
> > other arches, PAGE_KERNEL_IO is undefined so in a general header we must
> > refrain from using it.
> >
>
> There is;
>
> #define __PAGE_KERNEL_IO (__PAGE_KERNEL)
>
> So no functional change, but will compile on all archs.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Still not happy:
CC drivers/gpio/gpiolib-of.o
In file included from drivers/gpio/gpiolib-of.c:19:0:
./include/linux/io-mapping.h: In function ‘io_mapping_init_wc’:
./include/linux/io-mapping.h:125:16: error: implicit declaration of function ‘pgprot_writecombine’ [-Werror=implicit-function-declaration]
iomap->prot = pgprot_writecombine(PAGE_KERNEL);
^~~~~~~~~~~~~~~~~~~
./include/linux/io-mapping.h:125:36: error: ‘PAGE_KERNEL’ undeclared (first use in this function)
iomap->prot = pgprot_writecombine(PAGE_KERNEL);
^~~~~~~~~~~
./include/linux/io-mapping.h:125:36: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
scripts/Makefile.build:289: recipe for target 'drivers/gpio/gpiolib-of.o' failed
make[2]: *** [drivers/gpio/gpiolib-of.o] Error 1
scripts/Makefile.build:440: recipe for target 'drivers/gpio' failed
make[1]: *** [drivers/gpio] Error 2
make[1]: *** Waiting for unfinished jobs....
DTC drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb
DTB drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.S
AS drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.o
LD drivers/gpu/drm/tilcdc/built-in.o
rm drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.S
LD drivers/gpu/drm/built-in.o
LD drivers/gpu/built-in.o
Makefile:968: recipe for target 'drivers' failed
make: *** [drivers] Error 2
arm compile-testing howto:
http://blog.ffwll.ch/2016/02/arm-kernel-cross-compiling.html
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-mm@kvack.org
Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
Date: Tue, 23 Aug 2016 14:05:18 +0200 [thread overview]
Message-ID: <20160823120518.GE10980@phenom.ffwll.local> (raw)
In-Reply-To: <1471939443.3696.2.camel@linux.intel.com>
On Tue, Aug 23, 2016 at 11:04:03AM +0300, Joonas Lahtinen wrote:
> On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote:
> > PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t
> > used for the iomapped region, it itself is just PAGE_KERNEL. On all
> > other arches, PAGE_KERNEL_IO is undefined so in a general header we must
> > refrain from using it.
> >
>
> There is;
>
> #define __PAGE_KERNEL_IOA A A A A A A A A A A (__PAGE_KERNEL)
>
> So no functional change, but will compile on all archs.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Still not happy:
CC drivers/gpio/gpiolib-of.o
In file included from drivers/gpio/gpiolib-of.c:19:0:
./include/linux/io-mapping.h: In function a??io_mapping_init_wca??:
./include/linux/io-mapping.h:125:16: error: implicit declaration of function a??pgprot_writecombinea?? [-Werror=implicit-function-declaration]
iomap->prot = pgprot_writecombine(PAGE_KERNEL);
^~~~~~~~~~~~~~~~~~~
./include/linux/io-mapping.h:125:36: error: a??PAGE_KERNELa?? undeclared (first use in this function)
iomap->prot = pgprot_writecombine(PAGE_KERNEL);
^~~~~~~~~~~
./include/linux/io-mapping.h:125:36: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
scripts/Makefile.build:289: recipe for target 'drivers/gpio/gpiolib-of.o' failed
make[2]: *** [drivers/gpio/gpiolib-of.o] Error 1
scripts/Makefile.build:440: recipe for target 'drivers/gpio' failed
make[1]: *** [drivers/gpio] Error 2
make[1]: *** Waiting for unfinished jobs....
DTC drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb
DTB drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.S
AS drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.o
LD drivers/gpu/drm/tilcdc/built-in.o
rm drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb.S
LD drivers/gpu/drm/built-in.o
LD drivers/gpu/built-in.o
Makefile:968: recipe for target 'drivers' failed
make: *** [drivers] Error 2
arm compile-testing howto:
http://blog.ffwll.ch/2016/02/arm-kernel-cross-compiling.html
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-23 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 7:22 [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/ Chris Wilson
2016-08-23 7:22 ` Chris Wilson
2016-08-23 7:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-23 8:04 ` [PATCH] " Joonas Lahtinen
2016-08-23 8:04 ` Joonas Lahtinen
2016-08-23 12:05 ` Daniel Vetter [this message]
2016-08-23 12:05 ` Daniel Vetter
2016-08-23 12:21 ` Chris Wilson
2016-08-23 12:21 ` Chris Wilson
2016-08-23 13:43 ` Daniel Vetter
2016-08-23 13:43 ` Daniel Vetter
2016-08-23 13:54 ` Chris Wilson
2016-08-23 13:54 ` Chris Wilson
2016-08-23 15:50 ` [PATCH v2] " Chris Wilson
2016-08-23 15:50 ` Chris Wilson
2016-08-23 16:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823120518.GE10980@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.