From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ia64@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()
Date: Sun, 28 Aug 2016 18:33:05 +0000 [thread overview]
Message-ID: <1472409185.26978.100.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1608281121520.3321@hadrien>
On Sun, 2016-08-28 at 11:28 +0200, Julia Lawall wrote:
> I do think that there is some value in doing similar things in a uniform
> way, using meaningful names, even if in a particular case it doesn't help
> performance or reduce code size. Even duplicating code could be OK if it
> is not in a critical path and it makes the code overall easier to
> understand. But if the maintainer prefers the code not to be duplicated,
> then of course it should not be duplicated.
All true too, thanks Julia.
It's all maintainer choice.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ia64@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()
Date: Sun, 28 Aug 2016 18:33:05 +0000 [thread overview]
Message-ID: <1472409185.26978.100.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1608281121520.3321@hadrien>
On Sun, 2016-08-28 at 11:28 +0200, Julia Lawall wrote:
> I do think that there is some value in doing similar things in a uniform
> way, using meaningful names, even if in a particular case it doesn't help
> performance or reduce code size. Even duplicating code could be OK if it
> is not in a critical path and it makes the code overall easier to
> understand. But if the maintainer prefers the code not to be duplicated,
> then of course it should not be duplicated.
All true too, thanks Julia.
It's all maintainer choice.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ia64@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()
Date: Sun, 28 Aug 2016 11:33:05 -0700 [thread overview]
Message-ID: <1472409185.26978.100.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1608281121520.3321@hadrien>
On Sun, 2016-08-28 at 11:28 +0200, Julia Lawall wrote:
> I do think that there is some value in doing similar things in a uniform
> way, using meaningful names, even if in a particular case it doesn't help
> performance or reduce code size. Even duplicating code could be OK if it
> is not in a critical path and it makes the code overall easier to
> understand. But if the maintainer prefers the code not to be duplicated,
> then of course it should not be duplicated.
All true too, thanks Julia.
It's all maintainer choice.
next prev parent reply other threads:[~2016-08-28 18:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 18:00 [PATCH 0/5] IA64: Fine-tuning for some function implementations SF Markus Elfring
2016-08-26 18:00 ` SF Markus Elfring
2016-08-26 18:02 ` [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring
2016-08-26 18:02 ` SF Markus Elfring
2016-08-26 19:57 ` Julia Lawall
2016-08-26 19:57 ` Julia Lawall
2016-08-26 21:02 ` Joe Perches
2016-08-26 21:02 ` Joe Perches
2016-08-26 21:02 ` Joe Perches
2016-08-27 7:02 ` SF Markus Elfring
2016-08-27 7:02 ` SF Markus Elfring
2016-08-27 7:02 ` SF Markus Elfring
2016-08-28 0:40 ` Joe Perches
2016-08-28 0:40 ` Joe Perches
2016-08-28 7:37 ` SF Markus Elfring
2016-08-28 7:37 ` SF Markus Elfring
2016-08-28 9:28 ` [PATCH 1/5] " Julia Lawall
2016-08-28 9:28 ` Julia Lawall
2016-08-28 18:33 ` Joe Perches [this message]
2016-08-28 18:33 ` Joe Perches
2016-08-28 18:33 ` Joe Perches
2016-08-27 6:20 ` SF Markus Elfring
2016-08-27 6:20 ` SF Markus Elfring
2016-08-26 20:18 ` [PATCH 1/5] " kbuild test robot
2016-08-26 20:18 ` kbuild test robot
2016-08-26 20:18 ` kbuild test robot
2016-08-27 8:48 ` walter harms
2016-08-27 8:48 ` walter harms
2016-08-27 8:48 ` walter harms
2016-08-26 18:03 ` [PATCH 2/5] IA64-IRQ: Delete unnecessary braces SF Markus Elfring
2016-08-26 18:03 ` SF Markus Elfring
2016-08-26 20:27 ` kbuild test robot
2016-08-26 20:27 ` kbuild test robot
2016-08-26 20:27 ` kbuild test robot
2016-08-26 18:04 ` [PATCH 3/5] ia64/mm/tlb: Fix indentation in ia64_global_tlb_purge() SF Markus Elfring
2016-08-26 18:04 ` SF Markus Elfring
2016-08-26 18:05 ` [PATCH 4/5] ia64/mm/tlb: Use kmalloc_array() in ia64_itr_entry() SF Markus Elfring
2016-08-26 18:05 ` SF Markus Elfring
2016-08-26 18:06 ` [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces SF Markus Elfring
2016-08-26 18:06 ` SF Markus Elfring
2016-08-26 20:42 ` kbuild test robot
2016-08-26 20:42 ` kbuild test robot
2016-08-26 20:42 ` kbuild test robot
2016-08-27 7:29 ` SF Markus Elfring
2016-08-27 7:29 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472409185.26978.100.camel@perches.com \
--to=joe@perches.com \
--cc=elfring@users.sourceforge.net \
--cc=fenghua.yu@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.