From: Shardar Shariff Md <smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 2/5] i2c: tegra: If fifo flush fails return error
Date: Wed, 31 Aug 2016 18:52:35 +0530 [thread overview]
Message-ID: <1472649758-5608-2-git-send-email-smohammed@nvidia.com> (raw)
In-Reply-To: <1472649758-5608-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
During i2c controller initialization, when fifo flush fails return error
instead of returning the error during exit.
Signed-off-by: Shardar Shariff Md <smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Changes in v11:
- Fix smatch error for below warning
tegra_i2c_init warn: unused return: err = tegra_i2c_flush_fifos()
---
---
drivers/i2c/busses/i2c-tegra.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e93c72a..07a39b7 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -494,6 +494,8 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
i2c_writel(i2c_dev, val, I2C_FIFO_CONTROL);
err = tegra_i2c_flush_fifos(i2c_dev);
+ if (err)
+ goto err;
if (i2c_dev->is_multimaster_mode && i2c_dev->hw->has_slcg_override_reg)
i2c_writel(i2c_dev, I2C_MST_CORE_CLKEN_OVR, I2C_CLKEN_OVERRIDE);
--
1.8.1.5
WARNING: multiple messages have this Message-ID (diff)
From: Shardar Shariff Md <smohammed@nvidia.com>
To: <smohammed@nvidia.com>, <wsa@the-dreams.de>,
<swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
<gnurou@gmail.com>, <linux-i2c@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jonathanh@nvidia.com>
Subject: [PATCH 2/5] i2c: tegra: If fifo flush fails return error
Date: Wed, 31 Aug 2016 18:52:35 +0530 [thread overview]
Message-ID: <1472649758-5608-2-git-send-email-smohammed@nvidia.com> (raw)
In-Reply-To: <1472649758-5608-1-git-send-email-smohammed@nvidia.com>
During i2c controller initialization, when fifo flush fails return error
instead of returning the error during exit.
Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
---
Changes in v11:
- Fix smatch error for below warning
tegra_i2c_init warn: unused return: err = tegra_i2c_flush_fifos()
---
---
drivers/i2c/busses/i2c-tegra.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e93c72a..07a39b7 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -494,6 +494,8 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
i2c_writel(i2c_dev, val, I2C_FIFO_CONTROL);
err = tegra_i2c_flush_fifos(i2c_dev);
+ if (err)
+ goto err;
if (i2c_dev->is_multimaster_mode && i2c_dev->hw->has_slcg_override_reg)
i2c_writel(i2c_dev, I2C_MST_CORE_CLKEN_OVR, I2C_CLKEN_OVERRIDE);
--
1.8.1.5
next prev parent reply other threads:[~2016-08-31 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 13:22 [PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
2016-08-31 13:22 ` [PATCH 3/5] i2c: tegra: add separate function for config_load programing Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
2016-08-31 13:22 ` [PATCH 4/5] i2c: tegra: use atomic poll function during configuration Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
2016-08-31 13:22 ` [PATCH 5/5] i2c: tegra: proper handling of error cases Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
[not found] ` <1472649758-5608-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-31 13:22 ` Shardar Shariff Md [this message]
2016-08-31 13:22 ` [PATCH 2/5] i2c: tegra: If fifo flush fails return error Shardar Shariff Md
2016-08-31 13:30 ` [PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Mohammed
2016-08-31 13:30 ` Shardar Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472649758-5608-2-git-send-email-smohammed@nvidia.com \
--to=smohammed-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.