From: Shardar Shariff Md <smohammed@nvidia.com>
To: smohammed@nvidia.com, wsa@the-dreams.de, swarren@wwwdotorg.org,
thierry.reding@gmail.com, gnurou@gmail.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com
Subject: [PATCH 4/5] i2c: tegra: use atomic poll function during configuration
Date: Wed, 31 Aug 2016 18:52:37 +0530 [thread overview]
Message-ID: <1472649758-5608-4-git-send-email-smohammed@nvidia.com> (raw)
In-Reply-To: <1472649758-5608-1-git-send-email-smohammed@nvidia.com>
Use readl_poll_timeout_atomic() function as *wait_for_config_load()
function can be called from interrupt context.
Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
---
Changes in v10:
- Rebase on top of [PATCH V2 0/9] Some Tegra I2C Updates
Changes in v11:
- Fix checkpatch error of using in_atomic() API
---
---
drivers/i2c/busses/i2c-tegra.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index daab0ce..2437535 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -457,8 +457,13 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
reg_offset = tegra_i2c_reg_addr(i2c_dev, I2C_CONFIG_LOAD);
addr = i2c_dev->base + reg_offset;
i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD);
- err = readl_poll_timeout(addr, val, val == 0, 1000,
- I2C_CONFIG_LOAD_TIMEOUT);
+ if (in_interrupt())
+ err = readl_poll_timeout_atomic(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+ else
+ err = readl_poll_timeout(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+
if (err) {
dev_warn(i2c_dev->dev,
"timeout waiting for config load\n");
--
1.8.1.5
WARNING: multiple messages have this Message-ID (diff)
From: Shardar Shariff Md <smohammed@nvidia.com>
To: <smohammed@nvidia.com>, <wsa@the-dreams.de>,
<swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
<gnurou@gmail.com>, <linux-i2c@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jonathanh@nvidia.com>
Subject: [PATCH 4/5] i2c: tegra: use atomic poll function during configuration
Date: Wed, 31 Aug 2016 18:52:37 +0530 [thread overview]
Message-ID: <1472649758-5608-4-git-send-email-smohammed@nvidia.com> (raw)
In-Reply-To: <1472649758-5608-1-git-send-email-smohammed@nvidia.com>
Use readl_poll_timeout_atomic() function as *wait_for_config_load()
function can be called from interrupt context.
Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
---
Changes in v10:
- Rebase on top of [PATCH V2 0/9] Some Tegra I2C Updates
Changes in v11:
- Fix checkpatch error of using in_atomic() API
---
---
drivers/i2c/busses/i2c-tegra.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index daab0ce..2437535 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -457,8 +457,13 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
reg_offset = tegra_i2c_reg_addr(i2c_dev, I2C_CONFIG_LOAD);
addr = i2c_dev->base + reg_offset;
i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD);
- err = readl_poll_timeout(addr, val, val == 0, 1000,
- I2C_CONFIG_LOAD_TIMEOUT);
+ if (in_interrupt())
+ err = readl_poll_timeout_atomic(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+ else
+ err = readl_poll_timeout(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+
if (err) {
dev_warn(i2c_dev->dev,
"timeout waiting for config load\n");
--
1.8.1.5
next prev parent reply other threads:[~2016-08-31 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 13:22 [PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
[not found] ` <1472649758-5608-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-31 13:22 ` [PATCH 2/5] i2c: tegra: If fifo flush fails return error Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
2016-08-31 13:30 ` [PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Mohammed
2016-08-31 13:30 ` Shardar Mohammed
2016-08-31 13:22 ` [PATCH 3/5] i2c: tegra: add separate function for config_load programing Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md [this message]
2016-08-31 13:22 ` [PATCH 4/5] i2c: tegra: use atomic poll function during configuration Shardar Shariff Md
2016-08-31 13:22 ` [PATCH 5/5] i2c: tegra: proper handling of error cases Shardar Shariff Md
2016-08-31 13:22 ` Shardar Shariff Md
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472649758-5608-4-git-send-email-smohammed@nvidia.com \
--to=smohammed@nvidia.com \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.