From: Joe Perches <joe@perches.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: bhumirks@gmail.com, jrickertkc@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test
Date: Thu, 15 Sep 2016 10:32:26 -0700 [thread overview]
Message-ID: <1473960746.32273.62.camel@perches.com> (raw)
In-Reply-To: <57DAD8E0.1050306@gmail.com>
On Thu, 2016-09-15 at 19:22 +0200, Sergio Paracuellos wrote:
> That's true. It seems that checkpatch script is getting a false
> positive. Just trying to do checkpatch happy. Sorry for inconvenience.
Keeping the style consistent instead of taking the simplest path
to quiet the checkpatch messages is better.
Making N, min_N, max_N all lower case would be better.
next prev parent reply other threads:[~2016-09-15 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com>
2016-09-15 14:51 ` [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test Greg KH
2016-09-15 17:22 ` Sergio Paracuellos
2016-09-15 17:32 ` Joe Perches [this message]
2016-09-16 11:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473960746.32273.62.camel@perches.com \
--to=joe@perches.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jrickertkc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.