All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	bhumirks@gmail.com, jrickertkc@gmail.com
Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test
Date: Fri, 16 Sep 2016 14:22:34 +0300	[thread overview]
Message-ID: <20160916112234.GB13620@mwanda> (raw)
In-Reply-To: <57DAD8E0.1050306@gmail.com>

On Thu, Sep 15, 2016 at 07:22:40PM +0200, Sergio Paracuellos wrote:
> That's true. It seems that checkpatch script is getting a false
> positive. Just trying to do checkpatch happy.

Also the old code was better than new code so leave it alone.

regards,
dan carpenter

      parent reply	other threads:[~2016-09-16 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com>
2016-09-15 14:51 ` [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test Greg KH
2016-09-15 17:22   ` Sergio Paracuellos
2016-09-15 17:32     ` Joe Perches
2016-09-16 11:22     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916112234.GB13620@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=bhumirks@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jrickertkc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.