From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: bhumirks@gmail.com, jrickertkc@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test
Date: Thu, 15 Sep 2016 19:22:40 +0200 [thread overview]
Message-ID: <57DAD8E0.1050306@gmail.com> (raw)
In-Reply-To: <20160915145131.GA26016@kroah.com>
That's true. It seems that checkpatch script is getting a false
positive. Just trying to do checkpatch happy. Sorry for inconvenience.
I'll be careful with Changelog stuff from now. Thanks for advice.
Cheers,
Sergio Paracuellos
El 2016年09月15日 a las 16:51, Greg KH escribió:
> On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote:
>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>> ---
>> drivers/staging/rts5208/rtsx_card.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c
>> index 9a5cd63..551e3064 100644
>> --- a/drivers/staging/rts5208/rtsx_card.c
>> +++ b/drivers/staging/rts5208/rtsx_card.c
>> @@ -645,7 +645,7 @@ int switch_ssc_clock(struct rtsx_chip *chip, int clk)
>> dev_dbg(rtsx_dev(chip), "Switch SSC clock to %dMHz (cur_clk = %d)\n",
>> clk, chip->cur_clk);
>>
>> - if ((clk <= 2) || (N > max_N)) {
>> + if ((clk <= 2) || (max_N < N)) {
>
> Where is the constant?
>
> The original code looks fine to me...
>
> Also, I can't take patches where there is no changelog text, sorry.
>
> greg k-h
>
next prev parent reply other threads:[~2016-09-15 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com>
2016-09-15 14:51 ` [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test Greg KH
2016-09-15 17:22 ` Sergio Paracuellos [this message]
2016-09-15 17:32 ` Joe Perches
2016-09-16 11:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DAD8E0.1050306@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jrickertkc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.