From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth
Date: Wed, 21 Sep 2016 19:02:39 +1000 [thread overview]
Message-ID: <1474448559.2857.118.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160921031809.GT20488@umbus>
On Wed, 2016-09-21 at 13:18 +1000, David Gibson wrote:
> > There are actually a couple of places where I agree with the style
> > change, so I'll include that in a futher post after more useful
> review
> > has been posted (seriously, stylebots are just infuriating).
>
> So.. as irritating as you find the bot, there are a bunch of
> gratuitous style problems. In particular sungem.c itself isn't
> consistent about whether it has 8 char or 4 char indentation. That
> really does need to be fixed.
No time to work on this now. I will try to get back on to it later but
I'm happy for anybody to pick it up if they want to.
Cheers,
Ben.
next prev parent reply other threads:[~2016-09-21 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 22:48 [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth Benjamin Herrenschmidt
2016-08-14 22:54 ` no-reply
2016-08-14 23:59 ` Benjamin Herrenschmidt
2016-08-15 0:11 ` Benjamin Herrenschmidt
2016-09-21 3:18 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2016-09-21 9:02 ` Benjamin Herrenschmidt [this message]
2016-09-21 10:16 ` [Qemu-devel] " Alex Bennée
2016-09-21 10:40 ` Benjamin Herrenschmidt
2016-09-21 11:52 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474448559.2857.118.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.