From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth
Date: Wed, 21 Sep 2016 20:40:19 +1000 [thread overview]
Message-ID: <1474454419.2857.122.camel@kernel.crashing.org> (raw)
In-Reply-To: <87intpblrm.fsf@linaro.org>
On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote:
>
> > >
> > > total: 428 errors, 73 warnings, 1950 lines checked
> > >
> > > Your patch has style problems, please review.If any of these
> > > errors
> > > are false positives report them to the maintainer, see
> > > CHECKPATCH in MAINTAINERS.
>
> It seems very unlikely all of the reported errors here can be
> justified
> along the lines of internal consistency, especially for adding a new
> file.
It's actually an old thread ;-) I've already fixed some of these, just
haven't had a chance to finish and submit a new version.
However *most* of the above are intentional and I won't fix, it's about
the .h file describing the registers that is essentially lifted from
Linux and that I want to keep largely identical for obvious reasons
(thus including the use of tabs).
Cheers,
Ben.
next prev parent reply other threads:[~2016-09-21 10:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 22:48 [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth Benjamin Herrenschmidt
2016-08-14 22:54 ` no-reply
2016-08-14 23:59 ` Benjamin Herrenschmidt
2016-08-15 0:11 ` Benjamin Herrenschmidt
2016-09-21 3:18 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2016-09-21 9:02 ` Benjamin Herrenschmidt
2016-09-21 10:16 ` [Qemu-devel] " Alex Bennée
2016-09-21 10:40 ` Benjamin Herrenschmidt [this message]
2016-09-21 11:52 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474454419.2857.122.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.