From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Al Viro <viro@ZenIV.linux.org.uk>,
Ilya Dryomov <idryomov@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Ceph Development <ceph-devel@vger.kernel.org>,
Alex Elder <elder@kernel.org>, Sage Weil <sage@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org
Subject: Re: "CodingStyle: Clarify and complete chapter 7" in docs-next
Date: Thu, 22 Sep 2016 10:49:47 -0700 [thread overview]
Message-ID: <1474566587.8253.14.camel@perches.com> (raw)
In-Reply-To: <20160922135758.0399725d@endymion>
On Thu, 2016-09-22 at 13:57 +0200, Jean Delvare wrote:
> Sure. But I'm afraid you keep changing topics and I have no idea where
> you are going. We started with "should there be a space before jump
> labels", then out of nowhere we were discussing the wording of the
> output of checkpatch (how is that related?) and now you pull statistics
> out of your hat, like these numbers imply anything.
No, not out of a hat. Those are the results of a silly script that
runs checkpatch on every .[ch] kernel file (but not tools/) with:
--show-types --terse --emacs --strict --no-summary --quiet -f
The magnitude of "ERRORS" is high and it's not necessary or useful
to modify old or obsolete code just to reduce that magnitude.
> checkpatch was called checkPATCH for a reason.
That's why I promote the --force option to limit using checkpatch on
files outside of staging.
https://patchwork.kernel.org/patch/9332205/
Andrew? Are you going to apply that one day?
> ERROR means that the new code isn't allowed to do that. Period.
Disagree. The compiler doesn't care. The value of consistency in
reducing defects is very hard to quantify.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Al Viro <viro@ZenIV.linux.org.uk>,
Ilya Dryomov <idryomov@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Ceph Development <ceph-devel@vger.kernel.org>,
Alex Elder <elder@kernel.org>, Sage Weil <sage@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org
Subject: Re: "CodingStyle: Clarify and complete chapter 7" in docs-next
Date: Thu, 22 Sep 2016 17:49:47 +0000 [thread overview]
Message-ID: <1474566587.8253.14.camel@perches.com> (raw)
In-Reply-To: <20160922135758.0399725d@endymion>
On Thu, 2016-09-22 at 13:57 +0200, Jean Delvare wrote:
> Sure. But I'm afraid you keep changing topics and I have no idea where
> you are going. We started with "should there be a space before jump
> labels", then out of nowhere we were discussing the wording of the
> output of checkpatch (how is that related?) and now you pull statistics
> out of your hat, like these numbers imply anything.
No, not out of a hat. Those are the results of a silly script that
runs checkpatch on every .[ch] kernel file (but not tools/) with:
--show-types --terse --emacs --strict --no-summary --quiet -f
The magnitude of "ERRORS" is high and it's not necessary or useful
to modify old or obsolete code just to reduce that magnitude.
> checkpatch was called checkPATCH for a reason.
That's why I promote the --force option to limit using checkpatch on
files outside of staging.
https://patchwork.kernel.org/patch/9332205/
Andrew? Are you going to apply that one day?
> ERROR means that the new code isn't allowed to do that. Period.
Disagree. The compiler doesn't care. The value of consistency in
reducing defects is very hard to quantify.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-22 17:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 11:53 "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Ilya Dryomov
2016-09-19 11:53 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust Ilya Dryomov
2016-09-20 0:11 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Al Viro
2016-09-20 0:11 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Al Viro
2016-09-20 2:46 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Joe Perches
2016-09-20 2:46 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Joe Perches
2016-09-20 5:53 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Julia Lawall
2016-09-20 5:53 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Julia Lawall
2016-09-20 6:32 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Joe Perches
2016-09-20 6:32 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Joe Perches
2016-09-20 6:46 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) Julia Lawall
2016-09-20 6:46 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Julia Lawall
2016-09-22 9:24 ` "CodingStyle: Clarify and complete chapter 7" in docs-next Jean Delvare
2016-09-22 9:24 ` Jean Delvare
2016-09-22 10:42 ` Joe Perches
2016-09-22 10:42 ` Joe Perches
2016-09-22 11:57 ` Jean Delvare
2016-09-22 11:57 ` Jean Delvare
2016-09-22 13:11 ` Al Viro
2016-09-22 13:11 ` Al Viro
2016-09-22 14:58 ` Jean Delvare
2016-09-22 14:58 ` Jean Delvare
2016-09-22 15:05 ` Julia Lawall
2016-09-22 15:05 ` Julia Lawall
2016-09-22 17:50 ` Joe Perches
2016-09-22 17:50 ` Joe Perches
2016-09-22 17:49 ` Joe Perches [this message]
2016-09-22 17:49 ` Joe Perches
2016-09-22 19:47 ` Jean Delvare
2016-09-22 19:47 ` Jean Delvare
2016-09-22 10:43 ` Jani Nikula
2016-09-22 10:43 ` Jani Nikula
2016-09-22 12:46 ` Jean Delvare
2016-09-22 12:46 ` Jean Delvare
2016-09-22 13:06 ` Jani Nikula
2016-09-22 13:06 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474566587.8253.14.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=ceph-devel@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=elder@kernel.org \
--cc=idryomov@gmail.com \
--cc=jdelvare@suse.de \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.