All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "kbuild: forbid kernel directory to contain spaces and colons" has been added to the 4.4-stable tree
@ 2016-09-26  9:47 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-09-26  9:47 UTC (permalink / raw)
  To: robert.jarzmik, gregkh, mmarek; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    kbuild: forbid kernel directory to contain spaces and colons

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     kbuild-forbid-kernel-directory-to-contain-spaces-and-colons.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 51193b76bfff5027cf96ba63effae808ad67cca7 Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Sat, 2 Apr 2016 21:38:53 +0200
Subject: kbuild: forbid kernel directory to contain spaces and colons

From: Robert Jarzmik <robert.jarzmik@free.fr>

commit 51193b76bfff5027cf96ba63effae808ad67cca7 upstream.

When the kernel path contains a space or a colon somewhere in the path
name, the modules_install target doesn't work anymore, as the path names
are not enclosed in double quotes. It is also supposed that and O= build
will suffer from the same weakness as modules_install.

Instead of checking and improving kbuild to resist to directories
including these characters, error out early to prevent any build if the
kernel's main directory contains a space.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Michal Marek <mmarek@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 Makefile |    4 ++++
 1 file changed, 4 insertions(+)

--- a/Makefile
+++ b/Makefile
@@ -128,6 +128,10 @@ _all:
 # Cancel implicit rules on top Makefile
 $(CURDIR)/Makefile Makefile: ;
 
+ifneq ($(words $(subst :, ,$(CURDIR))), 1)
+  $(error main directory cannot contain spaces nor colons)
+endif
+
 ifneq ($(KBUILD_OUTPUT),)
 # Invoke a second make in the output directory, passing relevant variables
 # check that the output directory actually exists


Patches currently in stable-queue which might be from robert.jarzmik@free.fr are

queue-4.4/kbuild-forbid-kernel-directory-to-contain-spaces-and-colons.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-09-26  9:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26  9:47 Patch "kbuild: forbid kernel directory to contain spaces and colons" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.